Skip to content

[PW_SID:1087042] microchip core-qspi cleanup#1832

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw1087042
Closed

[PW_SID:1087042] microchip core-qspi cleanup#1832
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw1087042

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

PR for series 1087042 applied to workflow__riscv__fixes

Name: microchip core-qspi cleanup
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1087042
Version: 2

…ead of which controller

When prepare_message callbacks fail, the SPI core already reports which
controller the failure happened on. The corresponding code in the mem_ops
portion of the driver already reports the device a timeout occurred on,
so make the regular part of the driver do the same.

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
I noticed this define was incorrect, it should be UpperAddress, but in
renaming it it became clear there were actually no users. Just get rid
of it.

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] spi: microchip-core-qspi: report device on which timeout occured instead of which controller"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 138.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] spi: microchip-core-qspi: report device on which timeout occured instead of which controller"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 931.86 seconds
Result: ERROR
Output:

Redirect to /build/tmp.vaizjKkRRk and /build/tmp.ayJw9cdtgF
Tree base:
01805bc4f902e ("Adding CI files")
Building the whole tree with the patch
error:
Warning: /build/tmpr1unu29f/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c:244 struct __packed mtk_mfg_opp_entry { __le32 freq_khz; __le32 voltage_core; __le32 voltage_sram; __le32 posdiv; __le32 voltage_margin; __le32 power_mw; }; error: Cannot parse struct or union!
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_vec_words_unaligned'; recompile with -fPIC
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_words_unaligned'; recompile with -fPIC
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_vec_bytes_unaligned'; recompile with -fPIC
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_bytes_unaligned'; recompile with -fPIC



real	15m23.293s
user	577m41.596s
sys	108m23.453s

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] spi: microchip-core-qspi: report device on which timeout occured instead of which controller"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1409.43 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] spi: microchip-core-qspi: report device on which timeout occured instead of which controller"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.42 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] spi: microchip-core-qspi: report device on which timeout occured instead of which controller"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.40 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] spi: microchip-core-qspi: report device on which timeout occured instead of which controller"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.78 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] spi: microchip-core-qspi: report device on which timeout occured instead of which controller"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 86.78 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] spi: microchip-core-qspi: report device on which timeout occured instead of which controller"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.35 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] spi: microchip-core-qspi: report device on which timeout occured instead of which controller"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] spi: microchip-core-qspi: report device on which timeout occured instead of which controller"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] spi: microchip-core-qspi: report device on which timeout occured instead of which controller"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] spi: microchip-core-qspi: report device on which timeout occured instead of which controller"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.45 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] spi: microchip-core-qspi: remove an unused define"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 138.38 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] spi: microchip-core-qspi: remove an unused define"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 937.64 seconds
Result: ERROR
Output:

Redirect to /build/tmp.neZZ603ZGo and /build/tmp.mjrECTutzH
Tree base:
4a49cb2b747ce ("spi: microchip-core-qspi: report device on which timeout occured instead of which controller")
Building the whole tree with the patch
error:
Warning: /build/tmpf7xwtu0k/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c:244 struct __packed mtk_mfg_opp_entry { __le32 freq_khz; __le32 voltage_core; __le32 voltage_sram; __le32 posdiv; __le32 voltage_margin; __le32 power_mw; }; error: Cannot parse struct or union!
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_vec_words_unaligned'; recompile with -fPIC
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_vec_bytes_unaligned'; recompile with -fPIC
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_words_unaligned'; recompile with -fPIC
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_bytes_unaligned'; recompile with -fPIC



real	15m28.511s
user	578m22.209s
sys	108m33.045s

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] spi: microchip-core-qspi: remove an unused define"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1398.79 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] spi: microchip-core-qspi: remove an unused define"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.10 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] spi: microchip-core-qspi: remove an unused define"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.55 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] spi: microchip-core-qspi: remove an unused define"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.78 seconds
Result: WARNING
Output:

WARNING: Possible repeated word: 'it'
#7: 
renaming it it became clear there were actually no users. Just get rid

total: 0 errors, 1 warnings, 0 checks, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 7a824dce4f72 ("spi: microchip-core-qspi: remove an unused define") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 7 lines checked
WARNING: Possible repeated word: 'it'


@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] spi: microchip-core-qspi: remove an unused define"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.12 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] spi: microchip-core-qspi: remove an unused define"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] spi: microchip-core-qspi: remove an unused define"
kdoc
Desc: Detects for kdoc errors
Duration: 0.85 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] spi: microchip-core-qspi: remove an unused define"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] spi: microchip-core-qspi: remove an unused define"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] spi: microchip-core-qspi: remove an unused define"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1087042 branch April 29, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants