Skip to content

[PW_SID:1087340] [v2] ASoC: spacemit: fix RX DMA params not set when TX is running#1836

Closed
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__fixesfrom
pw1087340
Closed

[PW_SID:1087340] [v2] ASoC: spacemit: fix RX DMA params not set when TX is running#1836
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__fixesfrom
pw1087340

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Apr 29, 2026

PR for series 1087340 applied to workflow__riscv__fixes

Name: [v2] ASoC: spacemit: fix RX DMA params not set when TX is running
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1087340
Version: 2

nathanchance and others added 3 commits April 24, 2026 07:25
@nathanchance
riscv: Define __riscv_copy_{,vec_}{words,bytes}_unaligned() using SYM…
70d3902 
…_TYPED_FUNC_START

After commit 67bdd7b ("riscv: Split out measure_cycles() for
reuse") and commit c03ad15 ("riscv: Reuse measure_cycles() in
check_vector_unaligned_access()"), there are CFI failure when booting
kernels with CONFIG_CFI=y:

  CFI failure at measure_cycles+0x38/0xe0 (target: __riscv_copy_words_unaligned+0x0/0x50; expected type: ...)
  CFI failure at measure_cycles+0x38/0xe0 (target: __riscv_copy_vec_words_unaligned+0x0/0x24; expected type: ...)

The __riscv_copy_*_unaligned() functions are now called indirectly but
they are not defined with SYM_TYPED_FUNC_START, which is required for
assembly functions called indirectly from C to pass CFI checking. Switch
to SYM_TYPED_FUNC_START to clear up the CFI failures.

Fixes: 67bdd7b ("riscv: Split out measure_cycles() for reuse")
Fixes: c03ad15 ("riscv: Reuse measure_cycles() in check_vector_unaligned_access()")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Nam Cao <namcao@linutronix.de>
Link: https://patch.msgid.link/20260406-measure_cycles-cfi-failure-v1-1-03e0234ae02f@kernel.org
Signed-off-by: Paul Walmsley <pjw@kernel.org>
Adding CI files
01805bc
@TroyMitchell911
ASoC: spacemit: fix RX DMA params not set when TX is running
03cd6c2 
When TX is already running (SSCR_SSE is set), the hw_params callback
returns early before setting up DMA parameters for the RX stream. This
prevents the capture path from configuring its DMA data properly.

Move the SSCR_SSE check after DMA parameter setup and format
constraints, so both TX and RX streams get their DMA configuration
regardless of whether the hardware is already enabled. The early return
now only skips the register writes that would disrupt an active stream.

Fixes: fce2174 ("ASoC: spacemit: add i2s support for K1 SoC")
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 1: "[v2] ASoC: spacemit: fix RX DMA params not set when TX is running"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.39 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 1: "[v2] ASoC: spacemit: fix RX DMA params not set when TX is running"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 924.60 seconds
Result: ERROR
Output:

Redirect to /build/tmp.KnmjI2yn34 and /build/tmp.xK2qBYZyQ7
Tree base:
01805bc4f902e ("Adding CI files")
Building the whole tree with the patch
error:
Warning: /build/tmp0yiwzlkb/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c:244 struct __packed mtk_mfg_opp_entry { __le32 freq_khz; __le32 voltage_core; __le32 voltage_sram; __le32 posdiv; __le32 voltage_margin; __le32 power_mw; }; error: Cannot parse struct or union!
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_vec_words_unaligned'; recompile with -fPIC
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_vec_bytes_unaligned'; recompile with -fPIC
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_words_unaligned'; recompile with -fPIC
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_bytes_unaligned'; recompile with -fPIC



real	15m15.645s
user	571m25.593s
sys	107m45.459s

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 1: "[v2] ASoC: spacemit: fix RX DMA params not set when TX is running"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1383.39 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 1: "[v2] ASoC: spacemit: fix RX DMA params not set when TX is running"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.45 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 1: "[v2] ASoC: spacemit: fix RX DMA params not set when TX is running"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.50 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 1: "[v2] ASoC: spacemit: fix RX DMA params not set when TX is running"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.80 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 1: "[v2] ASoC: spacemit: fix RX DMA params not set when TX is running"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 85.20 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 1: "[v2] ASoC: spacemit: fix RX DMA params not set when TX is running"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 1: "[v2] ASoC: spacemit: fix RX DMA params not set when TX is running"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 1: "[v2] ASoC: spacemit: fix RX DMA params not set when TX is running"
module-param
Desc: Detect module_param changes
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 1: "[v2] ASoC: spacemit: fix RX DMA params not set when TX is running"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 1: "[v2] ASoC: spacemit: fix RX DMA params not set when TX is running"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 1.13 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__fixes branch from 01805bc to 94a07a2 Compare April 30, 2026 05:50
@linux-riscv-bot linux-riscv-bot deleted the pw1087340 branch April 30, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linux-riscv-bot @nathanchance @TroyMitchell911