Skip to content

[PW_SID:1088799] spi: support the SpacemiT K1 SPI controller#1856

Closed
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__fixesfrom
pw1088799
Closed

[PW_SID:1088799] spi: support the SpacemiT K1 SPI controller#1856
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__fixesfrom
pw1088799

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented May 2, 2026

PR for series 1088799 applied to workflow__riscv__fixes

Name: spi: support the SpacemiT K1 SPI controller
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1088799
Version: 10

alexelder added 3 commits May 2, 2026 14:13
@alexelder
spi: dt-bindings: add SpacemiT K1 SPI support
a757e87 
Add support for the SPI controller implemented by the SpacemiT K1 SoC.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Acked-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Alex Elder <elder@riscstar.com>
Signed-off-by: Guodong Xu <guodong@riscstar.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@alexelder
spi: spacemit: introduce SpacemiT K1 SPI controller driver
1124224 
This patch introduces the driver for the SPI controller found in the
SpacemiT K1 SoC.  Currently the driver supports master mode only.
The SPI hardware implements RX and TX FIFOs, 32 entries each, and
supports both PIO and DMA mode transfers.

Signed-off-by: Alex Elder <elder@riscstar.com>
Signed-off-by: Guodong Xu <guodong@riscstar.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@alexelder
riscv: dts: spacemit: define a SPI controller node
d6692be 
Define a node for the fourth SoC SPI controller (number 3) on the
SpacemiT K1 SoC.

Enable it on the Banana Pi BPI-F3 board, which exposes this feature
via its GPIO block:
  GPIO PIN 19:  MOSI
  GPIO PIN 21:  MISO
  GPIO PIN 23:  SCLK
  GPIO PIN 24:  SS (inverted)

Define pincontrol configurations for the pins as used on that board.

(This was tested using a GigaDevice GD25Q64E SPI NOR chip.)

Reviewed-by: Yixun Lan <dlan@gentoo.org>
Signed-off-by: Alex Elder <elder@riscstar.com>
Signed-off-by: Guodong Xu <guodong@riscstar.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 1: "[v10,1/3] spi: dt-bindings: add SpacemiT K1 SPI support"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 114.19 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 1: "[v10,1/3] spi: dt-bindings: add SpacemiT K1 SPI support"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1015.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 1: "[v10,1/3] spi: dt-bindings: add SpacemiT K1 SPI support"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1366.02 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 1: "[v10,1/3] spi: dt-bindings: add SpacemiT K1 SPI support"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.50 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 1: "[v10,1/3] spi: dt-bindings: add SpacemiT K1 SPI support"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.03 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 1: "[v10,1/3] spi: dt-bindings: add SpacemiT K1 SPI support"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.53 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 84 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit a757e87e3933 ("spi: dt-bindings: add SpacemiT K1 SPI support") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 84 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 1: "[v10,1/3] spi: dt-bindings: add SpacemiT K1 SPI support"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 77.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 1: "[v10,1/3] spi: dt-bindings: add SpacemiT K1 SPI support"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 1: "[v10,1/3] spi: dt-bindings: add SpacemiT K1 SPI support"
kdoc
Desc: Detects for kdoc errors
Duration: 0.71 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 1: "[v10,1/3] spi: dt-bindings: add SpacemiT K1 SPI support"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 1: "[v10,1/3] spi: dt-bindings: add SpacemiT K1 SPI support"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 1: "[v10,1/3] spi: dt-bindings: add SpacemiT K1 SPI support"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 2: "[v10,2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 114.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 2: "[v10,2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1046.76 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 2: "[v10,2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1407.94 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 2: "[v10,2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.36 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 2: "[v10,2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.67 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 2: "[v10,2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.85 seconds
Result: WARNING
Output:

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#29: FILE: drivers/spi/Kconfig:1088:
+config SPI_SPACEMIT_K1
+	tristate "K1 SPI Controller"
+	depends on ARCH_SPACEMIT || COMPILE_TEST
+	depends on OF
+	imply MMP_PDMA if ARCH_SPACEMIT
+	default m if ARCH_SPACEMIT
+	help
+	  Enable support for the SpacemiT K1 SPI controller.
+

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

CHECK: Blank lines aren't necessary before a close brace '}'
#333: FILE: drivers/spi/spi-spacemit-k1.c:275:
+
+}

total: 0 errors, 2 warnings, 1 checks, 811 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 11242247a62a ("spi: spacemit: introduce SpacemiT K1 SPI controller driver") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 1 checks, 811 lines checked
CHECK: Blank lines aren't necessary before a close brace '}'
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 2: "[v10,2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 77.47 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 2: "[v10,2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 2: "[v10,2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver"
kdoc
Desc: Detects for kdoc errors
Duration: 0.71 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 2: "[v10,2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 2: "[v10,2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 2: "[v10,2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 3: "[v10,3/3] riscv: dts: spacemit: define a SPI controller node"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 114.66 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 3: "[v10,3/3] riscv: dts: spacemit: define a SPI controller node"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1075.79 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 3: "[v10,3/3] riscv: dts: spacemit: define a SPI controller node"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1455.93 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 3: "[v10,3/3] riscv: dts: spacemit: define a SPI controller node"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.20 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 3: "[v10,3/3] riscv: dts: spacemit: define a SPI controller node"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.78 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 3: "[v10,3/3] riscv: dts: spacemit: define a SPI controller node"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.48 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 3: "[v10,3/3] riscv: dts: spacemit: define a SPI controller node"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 76.92 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 3: "[v10,3/3] riscv: dts: spacemit: define a SPI controller node"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 3: "[v10,3/3] riscv: dts: spacemit: define a SPI controller node"
kdoc
Desc: Detects for kdoc errors
Duration: 0.72 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 3: "[v10,3/3] riscv: dts: spacemit: define a SPI controller node"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 3: "[v10,3/3] riscv: dts: spacemit: define a SPI controller node"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 2, 2026

Patch 3: "[v10,3/3] riscv: dts: spacemit: define a SPI controller node"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1088799 branch May 7, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @alexelder