Skip to content

[PW_SID:1091676] [RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest#1887

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw1091676
Closed

[PW_SID:1091676] [RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest#1887
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw1091676

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented May 8, 2026

PR for series 1091676 applied to workflow__riscv__fixes

Name: [RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1091676
Version: 1

toblux added 2 commits May 8, 2026 15:14
@toblux
riscv/purgatory: return bool from verify_sha256_digest
170af23 
Change the function's return type from int to bool and return the result
of memcmp() directly to simplify the code.  While at it, cast ->start to
'const u8 *' to better match the expected type.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@toblux
riscv/purgatory: add asm/purgatory.h
a08dc86 
Add arch/riscv/include/asm/purgatory.h and provide the purgatory()
prototype via the architecture header, mirroring the x86 layout.

Remove the workaround from arch/riscv/purgatory/purgatory.c.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 1: "[RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 113.63 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 1: "[RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1104.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 1: "[RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1609.11 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 1: "[RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.17 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 1: "[RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.54 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 1: "[RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.61 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 1: "[RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 75.48 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 1: "[RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 1: "[RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest"
kdoc
Desc: Detects for kdoc errors
Duration: 0.70 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 1: "[RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 1: "[RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 1: "[RESEND,1/2] riscv/purgatory: return bool from verify_sha256_digest"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 2: "[RESEND,2/2] riscv/purgatory: add asm/purgatory.h"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 114.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 2: "[RESEND,2/2] riscv/purgatory: add asm/purgatory.h"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1121.42 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 2: "[RESEND,2/2] riscv/purgatory: add asm/purgatory.h"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1638.78 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 2: "[RESEND,2/2] riscv/purgatory: add asm/purgatory.h"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.03 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 2: "[RESEND,2/2] riscv/purgatory: add asm/purgatory.h"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.71 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 2: "[RESEND,2/2] riscv/purgatory: add asm/purgatory.h"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.77 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

CHECK: extern prototypes should be avoided in .h files
#32: FILE: arch/riscv/include/asm/purgatory.h:8:
+extern void purgatory(void);

total: 0 errors, 1 warnings, 1 checks, 30 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit a08dc8617083 ("riscv/purgatory: add asm/purgatory.h") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 1 checks, 30 lines checked
CHECK: extern prototypes should be avoided in .h files
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 2: "[RESEND,2/2] riscv/purgatory: add asm/purgatory.h"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 76.51 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 2: "[RESEND,2/2] riscv/purgatory: add asm/purgatory.h"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 2: "[RESEND,2/2] riscv/purgatory: add asm/purgatory.h"
kdoc
Desc: Detects for kdoc errors
Duration: 0.72 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 2: "[RESEND,2/2] riscv/purgatory: add asm/purgatory.h"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 2: "[RESEND,2/2] riscv/purgatory: add asm/purgatory.h"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 8, 2026

Patch 2: "[RESEND,2/2] riscv/purgatory: add asm/purgatory.h"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1091676 branch May 9, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @toblux