Skip to content

[PW_SID:1094378] [v1] rtc: mpfs: fix counter upload completion condition#1927

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1094378
Closed

[PW_SID:1094378] [v1] rtc: mpfs: fix counter upload completion condition#1927
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1094378

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented May 13, 2026

PR for series 1094378 applied to workflow__riscv__fixes

Name: [v1] rtc: mpfs: fix counter upload completion condition
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1094378
Version: 1

@ConchuOD
rtc: mpfs: fix counter upload completion condition
ccd6a39 
The condition that needs to be checked for upload completion is the
UPLOAD bit in the completion register going low. The original iterations
of this driver used a do-while and this was converted to a
read_poll_timeout() during upstreaming without the condition being
inverted as it should have been.

I suspect that this went unnoticed until now because a) the first read
was done when the bit was still set, immediately completing the
read_poll_timeout() and b) because the RTC doesn't hold time when power
is removed from the SoC reducing its utility (I for one keep it
disabled). If my first suspicion was true when the driver was
upstreamed, it's not true any longer though, hence the detection of the
problem.

Fixes: 0b31d70 ("rtc: Add driver for Microchip PolarFire SoC")
CC: stable@vger.kernel.org
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 13, 2026

Patch 1: "[v1] rtc: mpfs: fix counter upload completion condition"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 138.77 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 13, 2026

Patch 1: "[v1] rtc: mpfs: fix counter upload completion condition"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1040.71 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 13, 2026

Patch 1: "[v1] rtc: mpfs: fix counter upload completion condition"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1426.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 13, 2026

Patch 1: "[v1] rtc: mpfs: fix counter upload completion condition"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.65 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 13, 2026

Patch 1: "[v1] rtc: mpfs: fix counter upload completion condition"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.93 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 13, 2026

Patch 1: "[v1] rtc: mpfs: fix counter upload completion condition"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.76 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 13, 2026

Patch 1: "[v1] rtc: mpfs: fix counter upload completion condition"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 85.96 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 13, 2026

Patch 1: "[v1] rtc: mpfs: fix counter upload completion condition"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 13, 2026

Patch 1: "[v1] rtc: mpfs: fix counter upload completion condition"
kdoc
Desc: Detects for kdoc errors
Duration: 0.81 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 13, 2026

Patch 1: "[v1] rtc: mpfs: fix counter upload completion condition"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 13, 2026

Patch 1: "[v1] rtc: mpfs: fix counter upload completion condition"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 13, 2026

Patch 1: "[v1] rtc: mpfs: fix counter upload completion condition"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1094378 branch May 13, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @ConchuOD