Skip to content

[PW_SID:1095491] [v2] riscv: lib: add strrchr() zbb implementation#1949

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw1095491
Closed

[PW_SID:1095491] [v2] riscv: lib: add strrchr() zbb implementation#1949
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw1095491

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented May 15, 2026

PR for series 1095491 applied to workflow__riscv__fixes

Name: [v2] riscv: lib: add strrchr() zbb implementation
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1095491
Version: 2

Linux RISC-V bot and others added 2 commits May 14, 2026 08:49
Adding CI files
cd9d421
@MilanTripkovic02
riscv: lib: add strrchr() zbb implementation
a4fb714 
Add an zbb assembly implementation of strrchr() for RISC-V.
The implementation uses ZBB bit-manipulation instructions such as
orc.b, ctz, and clz to process multiple bytes per iteration and
significantly improve performance for longer strings compared to
the generic byte-by-byte implementation.

For the test case, I used the existing string_bench_strrchr benchmark,
but I changed the input character from '\0' to 'a' to obtain more
realistic results, because I added a check for '\0' in the assembly code.

Benchmark results (QEMU TCG, rv64):

  Len   | ZBB    | WoZBB | %ZBB/WoZBB
  ------|--------|--------|------------
  1 B   | 20.0   | 22.9   | -12.7%
  7 B   | 87.5   | 110.1  | -20.5%
  8 B   | 166.8  | 130.3  | +28.0%
  16 B  | 329.5  | 189.1  | +74.2%
  31 B  | 366.9  | 195.7  | +87.5%
  64 B  | 870.3  | 231.5  | +275.9%
  127 B | 1007.0 | 278.9  | +261.1%
  512 B | 1751.9 | 305.5  | +473.5%
  1024 B| 1841.9 | 294.7  | +525.0%
  2048 B| 1955.4 | 310.4  | +530.0%
  4096 B| 2034.6 | 312.5  | +551.1%

Signed-off-by: Milan Tripkovic <Milan.Tripkovic@rt-rk.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 15, 2026

Patch 1: "[v2] riscv: lib: add strrchr() zbb implementation"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 112.56 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 15, 2026

Patch 1: "[v2] riscv: lib: add strrchr() zbb implementation"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 999.84 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 15, 2026

Patch 1: "[v2] riscv: lib: add strrchr() zbb implementation"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1357.12 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 15, 2026

Patch 1: "[v2] riscv: lib: add strrchr() zbb implementation"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.01 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 15, 2026

Patch 1: "[v2] riscv: lib: add strrchr() zbb implementation"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.48 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 15, 2026

Patch 1: "[v2] riscv: lib: add strrchr() zbb implementation"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.58 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 15, 2026

Patch 1: "[v2] riscv: lib: add strrchr() zbb implementation"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 76.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 15, 2026

Patch 1: "[v2] riscv: lib: add strrchr() zbb implementation"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 15, 2026

Patch 1: "[v2] riscv: lib: add strrchr() zbb implementation"
kdoc
Desc: Detects for kdoc errors
Duration: 0.70 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 15, 2026

Patch 1: "[v2] riscv: lib: add strrchr() zbb implementation"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 15, 2026

Patch 1: "[v2] riscv: lib: add strrchr() zbb implementation"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 15, 2026

Patch 1: "[v2] riscv: lib: add strrchr() zbb implementation"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__fixes branch from cd9d421 to a1231b7 Compare May 22, 2026 06:39
@linux-riscv-bot linux-riscv-bot deleted the pw1095491 branch May 22, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @MilanTripkovic02