[PW_SID:1096076] clk: add Siflower SF21 topcrm support by linux-riscv-bot · Pull Request #1955 · linux-riscv/linux

linux-riscv-bot · 2026-05-17T14:32:52Z

PR for series 1096076 applied to workflow__riscv__fixes

Name: clk: add Siflower SF21 topcrm support
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1096076
Version: 1

Siflower RISC-V SoCs, including SF21A6826 and SF21H8898, are RISC-V chips with T-Head C908 cores for home routers and gateways. Add a Kconfig entry named ARCH_SIFLOWER for them. Notably these chips uses ARM PL011 for UART. ARM_AMBA is selected for its driver. Signed-off-by: Chuanhong Guo <gch981213@gmail.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Add the device tree binding header for Siflower SF21A6826/SF21H8898 toplevel clock and reset module. The header covers both clock and reset IDs provided by the block. CLK_ETH_REF_P is a clock name that exists in the vendor datasheet. This clock connects directly to CLK_PCIEPLL_FOUT2 and there's no clock gate/mux in between. An alias is created for this clock to make available clock names align with the datasheet. Signed-off-by: Chuanhong Guo <gch981213@gmail.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Add a binding doc for the top clock and reset module found on Siflower SF21 SoCs. This block provides the main PLLs, high-level clock controls, and some reset lines. Signed-off-by: Chuanhong Guo <gch981213@gmail.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

This commit adds a driver for the Toplevel clock and reset controller found on Siflower SF21A6826/SF21H8898 SoCs. This block contains control for 3 PLLs, several clock mux/gate/divider blocks, and a reset register for on-chip peripherals. There are also two registers for enabling PCIE clock output in this block. They aren't covered by this patch because I can't test those without a PCIE driver. These will be added with the PCIE driver patchset later after I get that working. Signed-off-by: Chuanhong Guo <gch981213@gmail.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2026-05-17T14:38:18Z

Patch 1: "[1/4] riscv: add Siflower RISC-V SoC family Kconfig support"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 113.83 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T14:55:36Z

Patch 1: "[1/4] riscv: add Siflower RISC-V SoC family Kconfig support"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1036.85 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T15:20:38Z

Patch 1: "[1/4] riscv: add Siflower RISC-V SoC family Kconfig support"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1500.03 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T15:21:00Z

Patch 1: "[1/4] riscv: add Siflower RISC-V SoC family Kconfig support"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.50 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T15:21:23Z

Patch 1: "[1/4] riscv: add Siflower RISC-V SoC family Kconfig support"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.76 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T15:21:26Z

Patch 1: "[1/4] riscv: add Siflower RISC-V SoC family Kconfig support"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.50 seconds
Result: WARNING
Output:

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#26: FILE: arch/riscv/Kconfig.socs:40:
+config ARCH_SIFLOWER
+	bool "Siflower RISC-V SoCs"
+	select ARM_AMBA if TTY
+	select ERRATA_THEAD
+	help
+	  This enables support for Siflower RISC-V SoC platform hardware.
+

total: 0 errors, 1 warnings, 0 checks, 13 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit e57f291c4987 ("riscv: add Siflower RISC-V SoC family Kconfig support") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 13 lines checked
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines

linux-riscv-bot · 2026-05-17T15:22:49Z

Patch 1: "[1/4] riscv: add Siflower RISC-V SoC family Kconfig support"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 81.56 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T15:22:50Z

Patch 1: "[1/4] riscv: add Siflower RISC-V SoC family Kconfig support"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T15:22:52Z

Patch 1: "[1/4] riscv: add Siflower RISC-V SoC family Kconfig support"
kdoc
Desc: Detects for kdoc errors
Duration: 0.75 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T15:22:54Z

Patch 1: "[1/4] riscv: add Siflower RISC-V SoC family Kconfig support"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T15:22:56Z

Patch 1: "[1/4] riscv: add Siflower RISC-V SoC family Kconfig support"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T15:22:57Z

Patch 1: "[1/4] riscv: add Siflower RISC-V SoC family Kconfig support"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T15:25:12Z

Patch 2: "[2/4] dt-bindings: clock: add binding header for sf21-topcrm"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 118.24 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T15:42:41Z

Patch 2: "[2/4] dt-bindings: clock: add binding header for sf21-topcrm"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1047.95 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:06:02Z

Patch 2: "[2/4] dt-bindings: clock: add binding header for sf21-topcrm"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1398.78 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:06:23Z

Patch 2: "[2/4] dt-bindings: clock: add binding header for sf21-topcrm"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.24 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:06:45Z

Patch 2: "[2/4] dt-bindings: clock: add binding header for sf21-topcrm"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.62 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:06:48Z

Patch 2: "[2/4] dt-bindings: clock: add binding header for sf21-topcrm"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.71 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 63 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit c7787745da03 ("dt-bindings: clock: add binding header for sf21-topcrm") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 63 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

linux-riscv-bot · 2026-05-17T16:08:07Z

Patch 2: "[2/4] dt-bindings: clock: add binding header for sf21-topcrm"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 77.04 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:08:08Z

Patch 2: "[2/4] dt-bindings: clock: add binding header for sf21-topcrm"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:08:11Z

Patch 2: "[2/4] dt-bindings: clock: add binding header for sf21-topcrm"
kdoc
Desc: Detects for kdoc errors
Duration: 0.73 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:08:12Z

Patch 2: "[2/4] dt-bindings: clock: add binding header for sf21-topcrm"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:08:14Z

Patch 2: "[2/4] dt-bindings: clock: add binding header for sf21-topcrm"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:08:16Z

Patch 2: "[2/4] dt-bindings: clock: add binding header for sf21-topcrm"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.27 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:10:25Z

Patch 3: "[3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 114.16 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:27:13Z

Patch 3: "[3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1006.35 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:49:58Z

Patch 3: "[3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1364.40 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:50:19Z

Patch 3: "[3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.19 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:50:41Z

Patch 3: "[3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.63 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:50:44Z

Patch 3: "[3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.57 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 69 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit ed5e3b8f949d ("dt-bindings: clock: add doc for Siflower sf21-topcrm") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 69 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

linux-riscv-bot · 2026-05-17T16:52:01Z

Patch 3: "[3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 75.62 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:52:03Z

Patch 3: "[3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:52:05Z

Patch 3: "[3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm"
kdoc
Desc: Detects for kdoc errors
Duration: 0.71 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:52:06Z

Patch 3: "[3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:52:08Z

Patch 3: "[3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:52:10Z

Patch 3: "[3/4] dt-bindings: clock: add doc for Siflower sf21-topcrm"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T16:54:18Z

Patch 4: "[4/4] clk: add support for siflower sf21-topcrm"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 113.44 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T17:13:11Z

Patch 4: "[4/4] clk: add support for siflower sf21-topcrm"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1131.81 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T17:40:37Z

Patch 4: "[4/4] clk: add support for siflower sf21-topcrm"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1644.53 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T17:40:58Z

Patch 4: "[4/4] clk: add support for siflower sf21-topcrm"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.48 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T17:41:20Z

Patch 4: "[4/4] clk: add support for siflower sf21-topcrm"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.68 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T17:41:25Z

Patch 4: "[4/4] clk: add support for siflower sf21-topcrm"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 3.26 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#61: FILE: drivers/clk/siflower/Kconfig:3:
+menuconfig CLK_SIFLOWER
+	bool "Clock driver for Siflower SoCs"
+	depends on ARCH_SIFLOWER || COMPILE_TEST
+	default ARCH_SIFLOWER
+	help
+	  Clock drivers for Siflower Linux-capable SoCs.
+

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#70: FILE: drivers/clk/siflower/Kconfig:12:
+config CLK_SF21_TOPCRM
+	tristate "Clock driver for Siflower SF21 toplevel clock & reset module"
+	depends on ARCH_SIFLOWER || COMPILE_TEST
+	default ARCH_SIFLOWER
+	select RESET_CONTROLLER
+	help
+	  Supports the toplevel clock and reset module in Siflower SF21 SoCs.
+	  If this kernel is meant to run on Siflower SF21A6826 or SF21H8898,
+	  enable this driver.
+

total: 0 errors, 3 warnings, 0 checks, 1090 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 2dc7b206fde4 ("clk: add support for siflower sf21-topcrm") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 3 warnings, 0 checks, 1090 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines

linux-riscv-bot · 2026-05-17T17:42:42Z

Patch 4: "[4/4] clk: add support for siflower sf21-topcrm"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 75.20 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T17:42:43Z

Patch 4: "[4/4] clk: add support for siflower sf21-topcrm"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T17:42:46Z

Patch 4: "[4/4] clk: add support for siflower sf21-topcrm"
kdoc
Desc: Detects for kdoc errors
Duration: 0.71 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T17:42:48Z

Patch 4: "[4/4] clk: add support for siflower sf21-topcrm"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T17:42:49Z

Patch 4: "[4/4] clk: add support for siflower sf21-topcrm"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.49 seconds
Result: PASS

linux-riscv-bot · 2026-05-17T17:42:51Z

Patch 4: "[4/4] clk: add support for siflower sf21-topcrm"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.26 seconds
Result: PASS

981213 added 4 commits May 17, 2026 14:32

linux-riscv-bot closed this May 20, 2026

linux-riscv-bot deleted the pw1096076 branch May 20, 2026 00:03

Conversation

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026

Uh oh!

linux-riscv-bot commented May 17, 2026