Skip to content

[PW_SID:1096269] spacemit: fix USB2 clock and reset#1958

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw1096269
Closed

[PW_SID:1096269] spacemit: fix USB2 clock and reset#1958
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw1096269

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented May 18, 2026

PR for series 1096269 applied to workflow__riscv__fixes

Name: spacemit: fix USB2 clock and reset
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1096269
Version: 1

Yixun Lan added 2 commits May 18, 2026 06:45
clk: spacemit: k3: fix USB2 bus clock
1dc78e4 
According to SpacemiT K3's updated docs, the USB2 ahb reset and USB2 bus
clock enable bit was wrongly swapped, the correct one should be:

Register : APMU_USB_CLK_RES_CTRL
bit[1]   : usb2_port_bus_clk_en
bit[0]   : usb2_port_ahb_rstn

Fixes: e371a77 ("clk: spacemit: k3: add the clock tree")
Reported-by: Junzhong Pan <panjunzhong@linux.spacemit.com>
Signed-off-by: Yixun Lan <dlan@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
reset: spacemit: k3: fix USB2 ahb reset
4d968ae 
According to SpacemiT K3's updated docs, the USB2 ahb reset and USB2 bus
clock enable bit was wrongly swapped, the correct one should be:

Register : APMU_USB_CLK_RES_CTRL
bit[1]   : usb2_port_bus_clk_en
bit[0]   : usb2_port_ahb_rstn

Fixes: a0e0c2f ("reset: spacemit: k3: Decouple composite reset lines")
Reported-by: Junzhong Pan <panjunzhong@linux.spacemit.com>
Signed-off-by: Yixun Lan <dlan@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 1: "[1/2] clk: spacemit: k3: fix USB2 bus clock"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 113.82 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 1: "[1/2] clk: spacemit: k3: fix USB2 bus clock"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1037.95 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 1: "[1/2] clk: spacemit: k3: fix USB2 bus clock"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1401.91 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 1: "[1/2] clk: spacemit: k3: fix USB2 bus clock"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.36 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 1: "[1/2] clk: spacemit: k3: fix USB2 bus clock"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.56 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 1: "[1/2] clk: spacemit: k3: fix USB2 bus clock"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.53 seconds
Result: WARNING
Output:

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#14: 
Reported-by: Junzhong Pan <panjunzhong@linux.spacemit.com>
Signed-off-by: Yixun Lan <dlan@kernel.org>

total: 0 errors, 1 warnings, 0 checks, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 1dc78e46c205 ("clk: spacemit: k3: fix USB2 bus clock") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 1: "[1/2] clk: spacemit: k3: fix USB2 bus clock"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 77.18 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 1: "[1/2] clk: spacemit: k3: fix USB2 bus clock"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 1: "[1/2] clk: spacemit: k3: fix USB2 bus clock"
kdoc
Desc: Detects for kdoc errors
Duration: 0.72 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 1: "[1/2] clk: spacemit: k3: fix USB2 bus clock"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 1: "[1/2] clk: spacemit: k3: fix USB2 bus clock"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 1: "[1/2] clk: spacemit: k3: fix USB2 bus clock"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 2: "[2/2] reset: spacemit: k3: fix USB2 ahb reset"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 113.89 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 2: "[2/2] reset: spacemit: k3: fix USB2 ahb reset"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1039.86 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 2: "[2/2] reset: spacemit: k3: fix USB2 ahb reset"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1401.47 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 2: "[2/2] reset: spacemit: k3: fix USB2 ahb reset"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 18.97 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 2: "[2/2] reset: spacemit: k3: fix USB2 ahb reset"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.55 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 2: "[2/2] reset: spacemit: k3: fix USB2 ahb reset"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.84 seconds
Result: WARNING
Output:

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#14: 
Reported-by: Junzhong Pan <panjunzhong@linux.spacemit.com>
Signed-off-by: Yixun Lan <dlan@kernel.org>

total: 0 errors, 1 warnings, 0 checks, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 4d968ae6a708 ("reset: spacemit: k3: fix USB2 ahb reset") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 2: "[2/2] reset: spacemit: k3: fix USB2 ahb reset"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 76.32 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 2: "[2/2] reset: spacemit: k3: fix USB2 ahb reset"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.39 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 2: "[2/2] reset: spacemit: k3: fix USB2 ahb reset"
kdoc
Desc: Detects for kdoc errors
Duration: 0.70 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 2: "[2/2] reset: spacemit: k3: fix USB2 ahb reset"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 2: "[2/2] reset: spacemit: k3: fix USB2 ahb reset"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 18, 2026

Patch 2: "[2/2] reset: spacemit: k3: fix USB2 ahb reset"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1096269 branch May 19, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@linux-riscv-bot