Skip to content

[PW_SID:1100775] RISC-V: KVM: Fix timer state restore#2016

Open
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1100775
Open

[PW_SID:1100775] RISC-V: KVM: Fix timer state restore#2016
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1100775

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented May 26, 2026

PR for series 1100775 applied to workflow__riscv__fixes

Name: RISC-V: KVM: Fix timer state restore
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1100775
Version: 1

@JohnsPony
RISC-V: KVM: Fix timer state restore
8a6d79d 
The KVM_REG_RISCV_TIMER_REG(state) one-reg write passes the value
written by userspace to kvm_riscv_vcpu_timer_next_event() when
re-enabling the timer.

That value is the timer state, KVM_RISCV_TIMER_STATE_ON, not the
timer compare value. During migration or state restore, userspace
restores the compare register separately, which stores the target
cycle in t->next_cycles. Re-arming the timer with the state value
schedules the next event at cycle 1 instead of the restored compare
value, causing the virtual timer to fire too early.

Use the restored compare value from t->next_cycles when turning the
timer back on.

Fixes: 3a9f66c ("RISC-V: KVM: Add timer functionality")

Signed-off-by: Qiang Ma <maqianga@uniontech.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 26, 2026

Patch 1: "RISC-V: KVM: Fix timer state restore"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 140.59 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 26, 2026

Patch 1: "RISC-V: KVM: Fix timer state restore"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1040.56 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 26, 2026

Patch 1: "RISC-V: KVM: Fix timer state restore"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1424.84 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 26, 2026

Patch 1: "RISC-V: KVM: Fix timer state restore"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.87 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 26, 2026

Patch 1: "RISC-V: KVM: Fix timer state restore"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 26, 2026

Patch 1: "RISC-V: KVM: Fix timer state restore"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.78 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 26, 2026

Patch 1: "RISC-V: KVM: Fix timer state restore"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 87.49 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 26, 2026

Patch 1: "RISC-V: KVM: Fix timer state restore"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 26, 2026

Patch 1: "RISC-V: KVM: Fix timer state restore"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 26, 2026

Patch 1: "RISC-V: KVM: Fix timer state restore"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 26, 2026

Patch 1: "RISC-V: KVM: Fix timer state restore"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 1.63 seconds
Result: ERROR
Output:

Commit: 8a6d79d307768 ("RISC-V: KVM: Fix timer state restore")
	Fixes tag: Fixes: 3a9f66cb25e1 ("RISC-V: KVM: Add timer functionality")
	Has these problem(s):
		- empty lines surround the Fixes tag
Problems with Fixes tag: 1

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 26, 2026

Patch 1: "RISC-V: KVM: Fix timer state restore"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @JohnsPony