[PW_SID:955072] [fixes,v2,1/2] riscv: Replace function-like macro by static inline function#316
[PW_SID:955072] [fixes,v2,1/2] riscv: Replace function-like macro by static inline function#316linux-riscv-bot wants to merge 3 commits into
Conversation
The flush_icache_range() function is implemented as a "function-like macro with unused parameters", which can result in "unused variables" warnings. Replace the macro with a static inline function, as advised by Documentation/process/coding-style.rst. Fixes: 08f051e ("RISC-V: Flush I$ when making a dirty page executable") Signed-off-by: Björn Töpel <bjorn@rivosinc.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
The XOL (execute out-of-line) buffer is used to single-step the replaced instruction(s) for uprobes. The RISC-V port was missing a proper fence.i (i$ flushing) after constructing the XOL buffer, which can result in incorrect execution of stale/broken instructions. This was found running the BPF selftests "test_progs: uprobe_autoattach, attach_probe" on the Spacemit K1/X60, where the uprobes tests randomly blew up. Reviewed-by: Guo Ren <guoren@kernel.org> Fixes: 7478408 ("riscv: Add uprobes supported") Signed-off-by: Björn Töpel <bjorn@rivosinc.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
|
Patch 1: "[fixes,v2,1/2] riscv: Replace function-like macro by static inline function" |
|
Patch 1: "[fixes,v2,1/2] riscv: Replace function-like macro by static inline function" |
|
Patch 1: "[fixes,v2,1/2] riscv: Replace function-like macro by static inline function" |
|
Patch 1: "[fixes,v2,1/2] riscv: Replace function-like macro by static inline function" |
|
Patch 1: "[fixes,v2,1/2] riscv: Replace function-like macro by static inline function" |
|
Patch 1: "[fixes,v2,1/2] riscv: Replace function-like macro by static inline function" |
|
Patch 1: "[fixes,v2,1/2] riscv: Replace function-like macro by static inline function" |
|
Patch 1: "[fixes,v2,1/2] riscv: Replace function-like macro by static inline function" |
|
Patch 1: "[fixes,v2,1/2] riscv: Replace function-like macro by static inline function" |
|
Patch 1: "[fixes,v2,1/2] riscv: Replace function-like macro by static inline function" |
|
Patch 1: "[fixes,v2,1/2] riscv: Replace function-like macro by static inline function" |
|
Patch 1: "[fixes,v2,1/2] riscv: Replace function-like macro by static inline function" |
|
Patch 2: "[fixes,v2,2/2] riscv: uprobes: Add missing fence.i after building the XOL buffer" |
|
Patch 2: "[fixes,v2,2/2] riscv: uprobes: Add missing fence.i after building the XOL buffer" |
|
Patch 2: "[fixes,v2,2/2] riscv: uprobes: Add missing fence.i after building the XOL buffer" |
|
Patch 2: "[fixes,v2,2/2] riscv: uprobes: Add missing fence.i after building the XOL buffer" |
|
Patch 2: "[fixes,v2,2/2] riscv: uprobes: Add missing fence.i after building the XOL buffer" |
|
Patch 2: "[fixes,v2,2/2] riscv: uprobes: Add missing fence.i after building the XOL buffer" |
|
Patch 2: "[fixes,v2,2/2] riscv: uprobes: Add missing fence.i after building the XOL buffer" |
|
Patch 2: "[fixes,v2,2/2] riscv: uprobes: Add missing fence.i after building the XOL buffer" |
|
Patch 2: "[fixes,v2,2/2] riscv: uprobes: Add missing fence.i after building the XOL buffer" |
|
Patch 2: "[fixes,v2,2/2] riscv: uprobes: Add missing fence.i after building the XOL buffer" |
|
Patch 2: "[fixes,v2,2/2] riscv: uprobes: Add missing fence.i after building the XOL buffer" |
|
Patch 2: "[fixes,v2,2/2] riscv: uprobes: Add missing fence.i after building the XOL buffer" |
linux-riscv-bot
force-pushed
the
workflow__riscv__fixes
branch
from
6c2725a to
c8da138
Compare
2 participants
PR for series 955072 applied to workflow__riscv__fixes
Name: [fixes,v2,1/2] riscv: Replace function-like macro by static inline function
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=955072
Version: 2