[PW_SID:956104] Change PWM-controlled LED pin active mode and algorithm by linux-riscv-bot · Pull Request #332 · linux-riscv/linux

linux-riscv-bot · 2025-04-23T10:21:03Z

PR for series 956104 applied to workflow__riscv__fixes

Name: Change PWM-controlled LED pin active mode and algorithm
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=956104
Version: 13

…active-low properties This removes the active-low properties of the PWM-controlled LEDs in the HiFive Unmatched device tree. The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1]. Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf [0] Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf [1] Acked-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Signed-off-by: Vincent Chen <vincent.chen@sifive.com> Signed-off-by: Nylon Chen <nylon.chen@sifive.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

The `frac` variable represents the pulse inactive time, and the result of this algorithm is the pulse active time. Therefore, we must reverse the result. The reference is SiFive FU740-C000 Manual[0] Link: https://sifive.cdn.prismic.io/sifive/1a82e600-1f93-4f41-b2d8-86ed8b16acba_fu740-c000-manual-v1p6.pdf [0] Co-developed-by: Zong Li <zong.li@sifive.com> Signed-off-by: Zong Li <zong.li@sifive.com> Co-developed-by: Vincent Chen <vincent.chen@sifive.com> Signed-off-by: Vincent Chen <vincent.chen@sifive.com> Signed-off-by: Nylon Chen <nylon.chen@sifive.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

…y_state_debug function Round the result to the nearest whole number. This ensures that real_period is always a reasonable integer that is not lower than the actual value. e.g. $ echo 110 > /sys/devices/platform/led-controller-1/leds/d12/brightness $ .apply is not idempotent (ena=1 pol=0 1739692/4032985) -> (ena=1 pol=0 1739630/4032985) Co-developed-by: Zong Li <zong.li@sifive.com> Signed-off-by: Zong Li <zong.li@sifive.com> Signed-off-by: Nylon Chen <nylon.chen@sifive.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Fix PWM apply and get_state rounding to ensure consistency between setting and reading values This fixes the reported errors: pwm-sifive 10021000.pwm: .apply is supposed to round down duty_cycle (requested: 360/504000, applied: 361/504124) pwm-sifive 10021000.pwm: .apply is supposed to round down period (requested: 504000, applied: 504124) Co-developed-by: Zong Li <zong.li@sifive.com> Signed-off-by: Zong Li <zong.li@sifive.com> Signed-off-by: Nylon Chen <nylon.chen@sifive.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

The reference manual says "pwms >= pwmcmpX -> HIGH", but in Figure 29 pwmcmpXcenter is forced to 0 via an XOR, so hardware actually outputs HIGH when pwms < pwmcmpX. Thus pwmcmp holds the off-period count, and the driver must invert it to expose a normal active-high interface. Co-developed-by: Zong Li <zong.li@sifive.com> Signed-off-by: Zong Li <zong.li@sifive.com> Signed-off-by: Nylon Chen <nylon.chen@sifive.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2025-04-23T10:24:18Z

Patch 1: "[v13,1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.19 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T10:39:28Z

Patch 1: "[v13,1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 908.13 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T10:59:24Z

Patch 1: "[v13,1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1194.74 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T10:59:47Z

Patch 1: "[v13,1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.28 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:00:10Z

Patch 1: "[v13,1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.78 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:00:12Z

Patch 1: "[v13,1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.84 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:00:53Z

Patch 1: "[v13,1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 39.35 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:00:55Z

Patch 1: "[v13,1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:00:58Z

Patch 1: "[v13,1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:00:59Z

Patch 1: "[v13,1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:01:01Z

Patch 1: "[v13,1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:01:03Z

Patch 1: "[v13,1/5] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:03:02Z

Patch 2: "[v13,2/5] pwm: sifive: change the PWM algorithm"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.51 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:17:54Z

Patch 2: "[v13,2/5] pwm: sifive: change the PWM algorithm"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 890.04 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:37:32Z

Patch 2: "[v13,2/5] pwm: sifive: change the PWM algorithm"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1176.90 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:37:54Z

Patch 2: "[v13,2/5] pwm: sifive: change the PWM algorithm"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.09 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:38:17Z

Patch 2: "[v13,2/5] pwm: sifive: change the PWM algorithm"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.17 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:38:19Z

Patch 2: "[v13,2/5] pwm: sifive: change the PWM algorithm"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.73 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:38:59Z

Patch 2: "[v13,2/5] pwm: sifive: change the PWM algorithm"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 38.72 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:39:01Z

Patch 2: "[v13,2/5] pwm: sifive: change the PWM algorithm"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:39:03Z

Patch 2: "[v13,2/5] pwm: sifive: change the PWM algorithm"
kdoc
Desc: Detects for kdoc errors
Duration: 0.84 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:39:05Z

Patch 2: "[v13,2/5] pwm: sifive: change the PWM algorithm"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:39:07Z

Patch 2: "[v13,2/5] pwm: sifive: change the PWM algorithm"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T11:39:09Z

Patch 2: "[v13,2/5] pwm: sifive: change the PWM algorithm"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:17:07Z

Patch 3: "[v13,3/5] pwm: sifive: Fix the error in the idempotent test within the pwm_apply_state_debug function"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:17:09Z

Patch 3: "[v13,3/5] pwm: sifive: Fix the error in the idempotent test within the pwm_apply_state_debug function"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:19:06Z

Patch 4: "[v13,4/5] pwm: sifive: Fix rounding issues in apply and get_state functions"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 101.25 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:33:54Z

Patch 4: "[v13,4/5] pwm: sifive: Fix rounding issues in apply and get_state functions"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 886.21 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:53:31Z

Patch 4: "[v13,4/5] pwm: sifive: Fix rounding issues in apply and get_state functions"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1175.23 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:53:53Z

Patch 4: "[v13,4/5] pwm: sifive: Fix rounding issues in apply and get_state functions"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.90 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:54:16Z

Patch 4: "[v13,4/5] pwm: sifive: Fix rounding issues in apply and get_state functions"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.27 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:54:18Z

Patch 4: "[v13,4/5] pwm: sifive: Fix rounding issues in apply and get_state functions"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.71 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:54:59Z

Patch 4: "[v13,4/5] pwm: sifive: Fix rounding issues in apply and get_state functions"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 39.44 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:55:01Z

Patch 4: "[v13,4/5] pwm: sifive: Fix rounding issues in apply and get_state functions"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:55:04Z

Patch 4: "[v13,4/5] pwm: sifive: Fix rounding issues in apply and get_state functions"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:55:05Z

Patch 4: "[v13,4/5] pwm: sifive: Fix rounding issues in apply and get_state functions"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:55:07Z

Patch 4: "[v13,4/5] pwm: sifive: Fix rounding issues in apply and get_state functions"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:55:09Z

Patch 4: "[v13,4/5] pwm: sifive: Fix rounding issues in apply and get_state functions"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T12:57:05Z

Patch 5: "[v13,5/5] pwm: sifive: clarify inverted compare logic in comments"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 101.07 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T13:11:55Z

Patch 5: "[v13,5/5] pwm: sifive: clarify inverted compare logic in comments"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 888.12 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T13:31:34Z

Patch 5: "[v13,5/5] pwm: sifive: clarify inverted compare logic in comments"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1177.15 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T13:31:56Z

Patch 5: "[v13,5/5] pwm: sifive: clarify inverted compare logic in comments"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.00 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T13:32:19Z

Patch 5: "[v13,5/5] pwm: sifive: clarify inverted compare logic in comments"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.27 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T13:32:21Z

Patch 5: "[v13,5/5] pwm: sifive: clarify inverted compare logic in comments"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.72 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T13:33:02Z

Patch 5: "[v13,5/5] pwm: sifive: clarify inverted compare logic in comments"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 39.37 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T13:33:04Z

Patch 5: "[v13,5/5] pwm: sifive: clarify inverted compare logic in comments"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T13:33:07Z

Patch 5: "[v13,5/5] pwm: sifive: clarify inverted compare logic in comments"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T13:33:09Z

Patch 5: "[v13,5/5] pwm: sifive: clarify inverted compare logic in comments"
module-param
Desc: Detect module_param changes
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T13:33:11Z

Patch 5: "[v13,5/5] pwm: sifive: clarify inverted compare logic in comments"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

linux-riscv-bot · 2025-04-23T13:33:12Z

Patch 5: "[v13,5/5] pwm: sifive: clarify inverted compare logic in comments"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

Linux RISC-V bot and others added 6 commits April 16, 2025 18:23

Adding CI files

6c2725a

linux-riscv-bot force-pushed the workflow__riscv__fixes branch 2 times, most recently from c8da138 to 4d9ad71 Compare April 30, 2025 11:41

linux-riscv-bot closed this May 1, 2025

linux-riscv-bot deleted the pw956104 branch May 1, 2025 01:08

Conversation

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025

Uh oh!

linux-riscv-bot commented Apr 23, 2025