Skip to content

[PW_SID:956315] riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO#334

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__for-nextfrom
pw956315
Closed

[PW_SID:956315] riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO#334
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__for-nextfrom
pw956315

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Apr 23, 2025

PR for series 956315 applied to workflow__riscv__for-next

Name: riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=956315
Version: 1

Linux RISC-V bot and others added 2 commits April 18, 2025 18:22
Adding CI files
a9d006d
@nathanchance
riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO
ab29850 
ld.lld defaults to '--no-undefined-version', which causes the compat
vDSO to break after wiring up the vDSO getrandom() call because the
linker script between the two vDSO implementations.

  ld.lld: error: version script assignment of 'LINUX_4.15' to symbol '__vdso_getrandom' failed: symbol not defined

Move the export of __vdso_getrandom() under the existing ifndef for the
compat vDSO so that it is only included for the 64-bit vDSO where it is
wired up.

Fixes: 8907952 ("RISC-V: vDSO: Wire up getrandom() vDSO implementation")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 84.09 seconds
Result: ERROR
Output:

Full log:
W: Support for running offline not available (unshare: unshare failed: Operation not permitted)
I: config: PASS in 0:00:08.798854
I: default: FAIL in 0:01:08.683642
I: kernel: SKIP in 0:00:00.000009
I: xipkernel: SKIP in 0:00:00.000004
I: modules: FAIL in 0:00:00.070283
I: dtbs: PASS in 0:00:01.442782
I: dtbs-legacy: SKIP in 0:00:00.004883
I: debugkernel: SKIP in 0:00:00.000005
I: headers: PASS in 0:00:01.101068
I: build output in /build/tmp.A769xyE4KA
tuxmake --download-all-korg-gcc-toolchains --target-arch=riscv --kconfig=rv32_defconfig --toolchain=llvm --wrapper=ccache --environment=KBUILD_BUILD_TIMESTAMP=@1621270510 --environment=KBUILD_BUILD_USER=tuxmake --environment=KBUILD_BUILD_HOST=tuxmake --environment=KCFLAGS=-ffile-prefix-map=/build/tmp.A769xyE4KA/build/= --runtime=null --image=docker.io/tuxmake/riscv_clang CROSS_COMPILE=riscv64-linux- config default kernel xipkernel modules dtbs dtbs-legacy debugkernel headers
make --silent --keep-going --jobs=48 O=/build/tmp.A769xyE4KA/build ARCH=riscv CROSS_COMPILE=riscv64-linux- LLVM=1 'CC=ccache clang' 'HOSTCC=ccache clang' rv32_defconfig
make --silent --keep-going --jobs=48 O=/build/tmp.A769xyE4KA/build ARCH=riscv CROSS_COMPILE=riscv64-linux- LLVM=1 'CC=ccache clang' 'HOSTCC=ccache clang'
ld.lld: error: version script assignment of 'LINUX_4.15' to symbol '__vdso_getrandom' failed: symbol not defined
llvm-nm: error: arch/riscv/kernel/vdso/vdso.so.dbg: No such file or directory
ld.lld: error: version script assignment of 'LINUX_4.15' to symbol '__vdso_getrandom' failed: symbol not defined
llvm-objcopy: error: 'arch/riscv/kernel/vdso/vdso.so.dbg': No such file or directory
make[6]: *** [/build/tmptysaxbhi/arch/riscv/kernel/vdso/Makefile:67: arch/riscv/kernel/vdso/vdso.so] Error 1
make[6]: Target 'arch/riscv/kernel/vdso/' not remade because of errors.
make[5]: *** [/build/tmptysaxbhi/scripts/Makefile.build:461: arch/riscv/kernel/vdso] Error 2
/build/tmptysaxbhi/arch/riscv/kernel/signal.c:340:28: error: use of undeclared identifier '__vdso_rt_sigreturn_offset'
  340 |         regs->ra = (unsigned long)VDSO_SYMBOL(
      |                                   ^
/build/tmptysaxbhi/arch/riscv/include/asm/vdso.h:23:42: note: expanded from macro 'VDSO_SYMBOL'
   23 |         (void __user *)((unsigned long)(base) + __vdso_##name##_offset)
      |                                                 ^
<scratch space>:272:1: note: expanded from here
  272 | __vdso_rt_sigreturn_offset
      | ^
1 error generated.
make[5]: *** [/build/tmptysaxbhi/scripts/Makefile.build:203: arch/riscv/kernel/signal.o] Error 1
make[5]: Target 'arch/riscv/kernel/' not remade because of errors.
make[4]: *** [/build/tmptysaxbhi/scripts/Makefile.build:461: arch/riscv/kernel] Error 2
make[4]: Target 'arch/riscv/' not remade because of errors.
make[3]: *** [/build/tmptysaxbhi/scripts/Makefile.build:461: arch/riscv] Error 2
make[3]: Target './' not remade because of errors.
make[2]: *** [/build/tmptysaxbhi/Makefile:2006: .] Error 2
make[2]: Target '__all' not remade because of errors.
make[1]: *** [/build/tmptysaxbhi/Makefile:248: __sub-make] Error 2
make[1]: Target '__all' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target '__all' not remade because of errors.
rm -rf /build/tmp.A769xyE4KA/build/modinstall
make --silent --keep-going --jobs=48 O=/build/tmp.A769xyE4KA/build INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=/build/tmp.A769xyE4KA/build/modinstall ARCH=riscv CROSS_COMPILE=riscv64-linux- LLVM=1 'CC=ccache clang' 'HOSTCC=ccache clang' modules_install
make[3]: *** No rule to make target 'modules.order', needed by '/build/tmp.A769xyE4KA/build/modinstall/lib/modules/6.15.0-rc1-00004-gab29850d6263/modules.order'.
make[3]: *** No rule to make target 'modules.builtin', needed by '/build/tmp.A769xyE4KA/build/modinstall/lib/modules/6.15.0-rc1-00004-gab29850d6263/modules.builtin'.
make[3]: *** No rule to make target 'modules.builtin.modinfo', needed by '/build/tmp.A769xyE4KA/build/modinstall/lib/modules/6.15.0-rc1-00004-gab29850d6263/modules.builtin.modinfo'.
make[3]: Target '__modinst' not remade because of errors.
make[2]: *** [/build/tmptysaxbhi/Makefile:1912: modules_install] Error 2
make[1]: *** [/build/tmptysaxbhi/Makefile:248: __sub-make] Error 2
make[1]: Target 'modules_install' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target 'modules_install' not remade because of errors.
make --silent --keep-going --jobs=48 O=/build/tmp.A769xyE4KA/build INSTALL_DTBS_PATH=/build/tmp.A769xyE4KA/build/dtbsinstall/dtbs ARCH=riscv CROSS_COMPILE=riscv64-linux- LLVM=1 'CC=ccache clang' 'HOSTCC=ccache clang' dtbs
rm -rf /build/tmp.A769xyE4KA/build/dtbsinstall
mkdir -p /build/tmp.A769xyE4KA/build/dtbsinstall/dtbs
make --silent --keep-going --jobs=48 O=/build/tmp.A769xyE4KA/build INSTALL_DTBS_PATH=/build/tmp.A769xyE4KA/build/dtbsinstall/dtbs ARCH=riscv CROSS_COMPILE=riscv64-linux- LLVM=1 'CC=ccache clang' 'HOSTCC=ccache clang' dtbs_install
tar --sort=name --owner=tuxmake:1000 --group=tuxmake:1000 --mtime=@1745434478 --clamp-mtime -caf /build/tmp.A769xyE4KA/build/dtbs.tar -C /build/tmp.A769xyE4KA/build/dtbsinstall dtbs
rm -rf /build/tmp.A769xyE4KA/build/install_hdr
make --silent --keep-going --jobs=48 O=/build/tmp.A769xyE4KA/build INSTALL_HDR_PATH=/build/tmp.A769xyE4KA/build/install_hdr/ ARCH=riscv CROSS_COMPILE=riscv64-linux- LLVM=1 'CC=ccache clang' 'HOSTCC=ccache clang' headers_install
tar --sort=name --owner=tuxmake:1000 --group=tuxmake:1000 --mtime=@1745434478 --clamp-mtime -caf /build/tmp.A769xyE4KA/build/headers.tar -C /build/tmp.A769xyE4KA/build/install_hdr .
warnings/errors:
ld.lld: error: version script assignment of 'LINUX_4.15' to symbol '__vdso_getrandom' failed: symbol not defined
llvm-nm: error: arch/riscv/kernel/vdso/vdso.so.dbg: No such file or directory
ld.lld: error: version script assignment of 'LINUX_4.15' to symbol '__vdso_getrandom' failed: symbol not defined
llvm-objcopy: error: 'arch/riscv/kernel/vdso/vdso.so.dbg': No such file or directory
/build/tmptysaxbhi/arch/riscv/kernel/signal.c:340:28: error: use of undeclared identifier '__vdso_rt_sigreturn_offset'

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 965.71 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1264.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.94 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.91 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.67 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 38.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO"
kdoc
Desc: Detects for kdoc errors
Duration: 0.86 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO"
module-param
Desc: Detect module_param changes
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "riscv: vdso.lds.S: Do not export __vdso_getrandom in compat vDSO"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__for-next branch from a9d006d to 2fa8e97 Compare April 30, 2025 11:41
@linux-riscv-bot linux-riscv-bot deleted the pw956315 branch May 1, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @nathanchance