Skip to content

[PW_SID:956340] [v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO#335

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__for-nextfrom
pw956340
Closed

[PW_SID:956340] [v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO#335
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__for-nextfrom
pw956340

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Apr 23, 2025

PR for series 956340 applied to workflow__riscv__for-next

Name: [v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=956340
Version: 2

Linux RISC-V bot and others added 2 commits April 18, 2025 18:22
Adding CI files
a9d006d
@nathanchance
riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-…
745deec 
…bit vDSO

ld.lld defaults to '--no-undefined-version', which causes the compat
vDSO for 64-bit builds and the regular vDSO for 32-bit builds to break
after wiring up the vDSO getrandom() call because __vdso_getrandom is
unconditionally exported, even though it is not always present.

  ld.lld: error: version script assignment of 'LINUX_4.15' to symbol '__vdso_getrandom' failed: symbol not defined

Move the export of __vdso_getrandom() under an ifdef to only include it
when CONFIG_VDSO_GETRANDOM is defined (to exclude 32-bit builds) and
COMPAT_VDSO is not defined (to exclude the 32-bit vDSO on 64-bit builds)
to resolve the error.

Fixes: 8907952 ("RISC-V: vDSO: Wire up getrandom() vDSO implementation")
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Closes: https://lore.kernel.org/CA+G9fYtN2ie+YtK3H9mrQ5QqrSCFGGjVbtJcfiYX0oHMVWMn9w@mail.gmail.com/
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "[v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 97.37 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "[v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 959.78 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "[v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1264.19 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "[v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.11 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "[v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.69 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "[v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.74 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "[v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 37.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "[v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "[v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO"
kdoc
Desc: Detects for kdoc errors
Duration: 0.82 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "[v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO"
module-param
Desc: Detect module_param changes
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "[v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 23, 2025

Patch 1: "[v2] riscv: vdso.lds.S: Do not export __vdso_getrandom when building a 32-bit vDSO"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__for-next branch from a9d006d to 2fa8e97 Compare April 30, 2025 11:41
@linux-riscv-bot linux-riscv-bot deleted the pw956340 branch May 1, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @nathanchance