Skip to content

[PW_SID:956798] riscv: crypto - Use SYM_FUNC_START for functions only called directly#342

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw956798
Closed

[PW_SID:956798] riscv: crypto - Use SYM_FUNC_START for functions only called directly#342
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw956798

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Apr 25, 2025

PR for series 956798 applied to workflow__riscv__fixes

Name: riscv: crypto - Use SYM_FUNC_START for functions only called directly
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=956798
Version: 1

Linux RISC-V bot and others added 2 commits April 24, 2025 20:46
Adding CI files
c8da138
@nathanchance
riscv: crypto - Use SYM_FUNC_START for functions only called directly
a0ce88f 
After some recent changes to the RISC-V crypto code that turned some
indirect function calls into direct ones, builds with CONFIG_CFI_CLANG
fail with:

  ld.lld: error: undefined symbol: __kcfi_typeid_sm3_transform_zvksh_zvkb
  >>> referenced by arch/riscv/crypto/sm3-riscv64-zvksh-zvkb.o:(.text+0x2) in archive vmlinux.a

  ld.lld: error: undefined symbol: __kcfi_typeid_sha512_transform_zvknhb_zvkb
  >>> referenced by arch/riscv/crypto/sha512-riscv64-zvknhb-zvkb.o:(.text+0x2) in archive vmlinux.a

  ld.lld: error: undefined symbol: __kcfi_typeid_sha256_transform_zvknha_or_zvknhb_zvkb
  >>> referenced by arch/riscv/crypto/sha256-riscv64-zvknha_or_zvknhb-zvkb.o:(.text+0x2) in archive vmlinux.a

As these functions are no longer indirectly called (i.e., have their
address taken), the compiler will not emit __kcfi_typeid symbols for
them but SYM_TYPED_FUNC_START expects these to exist at link time.

Switch the definitions of these functions to use SYM_FUNC_START, as they
no longer need kCFI type information since they are only called
directly.

Fixes: 1523eae ("crypto: riscv/sm3 - Use API partial block handling")
Fixes: 561aab1 ("crypto: riscv/sha512 - Use API partial block handling")
Fixes: e6c5597 ("crypto: riscv/sha256 - Use API partial block handling")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2025

Patch 1: "riscv: crypto - Use SYM_FUNC_START for functions only called directly"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.97 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2025

Patch 1: "riscv: crypto - Use SYM_FUNC_START for functions only called directly"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 885.05 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2025

Patch 1: "riscv: crypto - Use SYM_FUNC_START for functions only called directly"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1176.00 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2025

Patch 1: "riscv: crypto - Use SYM_FUNC_START for functions only called directly"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.57 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2025

Patch 1: "riscv: crypto - Use SYM_FUNC_START for functions only called directly"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.20 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2025

Patch 1: "riscv: crypto - Use SYM_FUNC_START for functions only called directly"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.80 seconds
Result: WARNING
Output:

WARNING: Unknown commit id '1523eaed0ac5', maybe rebased or not pulled?
#28: 
Fixes: 1523eaed0ac5 ("crypto: riscv/sm3 - Use API partial block handling")

WARNING: Unknown commit id '561aab1104d8', maybe rebased or not pulled?
#29: 
Fixes: 561aab1104d8 ("crypto: riscv/sha512 - Use API partial block handling")

WARNING: Unknown commit id 'e6c5597badf2', maybe rebased or not pulled?
#30: 
Fixes: e6c5597badf2 ("crypto: riscv/sha256 - Use API partial block handling")

total: 0 errors, 3 warnings, 0 checks, 48 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit a0ce88fe4b95 ("riscv: crypto - Use SYM_FUNC_START for functions only called directly") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 3 warnings, 0 checks, 48 lines checked
WARNING: Unknown commit id '1523eaed0ac5', maybe rebased or not pulled?
WARNING: Unknown commit id '561aab1104d8', maybe rebased or not pulled?
WARNING: Unknown commit id 'e6c5597badf2', maybe rebased or not pulled?

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2025

Patch 1: "riscv: crypto - Use SYM_FUNC_START for functions only called directly"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 38.48 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2025

Patch 1: "riscv: crypto - Use SYM_FUNC_START for functions only called directly"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2025

Patch 1: "riscv: crypto - Use SYM_FUNC_START for functions only called directly"
kdoc
Desc: Detects for kdoc errors
Duration: 1.06 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2025

Patch 1: "riscv: crypto - Use SYM_FUNC_START for functions only called directly"
module-param
Desc: Detect module_param changes
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2025

Patch 1: "riscv: crypto - Use SYM_FUNC_START for functions only called directly"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.98 seconds
Result: ERROR
Output:

Commit: a0ce88fe4b95 ("riscv: crypto - Use SYM_FUNC_START for functions only called directly")
	Fixes tag: Fixes: 1523eaed0ac5 ("crypto: riscv/sm3 - Use API partial block handling")
	Has these problem(s):
		- Target SHA1 does not exist
	Fixes tag: Fixes: 561aab1104d8 ("crypto: riscv/sha512 - Use API partial block handling")
	Has these problem(s):
		- Target SHA1 does not exist
	Fixes tag: Fixes: e6c5597badf2 ("crypto: riscv/sha256 - Use API partial block handling")
	Has these problem(s):
		- Target SHA1 does not exist
Problems with Fixes tag: 3

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2025

Patch 1: "riscv: crypto - Use SYM_FUNC_START for functions only called directly"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__fixes branch from c8da138 to 4d9ad71 Compare April 30, 2025 11:41
@linux-riscv-bot linux-riscv-bot deleted the pw956798 branch May 3, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @nathanchance