Skip to content

[PW_SID:957500] Add support for Allwinner PWM on D1/T113s/R329 SoCs#346

Closed
linux-riscv-bot wants to merge 4 commits into
workflow__riscv__fixesfrom
pw957500
Closed

[PW_SID:957500] Add support for Allwinner PWM on D1/T113s/R329 SoCs#346
linux-riscv-bot wants to merge 4 commits into
workflow__riscv__fixesfrom
pw957500

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Apr 27, 2025

PR for series 957500 applied to workflow__riscv__fixes

Name: Add support for Allwinner PWM on D1/T113s/R329 SoCs
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=957500
Version: 12

Linux RISC-V bot and others added 4 commits April 24, 2025 20:46
Adding CI files
c8da138
@privatesub2
dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM contr…
92c05db 
…oller

Allwinner's D1, T113-S3 and R329 SoCs have a new pwm
controller witch is different from the previous pwm-sun4i.

The D1 and T113 are identical in terms of peripherals,
they differ only in the architecture of the CPU core, and
even share the majority of their DT. Because of that,
using the same compatible makes sense.
The R329 is a different SoC though, and should have
a different compatible string added, especially as there
is a difference in the number of channels.

D1 and T113s SoCs have one PWM controller with 8 channels.
R329 SoC has two PWM controllers in both power domains, one of
them has 9 channels (CPUX one) and the other has 6 (CPUS one).

Add a device tree binding for them.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Aleksandr Shubin <privatesub2@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@privatesub2
pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support
73126d6 
Allwinner's D1, T113-S3 and R329 SoCs have a quite different PWM
controllers with ones supported by pwm-sun4i driver.

This patch adds a PWM controller driver for Allwinner's D1,
T113-S3 and R329 SoCs. The main difference between these SoCs
is the number of channels defined by the DT property.

Co-developed-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
Signed-off-by: Brandon Cheo Fusi <fusibrandon13@gmail.com>
Signed-off-by: Aleksandr Shubin <privatesub2@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@privatesub2
riscv: dts: allwinner: d1: Add pwm node
8c71d5e 
D1 and T113s contain a pwm controller with 8 channels.
This controller is supported by the sun20i-pwm driver.

Add a device tree node for it.

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Aleksandr Shubin <privatesub2@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 1: "[v12,1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 101.79 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 1: "[v12,1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 858.68 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 1: "[v12,1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1133.55 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 1: "[v12,1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.55 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 1: "[v12,1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.08 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 1: "[v12,1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.79 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 84 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 92c05db57780 ("dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 84 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 1: "[v12,1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 38.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 1: "[v12,1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 1: "[v12,1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller"
kdoc
Desc: Detects for kdoc errors
Duration: 1.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 1: "[v12,1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller"
module-param
Desc: Detect module_param changes
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 1: "[v12,1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 1: "[v12,1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 2: "[v12,2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 100.73 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 2: "[v12,2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 890.44 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 2: "[v12,2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1177.16 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 2: "[v12,2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.89 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 2: "[v12,2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.80 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 2: "[v12,2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.39 seconds
Result: WARNING
Output:

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#32: FILE: drivers/pwm/Kconfig:665:
+config PWM_SUN20I
+	tristate "Allwinner D1/T113s/R329 PWM support"
+	depends on ARCH_SUNXI || COMPILE_TEST
+	depends on COMMON_CLK
+	help
+	  Generic PWM framework driver for Allwinner D1/T113s/R329 SoCs.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called pwm-sun20i.
+

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#58: 
new file mode 100644

total: 0 errors, 2 warnings, 0 checks, 402 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 73126d619f0c ("pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 0 checks, 402 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 2: "[v12,2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 37.60 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 2: "[v12,2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 2: "[v12,2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 2: "[v12,2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support"
module-param
Desc: Detect module_param changes
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 2: "[v12,2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 2: "[v12,2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 3: "[v12,3/3] riscv: dts: allwinner: d1: Add pwm node"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 100.76 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 3: "[v12,3/3] riscv: dts: allwinner: d1: Add pwm node"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 898.77 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 3: "[v12,3/3] riscv: dts: allwinner: d1: Add pwm node"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1184.11 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 3: "[v12,3/3] riscv: dts: allwinner: d1: Add pwm node"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.68 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 3: "[v12,3/3] riscv: dts: allwinner: d1: Add pwm node"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.75 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 3: "[v12,3/3] riscv: dts: allwinner: d1: Add pwm node"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.61 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 3: "[v12,3/3] riscv: dts: allwinner: d1: Add pwm node"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 38.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 3: "[v12,3/3] riscv: dts: allwinner: d1: Add pwm node"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 3: "[v12,3/3] riscv: dts: allwinner: d1: Add pwm node"
kdoc
Desc: Detects for kdoc errors
Duration: 0.84 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 3: "[v12,3/3] riscv: dts: allwinner: d1: Add pwm node"
module-param
Desc: Detect module_param changes
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 3: "[v12,3/3] riscv: dts: allwinner: d1: Add pwm node"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 27, 2025

Patch 3: "[v12,3/3] riscv: dts: allwinner: d1: Add pwm node"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__fixes branch from c8da138 to 4d9ad71 Compare April 30, 2025 11:41
@linux-riscv-bot linux-riscv-bot deleted the pw957500 branch May 5, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @privatesub2