[PW_SID:958418] RISC-V KVM selftests improvements by linux-riscv-bot · Pull Request #358 · linux-riscv/linux

linux-riscv-bot · 2025-04-30T08:52:10Z

PR for series 958418 applied to workflow__riscv__fixes

Name: RISC-V KVM selftests improvements
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=958418
Version: 3

The current exeception register structure in selftests are missing few registers (e.g stval). Instead of adding it manually, change the ex_regs to align with pt_regs to make it future proof. Suggested-by: Andrew Jones <ajones@ventanamicro.com> Reviewed-by: Andrew Jones <ajones@ventanamicro.com> Signed-off-by: Atish Patra <atishp@rivosinc.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Currently, the sbi_pmu_test continues if the exception type is illegal instruction because access to hpmcounter will generate that. However illegal instruction exception may occur due to the other reasons which should result in test assertion. Use the stval to decode the exact type of instructions and which csrs are being accessed if it is csr access instructions. Assert in all cases except if it is a csr access instructions that access valid PMU related registers. Take this opportunity to remove the CSR_CYCLEH reference as the test is compiled for RV64 only. Reviewed-by: Anup Patel <anup@brainfault.org> Reviewed-by: Andrew Jones <ajones@ventanamicro.com> Signed-off-by: Atish Patra <atishp@rivosinc.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Add vector related tests with the ISA extension standard template. However, the vector registers are bit tricky as the register length is variable based on vlenb value of the system. That's why the macros are defined with a default and overidden with actual value at runtime. Reviewed-by: Anup Patel <anup@brainfault.org> Reviewed-by: Andrew Jones <ajones@ventanamicro.com> Signed-off-by: Atish Patra <atishp@rivosinc.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2025-04-30T08:59:08Z

Patch 1: "[v3,1/3] KVM: riscv: selftests: Align the trap information wiht pt_regs"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 112.60 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:14:07Z

Patch 1: "[v3,1/3] KVM: riscv: selftests: Align the trap information wiht pt_regs"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 897.88 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:33:23Z

Patch 1: "[v3,1/3] KVM: riscv: selftests: Align the trap information wiht pt_regs"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1154.90 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:33:47Z

Patch 1: "[v3,1/3] KVM: riscv: selftests: Align the trap information wiht pt_regs"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.71 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:34:11Z

Patch 1: "[v3,1/3] KVM: riscv: selftests: Align the trap information wiht pt_regs"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.93 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:34:14Z

Patch 1: "[v3,1/3] KVM: riscv: selftests: Align the trap information wiht pt_regs"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.70 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:35:24Z

Patch 1: "[v3,1/3] KVM: riscv: selftests: Align the trap information wiht pt_regs"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 68.42 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:35:26Z

Patch 1: "[v3,1/3] KVM: riscv: selftests: Align the trap information wiht pt_regs"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:35:28Z

Patch 1: "[v3,1/3] KVM: riscv: selftests: Align the trap information wiht pt_regs"
kdoc
Desc: Detects for kdoc errors
Duration: 0.90 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:35:30Z

Patch 1: "[v3,1/3] KVM: riscv: selftests: Align the trap information wiht pt_regs"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:35:32Z

Patch 1: "[v3,1/3] KVM: riscv: selftests: Align the trap information wiht pt_regs"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:35:34Z

Patch 1: "[v3,1/3] KVM: riscv: selftests: Align the trap information wiht pt_regs"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:37:36Z

Patch 2: "[v3,2/3] KVM: riscv: selftests: Decode stval to identify exact exception type"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 106.17 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T09:52:32Z

Patch 2: "[v3,2/3] KVM: riscv: selftests: Decode stval to identify exact exception type"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 894.24 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:11:45Z

Patch 2: "[v3,2/3] KVM: riscv: selftests: Decode stval to identify exact exception type"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1151.93 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:12:07Z

Patch 2: "[v3,2/3] KVM: riscv: selftests: Decode stval to identify exact exception type"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.68 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:12:31Z

Patch 2: "[v3,2/3] KVM: riscv: selftests: Decode stval to identify exact exception type"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.01 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:12:33Z

Patch 2: "[v3,2/3] KVM: riscv: selftests: Decode stval to identify exact exception type"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.94 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:13:43Z

Patch 2: "[v3,2/3] KVM: riscv: selftests: Decode stval to identify exact exception type"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 68.44 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:13:45Z

Patch 2: "[v3,2/3] KVM: riscv: selftests: Decode stval to identify exact exception type"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:13:47Z

Patch 2: "[v3,2/3] KVM: riscv: selftests: Decode stval to identify exact exception type"
kdoc
Desc: Detects for kdoc errors
Duration: 0.85 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:13:49Z

Patch 2: "[v3,2/3] KVM: riscv: selftests: Decode stval to identify exact exception type"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:13:50Z

Patch 2: "[v3,2/3] KVM: riscv: selftests: Decode stval to identify exact exception type"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:13:52Z

Patch 2: "[v3,2/3] KVM: riscv: selftests: Decode stval to identify exact exception type"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:15:55Z

Patch 3: "[v3,3/3] KVM: riscv: selftests: Add vector extension tests"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 106.68 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:30:52Z

Patch 3: "[v3,3/3] KVM: riscv: selftests: Add vector extension tests"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 895.32 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:50:09Z

Patch 3: "[v3,3/3] KVM: riscv: selftests: Add vector extension tests"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1155.78 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:50:31Z

Patch 3: "[v3,3/3] KVM: riscv: selftests: Add vector extension tests"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.64 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:50:54Z

Patch 3: "[v3,3/3] KVM: riscv: selftests: Add vector extension tests"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.82 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:50:58Z

Patch 3: "[v3,3/3] KVM: riscv: selftests: Add vector extension tests"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.73 seconds
Result: WARNING
Output:

WARNING: line length of 105 exceeds 100 columns
#163: FILE: tools/testing/selftests/kvm/riscv/get-reg-list.c:964:
+	KVM_REG_RISCV | KVM_REG_SIZE_ULONG | KVM_REG_RISCV_VECTOR | KVM_REG_RISCV_VECTOR_CSR_REG(vstart),

WARNING: line length of 101 exceeds 100 columns
#164: FILE: tools/testing/selftests/kvm/riscv/get-reg-list.c:965:
+	KVM_REG_RISCV | KVM_REG_SIZE_ULONG | KVM_REG_RISCV_VECTOR | KVM_REG_RISCV_VECTOR_CSR_REG(vl),

WARNING: line length of 104 exceeds 100 columns
#165: FILE: tools/testing/selftests/kvm/riscv/get-reg-list.c:966:
+	KVM_REG_RISCV | KVM_REG_SIZE_ULONG | KVM_REG_RISCV_VECTOR | KVM_REG_RISCV_VECTOR_CSR_REG(vtype),

WARNING: line length of 103 exceeds 100 columns
#166: FILE: tools/testing/selftests/kvm/riscv/get-reg-list.c:967:
+	KVM_REG_RISCV | KVM_REG_SIZE_ULONG | KVM_REG_RISCV_VECTOR | KVM_REG_RISCV_VECTOR_CSR_REG(vcsr),

WARNING: line length of 104 exceeds 100 columns
#167: FILE: tools/testing/selftests/kvm/riscv/get-reg-list.c:968:
+	KVM_REG_RISCV | KVM_REG_SIZE_ULONG | KVM_REG_RISCV_VECTOR | KVM_REG_RISCV_VECTOR_CSR_REG(vlenb),

WARNING: line length of 116 exceeds 100 columns
#200: FILE: tools/testing/selftests/kvm/riscv/get-reg-list.c:1001:
+	KVM_REG_RISCV | KVM_REG_SIZE_ULONG | KVM_REG_RISCV_ISA_EXT | KVM_REG_RISCV_ISA_SINGLE | KVM_RISCV_ISA_EXT_V,

WARNING: line length of 102 exceeds 100 columns
#211: FILE: tools/testing/selftests/kvm/riscv/get-reg-list.c:1029:
+	{"v", .feature = KVM_RISCV_ISA_EXT_V, .regs = vector_regs, .regs_n = ARRAY_SIZE(vector_regs),}

total: 0 errors, 7 warnings, 0 checks, 198 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit df488cf29144 ("KVM: riscv: selftests: Add vector extension tests") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 7 warnings, 0 checks, 198 lines checked
WARNING: line length of 101 exceeds 100 columns
WARNING: line length of 102 exceeds 100 columns
WARNING: line length of 103 exceeds 100 columns
WARNING: line length of 104 exceeds 100 columns
WARNING: line length of 105 exceeds 100 columns
WARNING: line length of 116 exceeds 100 columns

linux-riscv-bot · 2025-04-30T10:52:07Z

Patch 3: "[v3,3/3] KVM: riscv: selftests: Add vector extension tests"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 67.26 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:52:08Z

Patch 3: "[v3,3/3] KVM: riscv: selftests: Add vector extension tests"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:52:11Z

Patch 3: "[v3,3/3] KVM: riscv: selftests: Add vector extension tests"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:52:12Z

Patch 3: "[v3,3/3] KVM: riscv: selftests: Add vector extension tests"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:52:14Z

Patch 3: "[v3,3/3] KVM: riscv: selftests: Add vector extension tests"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2025-04-30T10:52:16Z

Patch 3: "[v3,3/3] KVM: riscv: selftests: Add vector extension tests"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.56 seconds
Result: PASS

Linux RISC-V bot and others added 4 commits April 24, 2025 20:46

Adding CI files

c8da138

linux-riscv-bot force-pushed the workflow__riscv__fixes branch 2 times, most recently from 4d9ad71 to 625be03 Compare May 6, 2025 09:20

linux-riscv-bot closed this May 7, 2025

linux-riscv-bot deleted the pw958418 branch May 7, 2025 14:20

Conversation

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

linux-riscv-bot commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone