[PW_SID:959792] Enable hstateen bits lazily for the KVM RISC-V Guests by linux-riscv-bot · Pull Request #377 · linux-riscv/linux

linux-riscv-bot · 2025-05-05T22:19:24Z

PR for series 959792 applied to workflow__riscv__fixes

Name: Enable hstateen bits lazily for the KVM RISC-V Guests
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=959792
Version: 1

Currently, we enable the smstateen bit at vcpu configure time by only checking the presence of required ISA extensions. These bits are not required to be enabled if the guest never uses the corresponding architectural state. Enable the smstaeen bits at runtime lazily upon first access. Signed-off-by: Atish Patra <atishp@rivosinc.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Hstateen has different bits that can be enabled lazily at runtime. Most of them have similar functionality where the hstateen bit must be enabled if not enabled already. The correpsonding config bit in vcpu must be enabled as well so that hstateen CSR is updated correctly during the next vcpu load. In absesnce of Smstateen extension, exit to the userspace in the trap because CSR access control exists architecturally only if Smstateen extension is available. Add a common helper function to achieve the above said objective. Signed-off-by: Atish Patra <atishp@rivosinc.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Smstateen extension controls the SISELECT and SIPH/SIEH register through hstateen.AIA bit (58). Add lazy enabling support for those bits. Signed-off-by: Atish Patra <atishp@rivosinc.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

SENVCFG and SSTATEEN CSRs are controlled by HSENVCFG(62) and SSTATEEN0(63) bits in hstateen. Enable them lazily at runtime instead of bootime. Signed-off-by: Atish Patra <atishp@rivosinc.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

All the existing hstateen bits can be enabled at runtime upon first access now. Remove the default enabling at bootime now. Signed-off-by: Atish Patra <atishp@rivosinc.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2025-05-05T22:24:39Z

Patch 1: "[1/5] RISC-V: KVM: Lazy enable hstateen IMSIC & ISEL bit"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 106.02 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T22:41:05Z

Patch 1: "[1/5] RISC-V: KVM: Lazy enable hstateen IMSIC & ISEL bit"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 984.74 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:02:13Z

Patch 1: "[1/5] RISC-V: KVM: Lazy enable hstateen IMSIC & ISEL bit"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1266.62 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:02:34Z

Patch 1: "[1/5] RISC-V: KVM: Lazy enable hstateen IMSIC & ISEL bit"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.17 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:02:57Z

Patch 1: "[1/5] RISC-V: KVM: Lazy enable hstateen IMSIC & ISEL bit"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.11 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:03:01Z

Patch 1: "[1/5] RISC-V: KVM: Lazy enable hstateen IMSIC & ISEL bit"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.43 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:04:08Z

Patch 1: "[1/5] RISC-V: KVM: Lazy enable hstateen IMSIC & ISEL bit"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 66.07 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:04:10Z

Patch 1: "[1/5] RISC-V: KVM: Lazy enable hstateen IMSIC & ISEL bit"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:04:13Z

Patch 1: "[1/5] RISC-V: KVM: Lazy enable hstateen IMSIC & ISEL bit"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:04:14Z

Patch 1: "[1/5] RISC-V: KVM: Lazy enable hstateen IMSIC & ISEL bit"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:04:17Z

Patch 1: "[1/5] RISC-V: KVM: Lazy enable hstateen IMSIC & ISEL bit"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.73 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:04:18Z

Patch 1: "[1/5] RISC-V: KVM: Lazy enable hstateen IMSIC & ISEL bit"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:06:19Z

Patch 2: "[2/5] RISC-V: KVM: Add a hstateen lazy enabler helper function"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.73 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:22:44Z

Patch 2: "[2/5] RISC-V: KVM: Add a hstateen lazy enabler helper function"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 983.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:43:54Z

Patch 2: "[2/5] RISC-V: KVM: Add a hstateen lazy enabler helper function"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1268.61 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:44:15Z

Patch 2: "[2/5] RISC-V: KVM: Add a hstateen lazy enabler helper function"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.30 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:44:38Z

Patch 2: "[2/5] RISC-V: KVM: Add a hstateen lazy enabler helper function"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.52 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:44:41Z

Patch 2: "[2/5] RISC-V: KVM: Add a hstateen lazy enabler helper function"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.91 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:45:49Z

Patch 2: "[2/5] RISC-V: KVM: Add a hstateen lazy enabler helper function"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 66.82 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:45:50Z

Patch 2: "[2/5] RISC-V: KVM: Add a hstateen lazy enabler helper function"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:45:53Z

Patch 2: "[2/5] RISC-V: KVM: Add a hstateen lazy enabler helper function"
kdoc
Desc: Detects for kdoc errors
Duration: 0.82 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:45:54Z

Patch 2: "[2/5] RISC-V: KVM: Add a hstateen lazy enabler helper function"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:45:56Z

Patch 2: "[2/5] RISC-V: KVM: Add a hstateen lazy enabler helper function"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-05T23:45:58Z

Patch 2: "[2/5] RISC-V: KVM: Add a hstateen lazy enabler helper function"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T00:27:33Z

Patch 3: "[3/5] RISC-V: KVM: Support lazy enabling of siselect and aia bits"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T00:27:35Z

Patch 3: "[3/5] RISC-V: KVM: Support lazy enabling of siselect and aia bits"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T00:27:36Z

Patch 3: "[3/5] RISC-V: KVM: Support lazy enabling of siselect and aia bits"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T00:29:37Z

Patch 4: "[4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 105.21 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T00:44:45Z

Patch 4: "[4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 907.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:04:20Z

Patch 4: "[4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1173.36 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:04:42Z

Patch 4: "[4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.27 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:05:05Z

Patch 4: "[4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.24 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:05:07Z

Patch 4: "[4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.53 seconds
Result: ERROR
Output:

ERROR: Macros with complex values should be enclosed in parentheses
#47: FILE: arch/riscv/kvm/vcpu_insn.c:282:
+#define KVM_RISCV_VCPU_STATEEN_CSR_FUNCS \
+{ .base = CSR_SENVCFG,    .count = 1, .func = kvm_riscv_vcpu_hstateen_enable_senvcfg }, \
+{ .base = CSR_SSTATEEN0,  .count = 1, .func = kvm_riscv_vcpu_hstateen_enable_stateen },\
+

total: 1 errors, 0 warnings, 0 checks, 37 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 2cafd8467da8 ("RISC-V: KVM: Enable envcfg and sstateen bits lazily") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: Macros with complex values should be enclosed in parentheses

linux-riscv-bot · 2025-05-06T01:06:15Z

Patch 4: "[4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 66.57 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:06:17Z

Patch 4: "[4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:06:20Z

Patch 4: "[4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily"
kdoc
Desc: Detects for kdoc errors
Duration: 1.43 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:06:22Z

Patch 4: "[4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily"
module-param
Desc: Detect module_param changes
Duration: 0.66 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:06:24Z

Patch 4: "[4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:06:25Z

Patch 4: "[4/5] RISC-V: KVM: Enable envcfg and sstateen bits lazily"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:08:25Z

Patch 5: "[5/5] RISC-V: KVM: Remove the boot time enabling of hstateen bits"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 105.21 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:23:32Z

Patch 5: "[5/5] RISC-V: KVM: Remove the boot time enabling of hstateen bits"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 905.39 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:43:07Z

Patch 5: "[5/5] RISC-V: KVM: Remove the boot time enabling of hstateen bits"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1173.54 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:43:29Z

Patch 5: "[5/5] RISC-V: KVM: Remove the boot time enabling of hstateen bits"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.38 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:43:52Z

Patch 5: "[5/5] RISC-V: KVM: Remove the boot time enabling of hstateen bits"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.39 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:43:54Z

Patch 5: "[5/5] RISC-V: KVM: Remove the boot time enabling of hstateen bits"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.65 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:45:03Z

Patch 5: "[5/5] RISC-V: KVM: Remove the boot time enabling of hstateen bits"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 67.25 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:45:04Z

Patch 5: "[5/5] RISC-V: KVM: Remove the boot time enabling of hstateen bits"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:45:07Z

Patch 5: "[5/5] RISC-V: KVM: Remove the boot time enabling of hstateen bits"
kdoc
Desc: Detects for kdoc errors
Duration: 0.86 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:45:09Z

Patch 5: "[5/5] RISC-V: KVM: Remove the boot time enabling of hstateen bits"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:45:10Z

Patch 5: "[5/5] RISC-V: KVM: Remove the boot time enabling of hstateen bits"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-06T01:45:12Z

Patch 5: "[5/5] RISC-V: KVM: Remove the boot time enabling of hstateen bits"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

Linux RISC-V bot and others added 6 commits April 30, 2025 11:41

Adding CI files

4d9ad71

linux-riscv-bot force-pushed the workflow__riscv__fixes branch from 4d9ad71 to 625be03 Compare May 6, 2025 09:20

linux-riscv-bot closed this May 7, 2025

linux-riscv-bot deleted the pw959792 branch May 7, 2025 14:19

Conversation

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 5, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025

Uh oh!

linux-riscv-bot commented May 6, 2025