[PW_SID:960482] reset: canaan: add Kendryte K230 reset support by linux-riscv-bot · Pull Request #385 · linux-riscv/linux

linux-riscv-bot · 2025-05-07T13:54:55Z

PR for series 960482 applied to workflow__riscv__fixes

Name: reset: canaan: add Kendryte K230 reset support
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=960482
Version: 3

Introduces a reset controller driver for the Kendryte K230 SoC, resposible for managing the reset functionality of the CPUs and various sub-modules. Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Chen Wang <unicorn_wang@outlook.com> Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Add support for the resets on Canaan Kendryte K230 SoC. The driver support CPU0, CPU1, L2 cache flush, hardware auto clear and software clear resets. Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2025-05-07T14:00:14Z

Patch 1: "[v3,1/2] dt-bindings: reset: add support for canaan,k230-rst"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 107.04 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T14:15:53Z

Patch 1: "[v3,1/2] dt-bindings: reset: add support for canaan,k230-rst"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 937.03 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T14:36:05Z

Patch 1: "[v3,1/2] dt-bindings: reset: add support for canaan,k230-rst"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1210.24 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T14:36:27Z

Patch 1: "[v3,1/2] dt-bindings: reset: add support for canaan,k230-rst"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.81 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T14:36:51Z

Patch 1: "[v3,1/2] dt-bindings: reset: add support for canaan,k230-rst"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.81 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T14:36:55Z

Patch 1: "[v3,1/2] dt-bindings: reset: add support for canaan,k230-rst"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.20 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 129 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit fec6e6617eb7 ("dt-bindings: reset: add support for canaan,k230-rst") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 129 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

linux-riscv-bot · 2025-05-07T14:38:04Z

Patch 1: "[v3,1/2] dt-bindings: reset: add support for canaan,k230-rst"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 67.13 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T14:38:05Z

Patch 1: "[v3,1/2] dt-bindings: reset: add support for canaan,k230-rst"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T14:38:09Z

Patch 1: "[v3,1/2] dt-bindings: reset: add support for canaan,k230-rst"
kdoc
Desc: Detects for kdoc errors
Duration: 0.83 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T14:38:11Z

Patch 1: "[v3,1/2] dt-bindings: reset: add support for canaan,k230-rst"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T14:38:13Z

Patch 1: "[v3,1/2] dt-bindings: reset: add support for canaan,k230-rst"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.67 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T14:38:15Z

Patch 1: "[v3,1/2] dt-bindings: reset: add support for canaan,k230-rst"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T14:40:17Z

Patch 2: "[v3,2/2] reset: canaan: add reset driver for Kendryte K230"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 106.81 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T14:55:44Z

Patch 2: "[v3,2/2] reset: canaan: add reset driver for Kendryte K230"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 925.21 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T15:15:41Z

Patch 2: "[v3,2/2] reset: canaan: add reset driver for Kendryte K230"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1195.30 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T15:16:03Z

Patch 2: "[v3,2/2] reset: canaan: add reset driver for Kendryte K230"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.64 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T15:16:28Z

Patch 2: "[v3,2/2] reset: canaan: add reset driver for Kendryte K230"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.96 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T15:16:32Z

Patch 2: "[v3,2/2] reset: canaan: add reset driver for Kendryte K230"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.43 seconds
Result: WARNING
Output:

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#27: FILE: drivers/reset/Kconfig:143:
+config RESET_K230
+	tristate "Reset controller driver for Canaan Kendryte K230 SoC"
+	depends on ARCH_CANAAN || COMPILE_TEST
+	depends on OF
+	help
+	  Support for the Canaan Kendryte K230 RISC-V SoC reset controller.
+	  Say Y if you want to control reset signals provided by this
+	  controller.
+

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

CHECK: usleep_range is preferred over udelay; see function description of usleep_range() and udelay().
#290: FILE: drivers/reset/reset-k230.c:234:
+	udelay(10);

CHECK: usleep_range is preferred over udelay; see function description of usleep_range() and udelay().
#321: FILE: drivers/reset/reset-k230.c:265:
+	udelay(10);

CHECK: usleep_range is preferred over udelay; see function description of usleep_range() and udelay().
#344: FILE: drivers/reset/reset-k230.c:288:
+		udelay(10);

CHECK: Alignment should match open parenthesis
#352: FILE: drivers/reset/reset-k230.c:296:
+		ret = readl_poll_timeout(rstc->base + rmap->offset, reg,
+					!(reg & rmap->reset), 10, 1000);

total: 0 errors, 2 warnings, 4 checks, 393 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit b14692ea36f7 ("reset: canaan: add reset driver for Kendryte K230") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 4 checks, 393 lines checked
CHECK: Alignment should match open parenthesis
CHECK: usleep_range is preferred over udelay; see function description of usleep_range() and udelay().
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines

linux-riscv-bot · 2025-05-07T15:17:42Z

Patch 2: "[v3,2/2] reset: canaan: add reset driver for Kendryte K230"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 67.76 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T15:17:44Z

Patch 2: "[v3,2/2] reset: canaan: add reset driver for Kendryte K230"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T15:17:46Z

Patch 2: "[v3,2/2] reset: canaan: add reset driver for Kendryte K230"
kdoc
Desc: Detects for kdoc errors
Duration: 0.92 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T15:17:48Z

Patch 2: "[v3,2/2] reset: canaan: add reset driver for Kendryte K230"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T15:17:50Z

Patch 2: "[v3,2/2] reset: canaan: add reset driver for Kendryte K230"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-07T15:17:52Z

Patch 2: "[v3,2/2] reset: canaan: add reset driver for Kendryte K230"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

pigmoral added 2 commits May 7, 2025 13:54

linux-riscv-bot closed this May 7, 2025

linux-riscv-bot deleted the pw960482 branch May 7, 2025 14:19

Conversation

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

linux-riscv-bot commented May 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants