[PW_SID:963855] Add USB2.0 PHY and USB3.0 PHY support for SpacemiT K1 by linux-riscv-bot · Pull Request #423 · linux-riscv/linux

linux-riscv-bot · 2025-05-17T14:45:24Z

PR for series 963855 applied to workflow__riscv__fixes

Name: Add USB2.0 PHY and USB3.0 PHY support for SpacemiT K1
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=963855
Version: 3

Add support for USB2 PHY found on SpacemiT K1 SoC. Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Signed-off-by: Ze Huang <huangze@whut.edu.cn> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Introduce support for SpacemiT K1 PCIe/USB3 combo PHY controller. PCIe portA and USB3 controller share this phy, only one of them can work at any given application scenario. Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Co-developed-by: Junzhong Pan <junzhong.pan@spacemit.com> Signed-off-by: Junzhong Pan <junzhong.pan@spacemit.com> Signed-off-by: Ze Huang <huangze@whut.edu.cn> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

The SpacemiT K1 SoC includes three USB ports: - One USB2.0 OTG port - One USB2.0 host-only port - One USB3.0 port with an integrated USB2.0 DRD interface Each of these ports is connected to a USB2.0 PHY responsible for USB2 transmission. This commit adds support for the SpacemiT K1 USB2.0 PHY, which is compliant with the USB 2.0 specification and supports both 8-bit 60MHz and 16-bit 30MHz parallel interfaces. Signed-off-by: Ze Huang <huangze@whut.edu.cn> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Add support for USB 3.0 mode on the K1 PCIe/USB3 combo PHY which implements PIPE3(125MHz) interface for USB3.0. Currently, only USB mode is supported; PCIe support is not included in this change. Signed-off-by: Ze Huang <huangze@whut.edu.cn> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2025-05-17T14:50:36Z

Patch 1: "[v3,1/4] dt-bindings: phy: spacemit: add K1 USB2 PHY"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 105.30 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T15:05:18Z

Patch 1: "[v3,1/4] dt-bindings: phy: spacemit: add K1 USB2 PHY"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 881.12 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T15:24:23Z

Patch 1: "[v3,1/4] dt-bindings: phy: spacemit: add K1 USB2 PHY"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1143.45 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T15:24:45Z

Patch 1: "[v3,1/4] dt-bindings: phy: spacemit: add K1 USB2 PHY"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.05 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T15:25:07Z

Patch 1: "[v3,1/4] dt-bindings: phy: spacemit: add K1 USB2 PHY"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.38 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T15:25:11Z

Patch 1: "[v3,1/4] dt-bindings: phy: spacemit: add K1 USB2 PHY"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.48 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 40 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 2de38ba2941d ("dt-bindings: phy: spacemit: add K1 USB2 PHY") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 40 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

linux-riscv-bot · 2025-05-17T15:26:20Z

Patch 1: "[v3,1/4] dt-bindings: phy: spacemit: add K1 USB2 PHY"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 68.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T15:26:22Z

Patch 1: "[v3,1/4] dt-bindings: phy: spacemit: add K1 USB2 PHY"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T15:26:24Z

Patch 1: "[v3,1/4] dt-bindings: phy: spacemit: add K1 USB2 PHY"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T15:26:26Z

Patch 1: "[v3,1/4] dt-bindings: phy: spacemit: add K1 USB2 PHY"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T15:26:27Z

Patch 1: "[v3,1/4] dt-bindings: phy: spacemit: add K1 USB2 PHY"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T15:26:29Z

Patch 1: "[v3,1/4] dt-bindings: phy: spacemit: add K1 USB2 PHY"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T15:28:29Z

Patch 2: "[v3,2/4] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 105.30 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T15:43:14Z

Patch 2: "[v3,2/4] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 883.15 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:02:19Z

Patch 2: "[v3,2/4] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1144.45 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:02:41Z

Patch 2: "[v3,2/4] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.69 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:03:04Z

Patch 2: "[v3,2/4] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.41 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:03:07Z

Patch 2: "[v3,2/4] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.57 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 72 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit fecc415b3df1 ("dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 72 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

linux-riscv-bot · 2025-05-17T16:04:17Z

Patch 2: "[v3,2/4] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 68.94 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:04:19Z

Patch 2: "[v3,2/4] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:04:21Z

Patch 2: "[v3,2/4] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY"
kdoc
Desc: Detects for kdoc errors
Duration: 0.80 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:04:23Z

Patch 2: "[v3,2/4] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:04:25Z

Patch 2: "[v3,2/4] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:04:26Z

Patch 2: "[v3,2/4] dt-bindings: phy: spacemit: add K1 PCIe/USB3 combo PHY"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:06:26Z

Patch 3: "[v3,3/4] phy: spacemit: support K1 USB2.0 PHY controller"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.82 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:22:40Z

Patch 3: "[v3,3/4] phy: spacemit: support K1 USB2.0 PHY controller"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 972.17 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:43:40Z

Patch 3: "[v3,3/4] phy: spacemit: support K1 USB2.0 PHY controller"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1258.55 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:44:01Z

Patch 3: "[v3,3/4] phy: spacemit: support K1 USB2.0 PHY controller"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.29 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:44:24Z

Patch 3: "[v3,3/4] phy: spacemit: support K1 USB2.0 PHY controller"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.60 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:44:28Z

Patch 3: "[v3,3/4] phy: spacemit: support K1 USB2.0 PHY controller"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.58 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#66: FILE: drivers/phy/spacemit/Kconfig:5:
+config PHY_SPACEMIT_K1_USB2
+	tristate "SpacemiT K1 USB 2.0 PHY support"
+	depends on (ARCH_SPACEMIT || COMPILE_TEST) && OF
+	depends on COMMON_CLK
+	depends on USB_COMMON
+	select GENERIC_PHY
+	help
+	  Enable this to support K1 USB 2.0 PHY driver. This driver takes care of
+	  enabling and clock setup and will be used by K1 udc/ehci/otg/xhci driver.

total: 0 errors, 2 warnings, 0 checks, 160 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 00810e3a49b0 ("phy: spacemit: support K1 USB2.0 PHY controller") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 0 checks, 160 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines

linux-riscv-bot · 2025-05-17T16:45:37Z

Patch 3: "[v3,3/4] phy: spacemit: support K1 USB2.0 PHY controller"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 67.26 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:45:39Z

Patch 3: "[v3,3/4] phy: spacemit: support K1 USB2.0 PHY controller"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:45:41Z

Patch 3: "[v3,3/4] phy: spacemit: support K1 USB2.0 PHY controller"
kdoc
Desc: Detects for kdoc errors
Duration: 1.24 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:45:43Z

Patch 3: "[v3,3/4] phy: spacemit: support K1 USB2.0 PHY controller"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:45:45Z

Patch 3: "[v3,3/4] phy: spacemit: support K1 USB2.0 PHY controller"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:45:47Z

Patch 3: "[v3,3/4] phy: spacemit: support K1 USB2.0 PHY controller"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.32 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T16:47:46Z

Patch 4: "[v3,4/4] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.93 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T17:03:05Z

Patch 4: "[v3,4/4] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 917.59 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T17:22:56Z

Patch 4: "[v3,4/4] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1188.98 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T17:23:17Z

Patch 4: "[v3,4/4] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.17 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T17:23:40Z

Patch 4: "[v3,4/4] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.58 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T17:23:44Z

Patch 4: "[v3,4/4] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.43 seconds
Result: WARNING
Output:

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#28: FILE: drivers/phy/spacemit/Kconfig:15:
+config PHY_SPACEMIT_K1_COMBPHY
+	tristate "SpacemiT K1 PCIe/USB3 combo PHY support"
+	depends on (ARCH_SPACEMIT || COMPILE_TEST) && OF
+	depends on COMMON_CLK
+	select GENERIC_PHY
+	help
+	  USB3/PCIe Combo PHY Support for SpacemiT K1 SoC

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
new file mode 100644

total: 0 errors, 2 warnings, 0 checks, 262 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit cdff544740b8 ("phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 0 checks, 262 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines

linux-riscv-bot · 2025-05-17T17:24:54Z

Patch 4: "[v3,4/4] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 69.19 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T17:24:57Z

Patch 4: "[v3,4/4] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.90 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T17:24:59Z

Patch 4: "[v3,4/4] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY"
kdoc
Desc: Detects for kdoc errors
Duration: 0.87 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T17:25:01Z

Patch 4: "[v3,4/4] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T17:25:02Z

Patch 4: "[v3,4/4] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.55 seconds
Result: PASS

linux-riscv-bot · 2025-05-17T17:25:04Z

Patch 4: "[v3,4/4] phy: spacemit: add USB3 support for K1 PCIe/USB3 combo PHY"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

Sutter099 added 4 commits May 17, 2025 14:45

dt-bindings: phy: spacemit: add K1 USB2 PHY

2de38ba

Add support for USB2 PHY found on SpacemiT K1 SoC. Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Signed-off-by: Ze Huang <huangze@whut.edu.cn> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot closed this May 25, 2025

linux-riscv-bot deleted the pw963855 branch May 25, 2025 01:09

Conversation

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025

Uh oh!

linux-riscv-bot commented May 17, 2025