Skip to content

[PW_SID:964436] mailbox: mailbox-test: Fix __might_sleep() warning in mbox_test_message_read() #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
linux-riscv-bot wants to merge 1 commit into from
Closed

[PW_SID:964436] mailbox: mailbox-test: Fix __might_sleep() warning in mbox_test_message_read() #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion drivers/mailbox/mailbox-test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,11 +200,13 @@ static ssize_t mbox_test_message_read(struct file *filp, char __user *userbuf,

if (filp->f_flags & O_NONBLOCK) {
ret = -EAGAIN;
__set_current_state(TASK_RUNNING);
goto waitq_err;
}

if (signal_pending(current)) {
ret = -ERESTARTSYS;
__set_current_state(TASK_RUNNING);
goto waitq_err;
}
schedule();
Expand All @@ -231,9 +233,9 @@ static ssize_t mbox_test_message_read(struct file *filp, char __user *userbuf,

spin_unlock_irqrestore(&tdev->lock, flags);

__set_current_state(TASK_RUNNING);
ret = simple_read_from_buffer(userbuf, count, ppos, touser, MBOX_HEXDUMP_MAX_LEN);
waitq_err:
__set_current_state(TASK_RUNNING);
remove_wait_queue(&tdev->waitq, &wait);
kfree_err:
kfree(touser);
Expand Down