Skip to content

[PW_SID:965426] drivers: acpi: Fix platform profile driver on !acpi platforms#431

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw965426
Closed

[PW_SID:965426] drivers: acpi: Fix platform profile driver on !acpi platforms#431
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw965426

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented May 22, 2025

PR for series 965426 applied to workflow__riscv__fixes

Name: drivers: acpi: Fix platform profile driver on !acpi platforms
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=965426
Version: 1

drivers: acpi: Fix platform profile driver on !acpi platforms
bd87ba7 
The platform profile driver is loaded even on platforms that do not have
acpi enabled. The initialization of the sysfs entries was recently moved
from platform_profile_register() to the module init call, and those
entries need acpi_kobj to be initialized which is not the case when acpi
is disabled.

This results in the following warning:

 WARNING: CPU: 5 PID: 1 at fs/sysfs/group.c:131 internal_create_group+0xa22/0xdd8
 Modules linked in:
 CPU: 5 UID: 0 PID: 1 Comm: swapper/0 Tainted: G        W           6.15.0-rc7-dirty #6 PREEMPT
 Tainted: [W]=WARN
 Hardware name: riscv-virtio,qemu (DT)
 epc : internal_create_group+0xa22/0xdd8
  ra : internal_create_group+0xa22/0xdd8

 Call Trace:

 internal_create_group+0xa22/0xdd8
 sysfs_create_group+0x22/0x2e
 platform_profile_init+0x74/0xb2
 do_one_initcall+0x198/0xa9e
 kernel_init_freeable+0x6d8/0x780
 kernel_init+0x28/0x24c
 ret_from_fork+0xe/0x18

Fix this by checking if acpi is enabled before trying to create sysfs
entries.

Fixes: 77be5ca ("ACPI: platform_profile: Create class for ACPI platform profile")
Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 22, 2025

Patch 1: "drivers: acpi: Fix platform profile driver on !acpi platforms"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 106.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 22, 2025

Patch 1: "drivers: acpi: Fix platform profile driver on !acpi platforms"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 910.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 22, 2025

Patch 1: "drivers: acpi: Fix platform profile driver on !acpi platforms"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1185.37 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 22, 2025

Patch 1: "drivers: acpi: Fix platform profile driver on !acpi platforms"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.78 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 22, 2025

Patch 1: "drivers: acpi: Fix platform profile driver on !acpi platforms"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.78 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 22, 2025

Patch 1: "drivers: acpi: Fix platform profile driver on !acpi platforms"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.77 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 22, 2025

Patch 1: "drivers: acpi: Fix platform profile driver on !acpi platforms"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 68.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 22, 2025

Patch 1: "drivers: acpi: Fix platform profile driver on !acpi platforms"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 22, 2025

Patch 1: "drivers: acpi: Fix platform profile driver on !acpi platforms"
kdoc
Desc: Detects for kdoc errors
Duration: 0.92 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 22, 2025

Patch 1: "drivers: acpi: Fix platform profile driver on !acpi platforms"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 22, 2025

Patch 1: "drivers: acpi: Fix platform profile driver on !acpi platforms"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented May 22, 2025

Patch 1: "drivers: acpi: Fix platform profile driver on !acpi platforms"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw965426 branch May 30, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@linux-riscv-bot