[PW_SID:966164] [RFC,1/6] rust: Add basic PWM abstractions by linux-riscv-bot · Pull Request #442 · linux-riscv/linux

linux-riscv-bot · 2025-05-24T21:41:52Z

PR for series 966164 applied to workflow__riscv__fixes

Name: [RFC,1/6] rust: Add basic PWM abstractions
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=966164
Version: 1

Introduce initial Rust abstractions for the Linux PWM subsystem. These abstractions provide safe wrappers around the core C data structures and functions, enabling the development of PWM chip drivers in Rust. The main components added are: - A Kconfig option RUST_PWM_ABSTRACTIONS - C helper functions in rust/helpers/pwm.c to provide stable callable interfaces for Rust, for pwmchip_parent, pwmchip_get_drvdata, and pwmchip_set_drvdata - A new Rust module rust/kernel/pwm.rs containing: - Safe wrappers for struct pwm_chip, struct pwm_device, struct pwm_state, and struct pwm_args - An enum Polarity for type safe polarity handling - Functions devm_chip_alloc and devm_chip_add which wrap the kernel's device-managed APIs for PWM chip allocation and registration. - A PwmOps trait and create_pwm_ops function to allow Rust drivers to define their PWM operations, initially supporting the .apply callback. This foundational layer will be used by subsequent patches to implement a specific PWM chip driver in Rust. It focuses on the pwm_chip provider APIs necessary for such a driver. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Introduce a PWM driver for the T-HEAD TH1520 SoC written in Rust. It utilizes the Rust PWM abstractions added in the previous commit. The driver implements the standard PwmOps for the PWM framework, supporting configuration of period, duty cycle, and polarity for the TH1520's PWM channels. It uses devm managed resources for the PWM chip itself and Rust DevRes for I/O memory. Clock management is handled using Rust's RAII pattern. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Add the Device Tree binding documentation for the T-HEAD TH1520 SoC PWM controller. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Add the Device Tree node for the T-HEAD TH1520 SoC's PWM controller. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Add PVT DT node for thermal sensor. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Add Device Tree nodes to enable a PWM controlled fan and it's associated thermal management for the Lichee Pi 4A board. This enables temperature-controlled active cooling for the Lichee Pi 4A board based on SoC temperature. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2025-05-24T21:47:18Z

Patch 1: "[RFC,1/6] rust: Add basic PWM abstractions"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 105.59 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:02:11Z

Patch 1: "[RFC,1/6] rust: Add basic PWM abstractions"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 891.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:21:17Z

Patch 1: "[RFC,1/6] rust: Add basic PWM abstractions"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1145.20 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:21:38Z

Patch 1: "[RFC,1/6] rust: Add basic PWM abstractions"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.77 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:22:01Z

Patch 1: "[RFC,1/6] rust: Add basic PWM abstractions"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.88 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:22:05Z

Patch 1: "[RFC,1/6] rust: Add basic PWM abstractions"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 3.03 seconds
Result: WARNING
Output:

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#69: FILE: drivers/pwm/Kconfig:758:
+ config RUST_PWM_ABSTRACTIONS
+	bool "Rust PWM abstractions support"
+	depends on RUST
+	depends on PWM=y
+	help
+	  Adds support needed for PWM drivers written in Rust. It provides a
+          wrapper around the C pwm core.
+

total: 0 errors, 1 warnings, 0 checks, 442 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 8f1f099e7eaa ("rust: Add basic PWM abstractions") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 442 lines checked
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines

linux-riscv-bot · 2025-05-24T22:23:13Z

Patch 1: "[RFC,1/6] rust: Add basic PWM abstractions"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 67.01 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:23:17Z

Patch 1: "[RFC,1/6] rust: Add basic PWM abstractions"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:23:19Z

Patch 1: "[RFC,1/6] rust: Add basic PWM abstractions"
kdoc
Desc: Detects for kdoc errors
Duration: 0.86 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:23:21Z

Patch 1: "[RFC,1/6] rust: Add basic PWM abstractions"
module-param
Desc: Detect module_param changes
Duration: 0.32 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:23:23Z

Patch 1: "[RFC,1/6] rust: Add basic PWM abstractions"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:23:25Z

Patch 1: "[RFC,1/6] rust: Add basic PWM abstractions"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:25:24Z

Patch 2: "[RFC,2/6] pwm: Add Rust driver for T-HEAD TH1520 SoC"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.32 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:40:16Z

Patch 2: "[RFC,2/6] pwm: Add Rust driver for T-HEAD TH1520 SoC"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 890.16 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:59:23Z

Patch 2: "[RFC,2/6] pwm: Add Rust driver for T-HEAD TH1520 SoC"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1145.92 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T22:59:44Z

Patch 2: "[RFC,2/6] pwm: Add Rust driver for T-HEAD TH1520 SoC"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.69 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T23:00:07Z

Patch 2: "[RFC,2/6] pwm: Add Rust driver for T-HEAD TH1520 SoC"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.41 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T23:00:10Z

Patch 2: "[RFC,2/6] pwm: Add Rust driver for T-HEAD TH1520 SoC"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.04 seconds
Result: WARNING
Output:

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#45: FILE: drivers/pwm/Kconfig:687:
+config PWM_TH1520_RUST
+	tristate "TH1520 PWM support (Rust)"
+	depends on RUST_PWM_ABSTRACTIONS
+	help
+	  Generic PWM framework driver for TH1520 SoC.
+

total: 0 errors, 1 warnings, 0 checks, 295 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit ba379044deea ("pwm: Add Rust driver for T-HEAD TH1520 SoC") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 295 lines checked
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines

linux-riscv-bot · 2025-05-24T23:01:18Z

Patch 2: "[RFC,2/6] pwm: Add Rust driver for T-HEAD TH1520 SoC"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 66.68 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T23:01:20Z

Patch 2: "[RFC,2/6] pwm: Add Rust driver for T-HEAD TH1520 SoC"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T23:01:22Z

Patch 2: "[RFC,2/6] pwm: Add Rust driver for T-HEAD TH1520 SoC"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T23:01:24Z

Patch 2: "[RFC,2/6] pwm: Add Rust driver for T-HEAD TH1520 SoC"
module-param
Desc: Detect module_param changes
Duration: 0.32 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T23:01:26Z

Patch 2: "[RFC,2/6] pwm: Add Rust driver for T-HEAD TH1520 SoC"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

linux-riscv-bot · 2025-05-24T23:01:27Z

Patch 2: "[RFC,2/6] pwm: Add Rust driver for T-HEAD TH1520 SoC"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:18:35Z

Patch 4: "[RFC,4/6] riscv: dts: thead: Add PWM controller node"
kdoc
Desc: Detects for kdoc errors
Duration: 0.87 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:18:36Z

Patch 4: "[RFC,4/6] riscv: dts: thead: Add PWM controller node"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:18:38Z

Patch 4: "[RFC,4/6] riscv: dts: thead: Add PWM controller node"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:18:40Z

Patch 4: "[RFC,4/6] riscv: dts: thead: Add PWM controller node"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:20:39Z

Patch 5: "[RFC,5/6] riscv: dts: thead: Add PVT node"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.46 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:36:06Z

Patch 5: "[RFC,5/6] riscv: dts: thead: Add PVT node"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 925.60 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:56:02Z

Patch 5: "[RFC,5/6] riscv: dts: thead: Add PVT node"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1194.34 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:56:23Z

Patch 5: "[RFC,5/6] riscv: dts: thead: Add PVT node"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.03 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:56:45Z

Patch 5: "[RFC,5/6] riscv: dts: thead: Add PVT node"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.19 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:56:48Z

Patch 5: "[RFC,5/6] riscv: dts: thead: Add PVT node"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.76 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:57:56Z

Patch 5: "[RFC,5/6] riscv: dts: thead: Add PVT node"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 66.26 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:57:57Z

Patch 5: "[RFC,5/6] riscv: dts: thead: Add PVT node"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:58:00Z

Patch 5: "[RFC,5/6] riscv: dts: thead: Add PVT node"
kdoc
Desc: Detects for kdoc errors
Duration: 1.01 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:58:01Z

Patch 5: "[RFC,5/6] riscv: dts: thead: Add PVT node"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:58:03Z

Patch 5: "[RFC,5/6] riscv: dts: thead: Add PVT node"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T00:58:04Z

Patch 5: "[RFC,5/6] riscv: dts: thead: Add PVT node"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T01:00:03Z

Patch 6: "[RFC,6/6] riscv: dts: thead: Add PWM fan and thermal control"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.78 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T01:15:30Z

Patch 6: "[RFC,6/6] riscv: dts: thead: Add PWM fan and thermal control"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 925.75 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T01:35:26Z

Patch 6: "[RFC,6/6] riscv: dts: thead: Add PWM fan and thermal control"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1194.62 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T01:35:47Z

Patch 6: "[RFC,6/6] riscv: dts: thead: Add PWM fan and thermal control"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 19.80 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T01:36:09Z

Patch 6: "[RFC,6/6] riscv: dts: thead: Add PWM fan and thermal control"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.06 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T01:36:11Z

Patch 6: "[RFC,6/6] riscv: dts: thead: Add PWM fan and thermal control"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.73 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T01:37:19Z

Patch 6: "[RFC,6/6] riscv: dts: thead: Add PWM fan and thermal control"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 66.38 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T01:37:21Z

Patch 6: "[RFC,6/6] riscv: dts: thead: Add PWM fan and thermal control"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T01:37:23Z

Patch 6: "[RFC,6/6] riscv: dts: thead: Add PWM fan and thermal control"
kdoc
Desc: Detects for kdoc errors
Duration: 1.04 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T01:37:25Z

Patch 6: "[RFC,6/6] riscv: dts: thead: Add PWM fan and thermal control"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T01:37:26Z

Patch 6: "[RFC,6/6] riscv: dts: thead: Add PWM fan and thermal control"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-05-25T01:37:28Z

Patch 6: "[RFC,6/6] riscv: dts: thead: Add PWM fan and thermal control"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

Michal Wilczynski added 6 commits May 24, 2025 21:41

dt-bindings: pwm: thead: Add T-HEAD TH1520 PWM controller

e819464

Add the Device Tree binding documentation for the T-HEAD TH1520 SoC PWM controller. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

riscv: dts: thead: Add PWM controller node

6ebc53e

Add the Device Tree node for the T-HEAD TH1520 SoC's PWM controller. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

riscv: dts: thead: Add PVT node

27864b5

Add PVT DT node for thermal sensor. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot closed this May 28, 2025

linux-riscv-bot deleted the pw966164 branch May 28, 2025 14:21

Conversation

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 24, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025

Uh oh!

linux-riscv-bot commented May 25, 2025