[PW_SID:967717] fix riscv runtime constant support#457
Conversation
the `__runtime_fixup_32` function does not handle the case where `val` is zero correctly (as might occur when patching a nommu kernel and referring to a physical address below the 4GiB boundary whose upper 32 bits are all zero) because nothing in the existing logic prevents the code from taking the `else` branch of both nop-checks and emitting two `nop` instructions. This leaves random garbage in the register that is supposed to receive the upper 32 bits of the pointer instead of zero that when combined with the value for the lower 32 bits yields an invalid pointer and causes a kernel panic when that pointer is eventually accessed. The author clearly considered the fact that if the `lui` is converted into a `nop` that the second instruction needs to be adjusted to become an `li` instead of an `addi`, hence introducing the `addi_insn_mask` variable, but didn't follow that logic through fully to the case where the `else` branch executes. To fix it just adjust the logic to ensure that the second `else` branch is not taken if the first instruction will be patched to a `nop`. Fixes: a44fb57 ("riscv: Add runtime constant support") Signed-off-by: Charles Mirabile <cmirabil@redhat.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
|
Patch 1: "[v1,1/1] riscv: fix runtime constant support for nommu kernels" |
|
Patch 1: "[v1,1/1] riscv: fix runtime constant support for nommu kernels" |
|
Patch 1: "[v1,1/1] riscv: fix runtime constant support for nommu kernels" |
|
Patch 1: "[v1,1/1] riscv: fix runtime constant support for nommu kernels" |
|
Patch 1: "[v1,1/1] riscv: fix runtime constant support for nommu kernels" |
|
Patch 1: "[v1,1/1] riscv: fix runtime constant support for nommu kernels" |
|
Patch 1: "[v1,1/1] riscv: fix runtime constant support for nommu kernels" |
|
Patch 1: "[v1,1/1] riscv: fix runtime constant support for nommu kernels" |
|
Patch 1: "[v1,1/1] riscv: fix runtime constant support for nommu kernels" |
|
Patch 1: "[v1,1/1] riscv: fix runtime constant support for nommu kernels" |
|
Patch 1: "[v1,1/1] riscv: fix runtime constant support for nommu kernels" |
|
Patch 1: "[v1,1/1] riscv: fix runtime constant support for nommu kernels" |
1 participant
PR for series 967717 applied to workflow__riscv__fixes
Name: fix riscv runtime constant support
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=967717
Version: 1