Skip to content

[PW_SID:968954] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation#477

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw968954
Closed

[PW_SID:968954] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation#477
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw968954

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

PR for series 968954 applied to workflow__riscv__fixes

Name: crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=968954
Version: 1

This is a straight import of the OpenSSL/CRYPTOGAMS Poly1305
implementation for riscv authored by Andy Polyakov.
The file 'poly1305-riscv.pl' is taken straight from this upstream
GitHub repository [0] at commit 33fe84bc21219a16825459b37c825bf4580a0a7b,
and this commit fixed a bug in riscv 64bit implementation.
Also, this patch passed extra run-time self tests.

[0] https://github.com/dot-asm/cryptogams

Signed-off-by: Zhihang Shao <zhihang.shao.iscas@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 107.40 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 984.02 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1278.92 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.10 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.55 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1493.99 seconds
Result: WARNING
Output:

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#37: FILE: arch/riscv/crypto/Kconfig:41:
+config CRYPTO_POLY1305_RISCV
+	tristate "Hash functions: Poly1305"
+	select CRYPTO_HASH
+	select CRYPTO_ARCH_HAVE_LIB_POLY1305
+	help
+	  Poly1305 authenticator algorithm (RFC7539)
+
+	  Architecture: riscv using:
+	  - V vector extension
+

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#82: 
new file mode 100644

CHECK: Alignment should match open parenthesis
#133: FILE: arch/riscv/crypto/poly1305-glue.c:47:
+static void riscv64_poly1305_blocks(struct poly1305_desc_ctx *dctx, const u8 *src,
+				 u32 len, u32 hibit)

CHECK: Alignment should match open parenthesis
#161: FILE: arch/riscv/crypto/poly1305-glue.c:75:
+static void riscv64_poly1305_do_update(struct poly1305_desc_ctx *dctx,
+				    const u8 *src, u32 len)

CHECK: Alignment should match open parenthesis
#173: FILE: arch/riscv/crypto/poly1305-glue.c:87:
+			riscv64_poly1305_blocks(dctx, dctx->buf,
+					     POLY1305_BLOCK_SIZE, 1);

CHECK: Alignment should match open parenthesis
#191: FILE: arch/riscv/crypto/poly1305-glue.c:105:
+static int riscv64_poly1305_update(struct shash_desc *desc,
+				const u8 *src, unsigned int srclen)

total: 0 errors, 2 warnings, 4 checks, 1055 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 55e005be4f59 ("crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 4 checks, 1055 lines checked
CHECK: Alignment should match open parenthesis
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines


@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 68.04 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
kdoc
Desc: Detects for kdoc errors
Duration: 0.87 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw968954 branch June 8, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants