Skip to content

[PW_SID:969152] riscv: Replace __ASSEMBLY__ with __ASSEMBLER__ in header files#478

Closed
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__for-nextfrom
pw969152
Closed

[PW_SID:969152] riscv: Replace __ASSEMBLY__ with __ASSEMBLER__ in header files#478
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__for-nextfrom
pw969152

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

PR for series 969152 applied to workflow__riscv__for-next

Name: riscv: Replace ASSEMBLY with ASSEMBLER in header files
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=969152
Version: 2

Linux RISC-V bot and others added 3 commits June 5, 2025 21:18
__ASSEMBLY__ is only defined by the Makefile of the kernel, so
this is not really useful for uapi headers (unless the userspace
Makefile defines it, too). Let's switch to __ASSEMBLER__ which
gets set automatically by the compiler when compiling assembly
code.

This is a completely mechanical patch (done with a simple "sed -i"
statement).

Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: Alexandre Ghiti <alex@ghiti.fr>
Cc: linux-riscv@lists.infradead.org
Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
While the GCC and Clang compilers already define __ASSEMBLER__
automatically when compiling assembly code, __ASSEMBLY__ is a
macro that only gets defined by the Makefiles in the kernel.
This can be very confusing when switching between userspace
and kernelspace coding, or when dealing with uapi headers that
rather should use __ASSEMBLER__ instead. So let's standardize on
the __ASSEMBLER__ macro that is provided by the compilers now.

This originally was a completely mechanical patch (done with a
simple "sed -i" statement), with some manual fixups during
rebasing of the patch later.

Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: Alexandre Ghiti <alex@ghiti.fr>
Cc: linux-riscv@lists.infradead.org
Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] riscv: Replace ASSEMBLY with ASSEMBLER in uapi headers"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 105.83 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] riscv: Replace ASSEMBLY with ASSEMBLER in uapi headers"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1587.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] riscv: Replace ASSEMBLY with ASSEMBLER in uapi headers"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 2096.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] riscv: Replace ASSEMBLY with ASSEMBLER in uapi headers"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.84 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] riscv: Replace ASSEMBLY with ASSEMBLER in uapi headers"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.44 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] riscv: Replace ASSEMBLY with ASSEMBLER in uapi headers"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.14 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] riscv: Replace ASSEMBLY with ASSEMBLER in uapi headers"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 67.06 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] riscv: Replace ASSEMBLY with ASSEMBLER in uapi headers"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] riscv: Replace ASSEMBLY with ASSEMBLER in uapi headers"
kdoc
Desc: Detects for kdoc errors
Duration: 0.86 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] riscv: Replace ASSEMBLY with ASSEMBLER in uapi headers"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] riscv: Replace ASSEMBLY with ASSEMBLER in uapi headers"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v2,1/2] riscv: Replace ASSEMBLY with ASSEMBLER in uapi headers"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] riscv: Replace ASSEMBLY with ASSEMBLER in non-uapi headers"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 105.85 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] riscv: Replace ASSEMBLY with ASSEMBLER in non-uapi headers"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1614.47 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] riscv: Replace ASSEMBLY with ASSEMBLER in non-uapi headers"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 2079.90 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] riscv: Replace ASSEMBLY with ASSEMBLER in non-uapi headers"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.18 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] riscv: Replace ASSEMBLY with ASSEMBLER in non-uapi headers"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.80 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] riscv: Replace ASSEMBLY with ASSEMBLER in non-uapi headers"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 6.84 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] riscv: Replace ASSEMBLY with ASSEMBLER in non-uapi headers"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 67.90 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] riscv: Replace ASSEMBLY with ASSEMBLER in non-uapi headers"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] riscv: Replace ASSEMBLY with ASSEMBLER in non-uapi headers"
kdoc
Desc: Detects for kdoc errors
Duration: 0.94 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] riscv: Replace ASSEMBLY with ASSEMBLER in non-uapi headers"
module-param
Desc: Detect module_param changes
Duration: 0.32 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] riscv: Replace ASSEMBLY with ASSEMBLER in non-uapi headers"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v2,2/2] riscv: Replace ASSEMBLY with ASSEMBLER in non-uapi headers"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__for-next branch 2 times, most recently from 7991a94 to 43068f0 Compare June 12, 2025 21:42
@linux-riscv-bot linux-riscv-bot deleted the pw969152 branch June 14, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants