Skip to content

[PW_SID:969734] [v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation#488

Closed
linux-riscv-bot wants to merge 2 commits into
workflowfrom
pw969734
Closed

[PW_SID:969734] [v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation#488
linux-riscv-bot wants to merge 2 commits into
workflowfrom
pw969734

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Jun 9, 2025

PR for series 969734 applied to workflow

Name: [v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=969734
Version: 3

Linux RISC-V bot and others added 2 commits June 8, 2025 21:17
Adding CI files
e65aa72
@BattiestStone4
crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation
5c8c23e 
This is a straight import of the OpenSSL/CRYPTOGAMS Poly1305
implementation for riscv authored by Andy Polyakov.
The file 'poly1305-riscv.pl' is taken straight from this upstream
GitHub repository [0] at commit 33fe84bc21219a16825459b37c825bf4580a0a7b,
and this commit fixed a bug in riscv 64bit implementation.

[0] https://github.com/dot-asm/cryptogams

Signed-off-by: Zhihang Shao <zhihang.shao.iscas@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 9, 2025

Patch 1: "[v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.12 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 9, 2025

Patch 1: "[v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1013.63 seconds
Result: ERROR
Output:

Redirect to /build/tmp.M7Ckax6m46 and /build/tmp.Zri4QbAZ3G
Tree base:
e65aa72ac4cd3 ("Adding CI files")
Building the whole tree with the patch
Building the tree before the patch
Building the tree with the patch
New errors added:
--- /build/tmp.v8rWeAEYFG	2025-06-09 08:47:41.260665032 +0000
+++ /build/tmp.eUixtNnr7X	2025-06-09 08:47:41.271665018 +0000
@@ -518,0 +519 @@
+      1 arch/riscv/lib/crypto/poly1305-glue.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Per-file breakdown
error/warning file pre:
error/warning file post:
pre: 4984 post: 4985



real	13m57.692s
user	527m59.172s
sys	100m12.672s

real	1m25.228s
user	3m19.496s
sys	1m57.032s

real	1m21.068s
user	2m55.336s
sys	1m52.516s

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 9, 2025

Patch 1: "[v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1483.13 seconds
Result: ERROR
Output:

Redirect to /build/tmp.6TypyfKE5o and /build/tmp.xzhCnVXa0m
Tree base:
e65aa72ac4cd3 ("Adding CI files")
Building the whole tree with the patch
Building the tree before the patch
Building the tree with the patch
New errors added:
--- /build/tmp.nhirLrpJYS	2025-06-09 09:12:25.926370276 +0000
+++ /build/tmp.VEf0SHUhfb	2025-06-09 09:12:25.937370264 +0000
@@ -518,0 +519 @@
+      1 arch/riscv/lib/crypto/poly1305-glue.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Per-file breakdown
error/warning file pre:
pre: 4984 post: 4985



real	19m16.937s
user	694m17.138s
sys	118m23.485s

real	2m40.869s
user	4m32.789s
sys	1m54.309s

real	2m35.998s
user	3m51.082s
sys	1m47.978s

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 9, 2025

Patch 1: "[v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.17 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 9, 2025

Patch 1: "[v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 20.96 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 9, 2025

Patch 1: "[v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1472.13 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71: 
new file mode 100644

CHECK: Lines should not end with a '('
#92: FILE: arch/riscv/lib/crypto/poly1305-glue.c:17:
+asmlinkage void poly1305_block_init_arch(

WARNING: adding a line without newline at end of file
#119: FILE: arch/riscv/lib/crypto/poly1305-glue.c:44:
+MODULE_LICENSE("GPL");

total: 0 errors, 2 warnings, 1 checks, 882 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 5c8c23ed7bda ("crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 1 checks, 882 lines checked
CHECK: Lines should not end with a '('
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: adding a line without newline at end of file

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 9, 2025

Patch 1: "[v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.40 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 9, 2025

Patch 1: "[v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 9, 2025

Patch 1: "[v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
kdoc
Desc: Detects for kdoc errors
Duration: 0.90 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 9, 2025

Patch 1: "[v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 9, 2025

Patch 1: "[v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 9, 2025

Patch 1: "[v3] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow branch 2 times, most recently from 81a1dd8 to 5db9bbd Compare June 10, 2025 21:18
@linux-riscv-bot linux-riscv-bot deleted the pw969734 branch June 11, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @BattiestStone4