Skip to content

[PW_SID:970276] Fix a segmentation fault also add raid6test for RISC-V support#497

Closed
linux-riscv-bot wants to merge 5 commits into
workflow__riscv__for-nextfrom
pw970276
Closed

[PW_SID:970276] Fix a segmentation fault also add raid6test for RISC-V support#497
linux-riscv-bot wants to merge 5 commits into
workflow__riscv__for-nextfrom
pw970276

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Jun 10, 2025

PR for series 970276 applied to workflow__riscv__for-next

Name: Fix a segmentation fault also add raid6test for RISC-V support
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=970276
Version: 1

Linux RISC-V bot and others added 5 commits June 5, 2025 21:18
Adding CI files
e678629
raid6: riscv: Clean up unused header file inclusion
795859e 
These two C files don't reference things defined in simd.h or types.h
so remove these redundant #inclusions.

Fixes: 6093faa ("raid6: Add RISC-V SIMD syndrome and recovery calculations")
Signed-off-by: Chunyan Zhang <zhangchunyan@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
raid6: riscv: Fix NULL pointer dereference issue
47c8b72 
When running the raid6 user-space test program on RISC-V QEMU, there's a
segmentation fault which seems caused by accessing a NULL pointer,
which is the pointer variable p/q in raid6_rvv*_gen/xor_syndrome_real(),
p/q should have been equal to dptr[x], but when I use GDB command to
see its value, which was 0x10 like below:

"
Program received signal SIGSEGV, Segmentation fault.
0x0000000000011062 in raid6_rvv2_xor_syndrome_real (disks=<optimized out>, start=0, stop=<optimized out>, bytes=4096, ptrs=<optimized out>) at rvv.c:386
(gdb) p p
$1 = (u8 *) 0x10 <error: Cannot access memory at address 0x10>
"

The issue was found to be related with:
1) Compile optimization
   There's no segmentation fault if compiling the raid6test program with
   the optimization flag -O0.
2) The RISC-V vector command vsetvli
   If not used t0 as the first parameter in vsetvli, there's no
   segmentation fault either.

This patch selects the 2nd solution to fix the issue.

Fixes: 6093faa ("raid6: Add RISC-V SIMD syndrome and recovery calculations")
Signed-off-by: Chunyan Zhang <zhangchunyan@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
raid6: riscv: Allow code to be compiled in userspace
747e169 
To support userspace raid6test, this patch adds __KERNEL__ ifdef for kernel
header inclusions also userspace wrapper definitions to allow code to be
compiled in userspace.

Signed-off-by: Chunyan Zhang <zhangchunyan@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@lyrazhang
raid6: test: Add support for RISC-V
15ff42c 
Add RISC-V code to be compiled to allow the userspace raid6test program
to be built and run on RISC-V.

Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 1: "[1/4] raid6: riscv: Clean up unused header file inclusion"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 101.04 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 1: "[1/4] raid6: riscv: Clean up unused header file inclusion"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 925.49 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 1: "[1/4] raid6: riscv: Clean up unused header file inclusion"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1261.72 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 1: "[1/4] raid6: riscv: Clean up unused header file inclusion"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.44 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 1: "[1/4] raid6: riscv: Clean up unused header file inclusion"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.77 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 1: "[1/4] raid6: riscv: Clean up unused header file inclusion"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.91 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 1: "[1/4] raid6: riscv: Clean up unused header file inclusion"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 68.10 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 1: "[1/4] raid6: riscv: Clean up unused header file inclusion"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 1: "[1/4] raid6: riscv: Clean up unused header file inclusion"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 1: "[1/4] raid6: riscv: Clean up unused header file inclusion"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 1: "[1/4] raid6: riscv: Clean up unused header file inclusion"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 1: "[1/4] raid6: riscv: Clean up unused header file inclusion"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 2: "[2/4] raid6: riscv: Fix NULL pointer dereference issue"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.40 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 2: "[2/4] raid6: riscv: Fix NULL pointer dereference issue"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 923.47 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 2: "[2/4] raid6: riscv: Fix NULL pointer dereference issue"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1259.72 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 2: "[2/4] raid6: riscv: Fix NULL pointer dereference issue"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.69 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 2: "[2/4] raid6: riscv: Fix NULL pointer dereference issue"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.42 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 2: "[2/4] raid6: riscv: Fix NULL pointer dereference issue"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.74 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 2: "[2/4] raid6: riscv: Fix NULL pointer dereference issue"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 67.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 2: "[2/4] raid6: riscv: Fix NULL pointer dereference issue"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 2: "[2/4] raid6: riscv: Fix NULL pointer dereference issue"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 2: "[2/4] raid6: riscv: Fix NULL pointer dereference issue"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 2: "[2/4] raid6: riscv: Fix NULL pointer dereference issue"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 2: "[2/4] raid6: riscv: Fix NULL pointer dereference issue"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 3: "[3/4] raid6: riscv: Allow code to be compiled in userspace"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.66 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 3: "[3/4] raid6: riscv: Allow code to be compiled in userspace"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 928.46 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 3: "[3/4] raid6: riscv: Allow code to be compiled in userspace"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1258.32 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 3: "[3/4] raid6: riscv: Allow code to be compiled in userspace"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.79 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 3: "[3/4] raid6: riscv: Allow code to be compiled in userspace"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.65 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 3: "[3/4] raid6: riscv: Allow code to be compiled in userspace"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.10 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 3: "[3/4] raid6: riscv: Allow code to be compiled in userspace"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.43 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 3: "[3/4] raid6: riscv: Allow code to be compiled in userspace"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.98 seconds
Result: ERROR
Output:

Detected static functions without inline keyword in header files:
+
+static int rvv_has_vector(void)
+{
Detected static functions without inline keyword in header files: 1

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 3: "[3/4] raid6: riscv: Allow code to be compiled in userspace"
kdoc
Desc: Detects for kdoc errors
Duration: 0.90 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 3: "[3/4] raid6: riscv: Allow code to be compiled in userspace"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 3: "[3/4] raid6: riscv: Allow code to be compiled in userspace"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 3: "[3/4] raid6: riscv: Allow code to be compiled in userspace"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.55 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 4: "[4/4] raid6: test: Add support for RISC-V"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 101.59 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 4: "[4/4] raid6: test: Add support for RISC-V"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 903.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 4: "[4/4] raid6: test: Add support for RISC-V"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1227.68 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 4: "[4/4] raid6: test: Add support for RISC-V"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.13 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 4: "[4/4] raid6: test: Add support for RISC-V"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.32 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 4: "[4/4] raid6: test: Add support for RISC-V"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.65 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 4: "[4/4] raid6: test: Add support for RISC-V"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 68.11 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 4: "[4/4] raid6: test: Add support for RISC-V"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 4: "[4/4] raid6: test: Add support for RISC-V"
kdoc
Desc: Detects for kdoc errors
Duration: 0.85 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 4: "[4/4] raid6: test: Add support for RISC-V"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 4: "[4/4] raid6: test: Add support for RISC-V"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 10, 2025

Patch 4: "[4/4] raid6: test: Add support for RISC-V"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__for-next branch from e678629 to 7991a94 Compare June 10, 2025 15:47
@linux-riscv-bot linux-riscv-bot deleted the pw970276 branch June 12, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @lyrazhang