Skip to content

[PW_SID:970638] [v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation#503

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw970638
Closed

[PW_SID:970638] [v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation#503
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw970638

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

PR for series 970638 applied to workflow__riscv__fixes

Name: [v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=970638
Version: 4

Linux RISC-V bot and others added 2 commits June 11, 2025 02:52
This is a straight import of the OpenSSL/CRYPTOGAMS Poly1305
implementation for riscv authored by Andy Polyakov.
The file 'poly1305-riscv.pl' is taken straight from this upstream
GitHub repository [0] at commit 33fe84bc21219a16825459b37c825bf4580a0a7b,
and this commit fixed a bug in riscv 64bit implementation.

[0] https://github.com/dot-asm/cryptogams

Signed-off-by: Zhihang Shao <zhihang.shao.iscas@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.75 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1025.74 seconds
Result: ERROR
Output:

Redirect to /build/tmp.OjisON4POF and /build/tmp.k9EGAewtoK
Tree base:
0b44c192f316c ("Adding CI files")
Building the whole tree with the patch
Building the tree before the patch
Building the tree with the patch
New errors added:
--- /build/tmp.vztqOn1GR8	2025-06-11 04:12:50.071421034 +0000
+++ /build/tmp.7nzzKXAzuH	2025-06-11 04:12:50.079421014 +0000
@@ -518,0 +519 @@
+      1 arch/riscv/lib/crypto/poly1305-glue.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Per-file breakdown
error/warning file pre:
error/warning file post:
pre: 4984 post: 4985



real	14m8.832s
user	532m52.379s
sys	101m35.961s

real	1m25.471s
user	3m20.089s
sys	1m59.433s

real	1m22.589s
user	2m55.239s
sys	1m53.494s

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1503.54 seconds
Result: ERROR
Output:

Redirect to /build/tmp.KjSUxx6wH8 and /build/tmp.b0lnlhYBX5
Tree base:
0b44c192f316c ("Adding CI files")
Building the whole tree with the patch
Building the tree before the patch
Building the tree with the patch
New errors added:
--- /build/tmp.odcI5TAhZ5	2025-06-11 04:37:54.417724611 +0000
+++ /build/tmp.6UJctKR7zj	2025-06-11 04:37:54.428724603 +0000
@@ -518,0 +519 @@
+      1 arch/riscv/lib/crypto/poly1305-glue.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Per-file breakdown
error/warning file pre:
pre: 4984 post: 4985



real	19m27.588s
user	699m9.928s
sys	119m28.640s

real	2m46.329s
user	4m36.431s
sys	1m55.404s

real	2m40.133s
user	3m54.761s
sys	1m48.815s

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.59 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.74 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1488.36 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#72: 
new file mode 100644

CHECK: Lines should not end with a '('
#93: FILE: arch/riscv/lib/crypto/poly1305-glue.c:17:
+asmlinkage void poly1305_block_init_arch(

CHECK: Alignment should match open parenthesis
#98: FILE: arch/riscv/lib/crypto/poly1305-glue.c:22:
+asmlinkage void poly1305_blocks_arch(struct poly1305_block_state *state,
+				const u8 *src, u32 len, u32 hibit);

WARNING: adding a line without newline at end of file
#113: FILE: arch/riscv/lib/crypto/poly1305-glue.c:37:
+MODULE_LICENSE("GPL");

total: 0 errors, 2 warnings, 2 checks, 895 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 0ceb2ca3f8f9 ("crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 2 checks, 895 lines checked
CHECK: Alignment should match open parenthesis
CHECK: Lines should not end with a '('
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: adding a line without newline at end of file


@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 70.79 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
kdoc
Desc: Detects for kdoc errors
Duration: 0.87 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v4] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__fixes branch from 0b44c19 to 8023d1f Compare June 12, 2025 20:21
@linux-riscv-bot linux-riscv-bot deleted the pw970638 branch June 19, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants