[PW_SID:970632] Add SiFive power provider driver by linux-riscv-bot · Pull Request #505 · linux-riscv/linux

linux-riscv-bot · 2025-06-11T04:55:25Z

PR for series 970632 applied to workflow__riscv__fixes

Name: Add SiFive power provider driver
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=970632
Version: 2

SiFive Domain Management controller includes the following components - SiFive Tile Management Controller - SiFive Cluster Management Controller - SiFive Core Complex Management Controller These controllers control the clock and power domain of the corresponding domain. However, Since we don't have a SoC specific compatible string yet, so add '- {}' for the first entry [1][2]. Links: - [1] https://lore.kernel.org/lkml/20250311195953.GA14239-robh@kernel.org/ - [2] https://lore.kernel.org/lkml/CAKddAkAzDGL-7MbroRqQnZzPXOquUMKNuGGppqB-d_XZXbcvBA@mail.gmail.com/T/#t Signed-off-by: Nick Hu <nick.hu@sifive.com> Reviewed-by: Samuel Holland <samuel.holland@sifive.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

To work with the external pmdomain driver, exposing the `sbi_cpuidle_pd_power_off` and `sbi_dt_parse_state_node` so the external pmdomain driver can parse the riscv idle state data and set the domain idle state where powering off. In addition, defer the driver without error message when the parent domain is not ready. Co-developed-by: Samuel Holland <samuel.holland@sifive.com> Signed-off-by: Samuel Holland <samuel.holland@sifive.com> Signed-off-by: Nick Hu <nick.hu@sifive.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

The SiFive DMC is the power provider of the devices that inside the SiFive CPU power domains, which include Tile, Cluster and Core Complex power domains. Before the cpu entering the firmware-based idle state, each devices that inside the corresponding domain should be suspended properly. So this driver will create the power provider and set the correct idle state. Signed-off-by: Nick Hu <nick.hu@sifive.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2025-06-11T05:00:49Z

Patch 1: "[v2,1/3] dt-bindings: power: Add SiFive Domain Management controllers"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 108.55 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T05:17:12Z

Patch 1: "[v2,1/3] dt-bindings: power: Add SiFive Domain Management controllers"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 981.31 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T05:39:22Z

Patch 1: "[v2,1/3] dt-bindings: power: Add SiFive Domain Management controllers"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1328.94 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T05:39:45Z

Patch 1: "[v2,1/3] dt-bindings: power: Add SiFive Domain Management controllers"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.95 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T05:40:09Z

Patch 1: "[v2,1/3] dt-bindings: power: Add SiFive Domain Management controllers"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.31 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T05:40:12Z

Patch 1: "[v2,1/3] dt-bindings: power: Add SiFive Domain Management controllers"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.80 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 70 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 0f81250fc653 ("dt-bindings: power: Add SiFive Domain Management controllers") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 70 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

linux-riscv-bot · 2025-06-11T05:41:25Z

Patch 1: "[v2,1/3] dt-bindings: power: Add SiFive Domain Management controllers"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 72.16 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T05:41:27Z

Patch 1: "[v2,1/3] dt-bindings: power: Add SiFive Domain Management controllers"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T05:41:29Z

Patch 1: "[v2,1/3] dt-bindings: power: Add SiFive Domain Management controllers"
kdoc
Desc: Detects for kdoc errors
Duration: 0.87 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T05:41:31Z

Patch 1: "[v2,1/3] dt-bindings: power: Add SiFive Domain Management controllers"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T05:41:32Z

Patch 1: "[v2,1/3] dt-bindings: power: Add SiFive Domain Management controllers"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T05:41:34Z

Patch 1: "[v2,1/3] dt-bindings: power: Add SiFive Domain Management controllers"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T05:43:37Z

Patch 2: "[v2,2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 107.86 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T06:01:43Z

Patch 2: "[v2,2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1084.21 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T06:28:15Z

Patch 2: "[v2,2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1591.10 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T06:28:38Z

Patch 2: "[v2,2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.29 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T06:29:02Z

Patch 2: "[v2,2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.05 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T06:29:05Z

Patch 2: "[v2,2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.87 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#79: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 67 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 3e4a303bdd76 ("cpuidle: riscv-sbi: Work with the external pmdomain driver") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 67 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

linux-riscv-bot · 2025-06-11T06:30:19Z

Patch 2: "[v2,2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 72.36 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T06:30:20Z

Patch 2: "[v2,2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T06:30:23Z

Patch 2: "[v2,2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver"
kdoc
Desc: Detects for kdoc errors
Duration: 0.84 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T06:30:25Z

Patch 2: "[v2,2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T06:30:26Z

Patch 2: "[v2,2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T06:30:28Z

Patch 2: "[v2,2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T06:32:30Z

Patch 3: "[v2,3/3] cpuidle: Add SiFive power provider"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 107.14 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T06:50:36Z

Patch 3: "[v2,3/3] cpuidle: Add SiFive power provider"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1084.24 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T07:17:10Z

Patch 3: "[v2,3/3] cpuidle: Add SiFive power provider"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1593.09 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T07:17:33Z

Patch 3: "[v2,3/3] cpuidle: Add SiFive power provider"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.35 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T07:17:56Z

Patch 3: "[v2,3/3] cpuidle: Add SiFive power provider"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.89 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T07:18:00Z

Patch 3: "[v2,3/3] cpuidle: Add SiFive power provider"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.13 seconds
Result: WARNING
Output:

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#31: FILE: drivers/cpuidle/Kconfig.riscv:17:
+config SIFIVE_DMC_PD_CPUIDLE
+	bool "SiFive DMC SBI PD Provider Driver"
+	depends on ARCH_SIFIVE
+	select PM_GENERIC_DOMAINS_OF
+	select RISCV_SBI_CPUIDLE
+	default y
+	help
+	  Select this option to enable SiFive DMC SBI PD Provider driver.
+	  This driver will create the genpd provider and work with the
+	  RISC-V SBI firmware based CPU idle driver.

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 2 warnings, 0 checks, 120 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 4d9dedfbab51 ("cpuidle: Add SiFive power provider") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 0 checks, 120 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines

linux-riscv-bot · 2025-06-11T07:19:13Z

Patch 3: "[v2,3/3] cpuidle: Add SiFive power provider"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.71 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T07:19:15Z

Patch 3: "[v2,3/3] cpuidle: Add SiFive power provider"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T07:19:17Z

Patch 3: "[v2,3/3] cpuidle: Add SiFive power provider"
kdoc
Desc: Detects for kdoc errors
Duration: 0.87 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T07:19:19Z

Patch 3: "[v2,3/3] cpuidle: Add SiFive power provider"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T07:19:20Z

Patch 3: "[v2,3/3] cpuidle: Add SiFive power provider"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T07:19:22Z

Patch 3: "[v2,3/3] cpuidle: Add SiFive power provider"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

nick650823 added 3 commits June 11, 2025 04:55

linux-riscv-bot closed this Jun 11, 2025

linux-riscv-bot deleted the pw970632 branch June 11, 2025 14:19

Conversation

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone