Skip to content

[PW_SID:970663] pinctrl: Constify pointers to 'pinctrl_desc' and more#506

Closed
linux-riscv-bot wants to merge 17 commits into
workflow__riscv__fixesfrom
pw970663
Closed

[PW_SID:970663] pinctrl: Constify pointers to 'pinctrl_desc' and more#506
linux-riscv-bot wants to merge 17 commits into
workflow__riscv__fixesfrom
pw970663

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Jun 11, 2025

PR for series 970663 applied to workflow__riscv__fixes

Name: pinctrl: Constify pointers to 'pinctrl_desc' and more
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=970663
Version: 2

krzk added 17 commits June 11, 2025 07:45
@krzk
pinctrl: starfive: Allow compile testing on other platforms
e842c85 
Always descent to drivers/pinctrl/starfive/ because limiting it with
SOC_STARFIVE is redundant since its Makefile doesn't build anything if
no Starfive-specific pin control Kconfig options are enabled.  This
allows compile testing on other architectures with allyesconfig.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: Allow compile testing for K210, TB10X and ZYNQ
939e0d8 
Pinctrl drivers for K210, TB10X and ZYNQ do not reference any machine
headers, thus can be compile tested for increased build coverage.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: amd: Constify pointers to 'pinctrl_desc'
2b6eeb3 
Internal functions obtaining pointers to 'struct pinctrl_desc' do not
modify the contents so they can be made pointers to const.  This makes
code safer, explicit and later allows constifying 'pinctrl_desc' in
pinctrl core code.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: Constify pointers to 'pinctrl_desc'
19f8d6e 
Pin controller core code only stores the pointer to
'struct pinctrl_desc' and does not modify it anywhere.  The pointer can
be changed to pointer to const which makes the code safer, explicit and
later allows constifying 'pinctrl_desc' allocations in individual
drivers.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: aspeed: Constify static 'pinctrl_desc'
c0d9324 
The local static 'struct pinctrl_desc' is not modified, so can be made
const for code safety.

Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: nuvoton: Constify static 'pinctrl_desc'
b0fb8ec 
The local static 'struct pinctrl_desc' is not modified, so can be made
const for code safety.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: bcm: Constify static 'pinctrl_desc'
babc9e6 
The local static 'struct pinctrl_desc' is not modified, so can be made
const for code safety.

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: bcm: cygnus-mux: Move fixed assignments to 'pinctrl_desc' de…
1fac9c9 
…finition

Assign 'struct pinctrl_desc' .npins member in definition to make clear
that number of pins is fixed and have less code in the probe.

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: bcm: cygnus-ns2: Move fixed assignments to 'pinctrl_desc' de…
15697f6 
…finition

Assign 'struct pinctrl_desc' .npins member in definition to make clear
that number of pins is fixed and have less code in the probe.

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: bcm: cygnus-nsp: Move fixed assignments to 'pinctrl_desc' de…
2bc365d 
…finition

Assign 'struct pinctrl_desc' .npins member in definition to make clear
that number of pins is fixed and have less code in the probe.

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: as3722: Move fixed assignments to 'pinctrl_desc' definition
850038a 
Assign 'struct pinctrl_desc' .pins and .npins members in definition to
make clear that number of pins is fixed and have less code in the probe.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: max77620: Move fixed assignments to 'pinctrl_desc' definition
efc2887 
Assign 'struct pinctrl_desc' .pins, .npins and other members in
definition to make clear that number of pins is fixed and have less code
in the probe.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: palmas: Move fixed assignments to 'pinctrl_desc' definition
5a61ea2 
Assign 'struct pinctrl_desc' .pins and .npins members in definition to
make clear that number of pins is fixed and have less code in the probe.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: renesas: Move fixed assignments to 'pinctrl_desc' definition
5bfa39a 
Assign 'struct pinctrl_desc' .pins and .npins members in definition to
make clear that number of pins is fixed and have less code in the probe.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: pistachio: Constify static 'pinctrl_desc'
517da34 
The local static 'struct pinctrl_desc' is not modified, so can be made
const for code safety after moving .pins and .npins assignment to
definition.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
pinctrl: Constify static 'pinctrl_desc'
8d57589 
The local static 'struct pinctrl_desc' is not modified, so can be made
const for code safety.

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@krzk
rtc: stm32: Constify static 'pinctrl_desc'
d338051 
The local static 'struct pinctrl_desc' is not modified, so can be made
const for code safety.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 1: "[v2,01/17] pinctrl: starfive: Allow compile testing on other platforms"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 105.34 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 1: "[v2,01/17] pinctrl: starfive: Allow compile testing on other platforms"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 921.67 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 1: "[v2,01/17] pinctrl: starfive: Allow compile testing on other platforms"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1238.53 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 1: "[v2,01/17] pinctrl: starfive: Allow compile testing on other platforms"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.62 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 1: "[v2,01/17] pinctrl: starfive: Allow compile testing on other platforms"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.14 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 1: "[v2,01/17] pinctrl: starfive: Allow compile testing on other platforms"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.65 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 1: "[v2,01/17] pinctrl: starfive: Allow compile testing on other platforms"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.64 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 1: "[v2,01/17] pinctrl: starfive: Allow compile testing on other platforms"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 1: "[v2,01/17] pinctrl: starfive: Allow compile testing on other platforms"
kdoc
Desc: Detects for kdoc errors
Duration: 0.87 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 1: "[v2,01/17] pinctrl: starfive: Allow compile testing on other platforms"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 1: "[v2,01/17] pinctrl: starfive: Allow compile testing on other platforms"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 1: "[v2,01/17] pinctrl: starfive: Allow compile testing on other platforms"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 2: "[v2,02/17] pinctrl: Allow compile testing for K210, TB10X and ZYNQ"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 15: "[v2,15/17] pinctrl: pistachio: Constify static 'pinctrl_desc'"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 70.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 15: "[v2,15/17] pinctrl: pistachio: Constify static 'pinctrl_desc'"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 15: "[v2,15/17] pinctrl: pistachio: Constify static 'pinctrl_desc'"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 15: "[v2,15/17] pinctrl: pistachio: Constify static 'pinctrl_desc'"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 15: "[v2,15/17] pinctrl: pistachio: Constify static 'pinctrl_desc'"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 15: "[v2,15/17] pinctrl: pistachio: Constify static 'pinctrl_desc'"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 16: "[v2,16/17] pinctrl: Constify static 'pinctrl_desc'"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.16 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 16: "[v2,16/17] pinctrl: Constify static 'pinctrl_desc'"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1011.42 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 16: "[v2,16/17] pinctrl: Constify static 'pinctrl_desc'"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1488.13 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 16: "[v2,16/17] pinctrl: Constify static 'pinctrl_desc'"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.00 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 16: "[v2,16/17] pinctrl: Constify static 'pinctrl_desc'"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.81 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 16: "[v2,16/17] pinctrl: Constify static 'pinctrl_desc'"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.62 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 16: "[v2,16/17] pinctrl: Constify static 'pinctrl_desc'"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 70.96 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 16: "[v2,16/17] pinctrl: Constify static 'pinctrl_desc'"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 16: "[v2,16/17] pinctrl: Constify static 'pinctrl_desc'"
kdoc
Desc: Detects for kdoc errors
Duration: 0.92 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 16: "[v2,16/17] pinctrl: Constify static 'pinctrl_desc'"
module-param
Desc: Detect module_param changes
Duration: 0.32 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 16: "[v2,16/17] pinctrl: Constify static 'pinctrl_desc'"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 2.37 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 16: "[v2,16/17] pinctrl: Constify static 'pinctrl_desc'"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 17: "[v2,17/17] rtc: stm32: Constify static 'pinctrl_desc'"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.66 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 17: "[v2,17/17] rtc: stm32: Constify static 'pinctrl_desc'"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 944.92 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 17: "[v2,17/17] rtc: stm32: Constify static 'pinctrl_desc'"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1276.93 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 17: "[v2,17/17] rtc: stm32: Constify static 'pinctrl_desc'"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.75 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 17: "[v2,17/17] rtc: stm32: Constify static 'pinctrl_desc'"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.17 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 17: "[v2,17/17] rtc: stm32: Constify static 'pinctrl_desc'"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.71 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 17: "[v2,17/17] rtc: stm32: Constify static 'pinctrl_desc'"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.10 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 17: "[v2,17/17] rtc: stm32: Constify static 'pinctrl_desc'"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 17: "[v2,17/17] rtc: stm32: Constify static 'pinctrl_desc'"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 17: "[v2,17/17] rtc: stm32: Constify static 'pinctrl_desc'"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 17: "[v2,17/17] rtc: stm32: Constify static 'pinctrl_desc'"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 11, 2025

Patch 17: "[v2,17/17] rtc: stm32: Constify static 'pinctrl_desc'"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @krzk