[PW_SID:970729] vdso: Reject absolute relocations during build by linux-riscv-bot · Pull Request #512 · linux-riscv/linux

linux-riscv-bot · 2025-06-11T09:48:16Z

PR for series 970729 applied to workflow__riscv__fixes

Name: vdso: Reject absolute relocations during build
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=970729
Version: 3

All vDSO objects need the same treatment. To make changes to both the list of objects and the list of removed flags easier, introduce a helper variable. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

All the other architectures supporting LTO (x86, arm64, loongarch) do not use it for the vDSO. Its is problematic for some upcoming compile-time validation of the generated object code. The LTO object files do not contain the necessary relocation information and -flto-fat-objects is not compatible with clang < 16. For consistency and to enable the mentioned compile-time checks, disable LTO for the vDSO. The vDSO heavily uses __always_inline anyways. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

All vDSO code needs to be completely position independent. Symbol references are marked as hidden so the compiler emits PC-relative relocations. However there are cases where the compiler may still emit absolute relocations, as they are valid in regular PIC DSO code. These would be resolved by the linker and will break at runtime. This has been observed on arm64 under some circumstances, see commit 0c314cd ("arm64: vdso: Work around invalid absolute relocations from GCC") Introduce a build-time check for absolute relocations. The check is done on the object files as the relocations will not exist anymore in the final DSO. As there is no extension point for the compilation of each object file, perform the validation in vdso_check. Debug information can contain legal absolute relocations and readelf can not print relocations from the .text section only. Make use of the fact that all global vDSO symbols follow the naming pattern "vdso_u_". Link: https://lore.kernel.org/lkml/aApGPAoctq_eoE2g@t14ultra/ Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120002 Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2025-06-11T09:53:30Z

Patch 1: "[v3,1/3] riscv: vdso: Deduplicate CFLAGS_REMOVE_* variables"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.68 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:09:02Z

Patch 1: "[v3,1/3] riscv: vdso: Deduplicate CFLAGS_REMOVE_* variables"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 929.95 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:30:00Z

Patch 1: "[v3,1/3] riscv: vdso: Deduplicate CFLAGS_REMOVE_* variables"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1256.56 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:30:22Z

Patch 1: "[v3,1/3] riscv: vdso: Deduplicate CFLAGS_REMOVE_* variables"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.73 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:30:45Z

Patch 1: "[v3,1/3] riscv: vdso: Deduplicate CFLAGS_REMOVE_* variables"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.42 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:30:47Z

Patch 1: "[v3,1/3] riscv: vdso: Deduplicate CFLAGS_REMOVE_* variables"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.58 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:31:59Z

Patch 1: "[v3,1/3] riscv: vdso: Deduplicate CFLAGS_REMOVE_* variables"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 70.73 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:32:01Z

Patch 1: "[v3,1/3] riscv: vdso: Deduplicate CFLAGS_REMOVE_* variables"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:32:04Z

Patch 1: "[v3,1/3] riscv: vdso: Deduplicate CFLAGS_REMOVE_* variables"
kdoc
Desc: Detects for kdoc errors
Duration: 1.91 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:32:06Z

Patch 1: "[v3,1/3] riscv: vdso: Deduplicate CFLAGS_REMOVE_* variables"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:32:07Z

Patch 1: "[v3,1/3] riscv: vdso: Deduplicate CFLAGS_REMOVE_* variables"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:32:09Z

Patch 1: "[v3,1/3] riscv: vdso: Deduplicate CFLAGS_REMOVE_* variables"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:34:08Z

Patch 2: "[v3,2/3] riscv: vdso: Disable LTO for the vDSO"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.81 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T10:49:40Z

Patch 2: "[v3,2/3] riscv: vdso: Disable LTO for the vDSO"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 931.51 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:11:03Z

Patch 2: "[v3,2/3] riscv: vdso: Disable LTO for the vDSO"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1280.90 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:11:25Z

Patch 2: "[v3,2/3] riscv: vdso: Disable LTO for the vDSO"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.05 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:11:49Z

Patch 2: "[v3,2/3] riscv: vdso: Disable LTO for the vDSO"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.82 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:11:51Z

Patch 2: "[v3,2/3] riscv: vdso: Disable LTO for the vDSO"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.63 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:13:04Z

Patch 2: "[v3,2/3] riscv: vdso: Disable LTO for the vDSO"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.88 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:13:06Z

Patch 2: "[v3,2/3] riscv: vdso: Disable LTO for the vDSO"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:13:08Z

Patch 2: "[v3,2/3] riscv: vdso: Disable LTO for the vDSO"
kdoc
Desc: Detects for kdoc errors
Duration: 0.87 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:13:10Z

Patch 2: "[v3,2/3] riscv: vdso: Disable LTO for the vDSO"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:13:12Z

Patch 2: "[v3,2/3] riscv: vdso: Disable LTO for the vDSO"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:13:13Z

Patch 2: "[v3,2/3] riscv: vdso: Disable LTO for the vDSO"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:15:13Z

Patch 3: "[v3,3/3] vdso: Reject absolute relocations during build"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.22 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:32:32Z

Patch 3: "[v3,3/3] vdso: Reject absolute relocations during build"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1037.87 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:58:22Z

Patch 3: "[v3,3/3] vdso: Reject absolute relocations during build"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1548.23 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:58:44Z

Patch 3: "[v3,3/3] vdso: Reject absolute relocations during build"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.77 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:59:07Z

Patch 3: "[v3,3/3] vdso: Reject absolute relocations during build"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.79 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T11:59:09Z

Patch 3: "[v3,3/3] vdso: Reject absolute relocations during build"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.66 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T12:00:22Z

Patch 3: "[v3,3/3] vdso: Reject absolute relocations during build"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.11 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T12:00:23Z

Patch 3: "[v3,3/3] vdso: Reject absolute relocations during build"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T12:00:26Z

Patch 3: "[v3,3/3] vdso: Reject absolute relocations during build"
kdoc
Desc: Detects for kdoc errors
Duration: 0.87 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T12:00:27Z

Patch 3: "[v3,3/3] vdso: Reject absolute relocations during build"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T12:00:29Z

Patch 3: "[v3,3/3] vdso: Reject absolute relocations during build"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-06-11T12:00:31Z

Patch 3: "[v3,3/3] vdso: Reject absolute relocations during build"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

Linux RISC-V bot and others added 4 commits June 11, 2025 02:52

Adding CI files

0b44c19

linux-riscv-bot force-pushed the workflow__riscv__fixes branch from 0b44c19 to 8023d1f Compare June 12, 2025 20:21

linux-riscv-bot closed this Jun 19, 2025

linux-riscv-bot deleted the pw970729 branch June 19, 2025 01:22

Conversation

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

linux-riscv-bot commented Jun 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone