Skip to content

[PW_SID:971697] RISC-V: perf/kvm: Add reporting of interrupt events#528

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw971697
Closed

[PW_SID:971697] RISC-V: perf/kvm: Add reporting of interrupt events#528
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw971697

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

PR for series 971697 applied to workflow__riscv__fixes

Name: RISC-V: perf/kvm: Add reporting of interrupt events
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=971697
Version: 1

Linux RISC-V bot and others added 2 commits June 12, 2025 20:20
For `perf kvm stat` on the RISC-V, in order to avoid the
occurrence of `UNKNOWN` event names, interrupts should be
reported in addition to exceptions.

testing without patch:

Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "RISC-V: perf/kvm: Add reporting of interrupt events"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.92 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "RISC-V: perf/kvm: Add reporting of interrupt events"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 930.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "RISC-V: perf/kvm: Add reporting of interrupt events"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1252.20 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "RISC-V: perf/kvm: Add reporting of interrupt events"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "RISC-V: perf/kvm: Add reporting of interrupt events"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.72 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "RISC-V: perf/kvm: Add reporting of interrupt events"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.06 seconds
Result: ERROR
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
deleted file mode 100644

WARNING: Improper SPDX comment style for 'tools/perf/arch/riscv/util/riscv_trap_types.h', please use '/*' instead
#94: FILE: tools/perf/arch/riscv/util/riscv_trap_types.h:1:
+// SPDX-License-Identifier: GPL-2.0

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#94: FILE: tools/perf/arch/riscv/util/riscv_trap_types.h:1:
+// SPDX-License-Identifier: GPL-2.0

ERROR: Macros with complex values should be enclosed in parentheses
#136: FILE: tools/perf/arch/riscv/util/riscv_trap_types.h:43:
+#define kvm_riscv_trap_class \
+	TRAP(IRQ_S_SOFT), TRAP(IRQ_VS_SOFT), TRAP(IRQ_M_SOFT), \
+	TRAP(IRQ_S_TIMER), TRAP(IRQ_VS_TIMER), TRAP(IRQ_M_TIMER), \
+	TRAP(IRQ_S_EXT), TRAP(IRQ_VS_EXT), TRAP(IRQ_M_EXT), \
+	TRAP(IRQ_S_GEXT), TRAP(IRQ_PMU_OVF), \
+	TRAP(EXC_INST_MISALIGNED), TRAP(EXC_INST_ACCESS), TRAP(EXC_INST_ILLEGAL), \
+	TRAP(EXC_BREAKPOINT), TRAP(EXC_LOAD_MISALIGNED), TRAP(EXC_LOAD_ACCESS), \
+	TRAP(EXC_STORE_MISALIGNED), TRAP(EXC_STORE_ACCESS), TRAP(EXC_SYSCALL), \
+	TRAP(EXC_HYPERVISOR_SYSCALL), TRAP(EXC_SUPERVISOR_SYSCALL), \
+	TRAP(EXC_INST_PAGE_FAULT), TRAP(EXC_LOAD_PAGE_FAULT), \
+	TRAP(EXC_STORE_PAGE_FAULT), TRAP(EXC_INST_GUEST_PAGE_FAULT), \
+	TRAP(EXC_LOAD_GUEST_PAGE_FAULT), TRAP(EXC_VIRTUAL_INST_FAULT), \
+	TRAP(EXC_STORE_GUEST_PAGE_FAULT)

BUT SEE:

   do {} while (0) advice is over-stated in a few situations:

   The more obvious case is macros, like MODULE_PARM_DESC, invoked at
   file-scope, where C disallows code (it must be in functions).  See
   $exceptions if you have one to add by name.

   More troublesome is declarative macros used at top of new scope,
   like DECLARE_PER_CPU.  These might just compile with a do-while-0
   wrapper, but would be incorrect.  Most of these are handled by
   detecting struct,union,etc declaration primitives in $exceptions.

   Theres also macros called inside an if (block), which "return" an
   expression.  These cannot do-while, and need a ({}) wrapper.

   Enjoy this qualification while we work to improve our heuristics.

total: 1 errors, 3 warnings, 0 checks, 77 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit c5cbeb61a594 ("RISC-V: perf/kvm: Add reporting of interrupt events") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: Macros with complex values should be enclosed in parentheses
WARNING: Improper SPDX comment style for 'tools/perf/arch/riscv/util/riscv_trap_types.h', please use '/*' instead
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?


@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "RISC-V: perf/kvm: Add reporting of interrupt events"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "RISC-V: perf/kvm: Add reporting of interrupt events"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "RISC-V: perf/kvm: Add reporting of interrupt events"
kdoc
Desc: Detects for kdoc errors
Duration: 0.93 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "RISC-V: perf/kvm: Add reporting of interrupt events"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "RISC-V: perf/kvm: Add reporting of interrupt events"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "RISC-V: perf/kvm: Add reporting of interrupt events"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 1.18 seconds
Result: ERROR
Output:

Commit c5cbeb61a594 ("RISC-V: perf/kvm: Add reporting of interrupt events")
	author Signed-off-by missing
	author email:    zhouquan@iscas.ac.cn
	committer email: linux.riscv.bot@gmail.com
	Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Errors in tree with Signed-off-by, please fix!


@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__fixes branch from 8023d1f to 6ce2eef Compare June 20, 2025 17:17
@linux-riscv-bot linux-riscv-bot deleted the pw971697 branch June 21, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants