Skip to content

[PW_SID:971750] crypto: ahash - Stop legacy tfms from using the set_virt fallback path#531

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw971750
Closed

[PW_SID:971750] crypto: ahash - Stop legacy tfms from using the set_virt fallback path#531
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw971750

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Jun 13, 2025

PR for series 971750 applied to workflow__riscv__fixes

Name: crypto: ahash - Stop legacy tfms from using the set_virt fallback path
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=971750
Version: 1

Linux RISC-V bot and others added 2 commits June 12, 2025 20:20
Adding CI files
8023d1f
@herbertx
crypto: ahash - Stop legacy tfms from using the set_virt fallback path
2579b51 
On Thu, Jun 12, 2025 at 10:54:39PM -0700, Eric Biggers wrote:
>
> Actually, crypto_ahash::base::fb is initialized if CRYPTO_ALG_NEED_FALLBACK,
> which many of the drivers already set.  Then crypto_ahash_update() calls
> ahash_do_req_chain() if the algorithm does *not* have
> CRYPTO_AHASH_ALG_BLOCK_ONLY set.  Which then exports the driver's custom state
> and tries to import it into the fallback.
>
> As far as I can tell, it's just broken for most of the existing drivers.

This fallback path is only meant to be used for drivers that have
been converted.  But you're right there is a check missing in there.

Thanks,

---8<---
Ensure that drivers that have not been converted to the ahash API
do not use the ahash_request_set_virt fallback path as they cannot
use the software fallback.

Reported-by: Eric Biggers <ebiggers@kernel.org>
Fixes: 9d7a0ab ("crypto: ahash - Handle partial blocks in API")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 13, 2025

Patch 1: "crypto: ahash - Stop legacy tfms from using the set_virt fallback path"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.20 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 13, 2025

Patch 1: "crypto: ahash - Stop legacy tfms from using the set_virt fallback path"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1035.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 13, 2025

Patch 1: "crypto: ahash - Stop legacy tfms from using the set_virt fallback path"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1504.52 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 13, 2025

Patch 1: "crypto: ahash - Stop legacy tfms from using the set_virt fallback path"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.61 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 13, 2025

Patch 1: "crypto: ahash - Stop legacy tfms from using the set_virt fallback path"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.94 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 13, 2025

Patch 1: "crypto: ahash - Stop legacy tfms from using the set_virt fallback path"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.80 seconds
Result: WARNING
Output:

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#27: 
Reported-by: Eric Biggers <ebiggers@kernel.org>
Fixes: 9d7a0ab1c753 ("crypto: ahash - Handle partial blocks in API")

WARNING: ENOSYS means 'invalid syscall nr' and nothing else
#45: FILE: crypto/ahash.c:351:
+		return -ENOSYS;

total: 0 errors, 2 warnings, 0 checks, 21 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 2579b518ac62 ("crypto: ahash - Stop legacy tfms from using the set_virt fallback path") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 0 checks, 21 lines checked
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 13, 2025

Patch 1: "crypto: ahash - Stop legacy tfms from using the set_virt fallback path"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.49 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 13, 2025

Patch 1: "crypto: ahash - Stop legacy tfms from using the set_virt fallback path"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 13, 2025

Patch 1: "crypto: ahash - Stop legacy tfms from using the set_virt fallback path"
kdoc
Desc: Detects for kdoc errors
Duration: 0.90 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 13, 2025

Patch 1: "crypto: ahash - Stop legacy tfms from using the set_virt fallback path"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 13, 2025

Patch 1: "crypto: ahash - Stop legacy tfms from using the set_virt fallback path"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 13, 2025

Patch 1: "crypto: ahash - Stop legacy tfms from using the set_virt fallback path"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__fixes branch from 8023d1f to 6ce2eef Compare June 20, 2025 17:17
@linux-riscv-bot linux-riscv-bot deleted the pw971750 branch June 21, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @herbertx