Skip to content

[PW_SID:972322] crypto: ahash - Fix infinite recursion in ahash_def_finup#537

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw972322
Closed

[PW_SID:972322] crypto: ahash - Fix infinite recursion in ahash_def_finup#537
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw972322

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Jun 16, 2025

PR for series 972322 applied to workflow__riscv__fixes

Name: crypto: ahash - Fix infinite recursion in ahash_def_finup
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=972322
Version: 1

Linux RISC-V bot and others added 2 commits June 12, 2025 20:20
Adding CI files
8023d1f
@herbertx
crypto: ahash - Fix infinite recursion in ahash_def_finup
8f7eb60 
On Sat, Jun 14, 2025 at 08:18:07PM -0700, Eric Biggers wrote:
>
> Even with your patch applied, it overflows the stack when running the crypto
> self-tests, apparently due to crypto/ahash.c calling into itself recursively:

Thanks for the report.  This driver doesn't provide a finup function
which triggered a bug in the default finup implementation:

---8<---
Invoke the final function directly in the default finup implementation
since crypto_ahash_final is now just a wrapper around finup.

Reported-by: Eric Biggers <ebiggers@kernel.org>
Fixes: 9d7a0ab ("crypto: ahash - Handle partial blocks in API")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 16, 2025

Patch 1: "crypto: ahash - Fix infinite recursion in ahash_def_finup"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.96 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 16, 2025

Patch 1: "crypto: ahash - Fix infinite recursion in ahash_def_finup"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1009.13 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 16, 2025

Patch 1: "crypto: ahash - Fix infinite recursion in ahash_def_finup"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1484.72 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 16, 2025

Patch 1: "crypto: ahash - Fix infinite recursion in ahash_def_finup"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.77 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 16, 2025

Patch 1: "crypto: ahash - Fix infinite recursion in ahash_def_finup"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.36 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 16, 2025

Patch 1: "crypto: ahash - Fix infinite recursion in ahash_def_finup"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.51 seconds
Result: WARNING
Output:

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#18: 
Reported-by: Eric Biggers <ebiggers@kernel.org>
Fixes: 9d7a0ab1c753 ("crypto: ahash - Handle partial blocks in API")

total: 0 errors, 1 warnings, 0 checks, 15 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 8f7eb60c786a ("crypto: ahash - Fix infinite recursion in ahash_def_finup") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 15 lines checked
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 16, 2025

Patch 1: "crypto: ahash - Fix infinite recursion in ahash_def_finup"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.01 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 16, 2025

Patch 1: "crypto: ahash - Fix infinite recursion in ahash_def_finup"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 1.96 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 16, 2025

Patch 1: "crypto: ahash - Fix infinite recursion in ahash_def_finup"
kdoc
Desc: Detects for kdoc errors
Duration: 0.83 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 16, 2025

Patch 1: "crypto: ahash - Fix infinite recursion in ahash_def_finup"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 16, 2025

Patch 1: "crypto: ahash - Fix infinite recursion in ahash_def_finup"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Jun 16, 2025

Patch 1: "crypto: ahash - Fix infinite recursion in ahash_def_finup"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__fixes branch from 8023d1f to 6ce2eef Compare June 20, 2025 17:17
@linux-riscv-bot linux-riscv-bot deleted the pw972322 branch June 23, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @herbertx