[PW_SID:975840] PCI: host-generic: Fix driver_data overwriting bugs by linux-riscv-bot · Pull Request #575 · linux-riscv/linux

linux-riscv-bot · 2025-06-25T15:20:41Z

PR for series 975840 applied to workflow__riscv__fixes

Name: PCI: host-generic: Fix driver_data overwriting bugs
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=975840
Version: 1

On MicroChip MPFS Icicle: microchip-pcie 2000000000.pcie: host bridge /soc/pcie@2000000000 ranges: microchip-pcie 2000000000.pcie: Parsing ranges property... microchip-pcie 2000000000.pcie: MEM 0x2008000000..0x2087ffffff -> 0x0008000000 Unable to handle kernel NULL pointer dereference at virtual address 0000000000000368 Current swapper/0 pgtable: 4K pagesize, 39-bit VAs, pgdp=0x00000000814f1000 [0000000000000368] pgd=0000000000000000, p4d=0000000000000000, pud=0000000000000000 Oops [#1] Modules linked in: CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.15.0-rc1-icicle-00003-gafc0a570bb61 #232 NONE Hardware name: Microchip PolarFire-SoC Icicle Kit (DT) [...] [<ffffffff803fb8a4>] plda_pcie_setup_iomems+0xe/0x78 [<ffffffff803fc246>] mc_platform_init+0x80/0x1d2 [<ffffffff803f9c88>] pci_ecam_create+0x104/0x1e2 [<ffffffff8000adbe>] pci_host_common_init+0x120/0x228 [<ffffffff8000af42>] pci_host_common_probe+0x7c/0x8a The initialization of driver_data was moved after the call to gen_pci_init(), while the pci_ecam_ops.init() callback mc_platform_init() expects it has already been initialized. Fix this by moving the initialization of driver_data up. Fixes: afc0a57 ("PCI: host-generic: Extract an ECAM bridge creation helper from pci_host_common_probe()") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/774290708a6f0f683711914fda110742c18a7fb2.1750787223.git.geert+renesas@glider.be Signed-off-by: Marc Zyngier <maz@kernel.org> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

The apple driver relies on being able to directly find the matching root port structure from the platform device that represents this port. A previous hack stashed a pointer to the root port structure in the config window private pointer, but that ended up relying on assumptions that break other drivers. Instead, bite the bullet and track the association as part of the driver itself as a list of probed root ports. Signed-off-by: Marc Zyngier <maz@kernel.org> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

…port device" This reverts commit 4900454. Now that nobody relies of cfg->priv containing anything useful before the .init() callback is used, restore the previous behaviour. Signed-off-by: Marc Zyngier <maz@kernel.org> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2025-06-25T15:25:58Z

Patch 1: "[1/3] PCI: host-generic: Set driver_data before calling gen_pci_init()"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.13 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T15:43:03Z

Patch 1: "[1/3] PCI: host-generic: Set driver_data before calling gen_pci_init()"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1024.31 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:08:23Z

Patch 1: "[1/3] PCI: host-generic: Set driver_data before calling gen_pci_init()"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1518.39 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:08:46Z

Patch 1: "[1/3] PCI: host-generic: Set driver_data before calling gen_pci_init()"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.66 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:09:09Z

Patch 1: "[1/3] PCI: host-generic: Set driver_data before calling gen_pci_init()"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.17 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:09:12Z

Patch 1: "[1/3] PCI: host-generic: Set driver_data before calling gen_pci_init()"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.78 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:10:25Z

Patch 1: "[1/3] PCI: host-generic: Set driver_data before calling gen_pci_init()"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.50 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:10:27Z

Patch 1: "[1/3] PCI: host-generic: Set driver_data before calling gen_pci_init()"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:10:29Z

Patch 1: "[1/3] PCI: host-generic: Set driver_data before calling gen_pci_init()"
kdoc
Desc: Detects for kdoc errors
Duration: 1.17 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:10:31Z

Patch 1: "[1/3] PCI: host-generic: Set driver_data before calling gen_pci_init()"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:10:33Z

Patch 1: "[1/3] PCI: host-generic: Set driver_data before calling gen_pci_init()"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:10:34Z

Patch 1: "[1/3] PCI: host-generic: Set driver_data before calling gen_pci_init()"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:12:33Z

Patch 2: "[2/3] PCI: apple: Add tracking of probed root ports"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.02 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:28:30Z

Patch 2: "[2/3] PCI: apple: Add tracking of probed root ports"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 954.77 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:50:02Z

Patch 2: "[2/3] PCI: apple: Add tracking of probed root ports"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1290.84 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:50:24Z

Patch 2: "[2/3] PCI: apple: Add tracking of probed root ports"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.76 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:50:48Z

Patch 2: "[2/3] PCI: apple: Add tracking of probed root ports"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.90 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:50:50Z

Patch 2: "[2/3] PCI: apple: Add tracking of probed root ports"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.74 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:52:02Z

Patch 2: "[2/3] PCI: apple: Add tracking of probed root ports"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 70.60 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:52:04Z

Patch 2: "[2/3] PCI: apple: Add tracking of probed root ports"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:52:06Z

Patch 2: "[2/3] PCI: apple: Add tracking of probed root ports"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:52:07Z

Patch 2: "[2/3] PCI: apple: Add tracking of probed root ports"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:52:09Z

Patch 2: "[2/3] PCI: apple: Add tracking of probed root ports"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:52:11Z

Patch 2: "[2/3] PCI: apple: Add tracking of probed root ports"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T16:54:09Z

Patch 3: "[3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device""
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.38 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T17:11:11Z

Patch 3: "[3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device""
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1019.78 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T17:36:10Z

Patch 3: "[3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device""
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1497.48 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T17:36:32Z

Patch 3: "[3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device""
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.09 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T17:36:56Z

Patch 3: "[3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device""
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.69 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T17:36:58Z

Patch 3: "[3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device""
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.69 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T17:38:10Z

Patch 3: "[3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device""
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.08 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T17:38:12Z

Patch 3: "[3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device""
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T17:38:14Z

Patch 3: "[3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device""
kdoc
Desc: Detects for kdoc errors
Duration: 0.82 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T17:38:16Z

Patch 3: "[3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device""
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T17:38:18Z

Patch 3: "[3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device""
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-06-25T17:38:20Z

Patch 3: "[3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device""
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

Linux RISC-V bot and others added 4 commits June 24, 2025 01:05

Adding CI files

b5ded79

linux-riscv-bot force-pushed the workflow__riscv__fixes branch 2 times, most recently from a7cb30d to d776861 Compare July 2, 2025 18:46

linux-riscv-bot closed this Jul 3, 2025

linux-riscv-bot deleted the pw975840 branch July 3, 2025 01:06

Conversation

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

linux-riscv-bot commented Jun 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone