[PW_SID:978519] riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection#601
[PW_SID:978519] riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection#601linux-riscv-bot wants to merge 1 commit into
Conversation
When I was reading the source code of ftrace, I learned that
ftrace has two types: static and dynamic. Initially, I planned
to prioritize reading the static source code, so I disabled
the enable dynamic option in RISCV.
[*] Kernel Function Tracer
[ ] Kernel Function Graph Tracer
[ ] enable/disable function tracing dynamically (NEW)
However, when I tried to compile it, the build failed.
./include/linux/ftrace.h:190:16: error: implicit declaration of
function ‘arch_ftrace_get_regs’; did you mean ‘arch_ftrace_regs’?
[-Wimplicit-function-declaration]
190 | return arch_ftrace_get_regs(fregs);
| ^~~~~~~~~~~~~~~~~~~~
| arch_ftrace_regs
After comparing it with the ARM64 architecture, I found that
ARM64 automatically enables DYNAMIC_FTRACE by default once
FUNCTION_TRACER is turned on, and this cannot be set to "no".
Therefore, I believe the optional DYNAMIC_FTRACE setting in
RISC-V has a logic flaw—if FUNCTION_TRACER is enabled,
DYNAMIC_FTRACE should also be enabled, and vice versa. Moreover,
it's clear that RISC-V lacks the necessary support to successfully
compile the kernel when DYNAMIC_FTRACE is disabled.
[*] Kernel Function Tracer
[ ] Kernel Function Graph Tracer
-*- enable/disable function tracing dynamically
Signed-off-by: chenmiao <chenmiao.ku@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
|
Patch 1: "riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection" |
|
Patch 1: "riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection" |
|
Patch 1: "riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection" |
|
Patch 1: "riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection" |
|
Patch 1: "riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection" |
|
Patch 1: "riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection" |
|
Patch 1: "riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection" |
|
Patch 1: "riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection" |
|
Patch 1: "riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection" |
|
Patch 1: "riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection" |
|
Patch 1: "riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection" |
|
Patch 1: "riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection" |
2 participants
PR for series 978519 applied to workflow__riscv__fixes
Name: riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=978519
Version: 1