ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr version and rename qemu/container tox environments to avoid tox 4.x python version parsing issues.

CI:

• Bump tox-lsr in GitHub Actions workflows from 3.15.0 to 3.16.0.
• Rename qemu and container ansible-core tox environment names in the qemu-kvm integration workflow from dotted to dash-separated version identifiers.

Documentation:

• Adjust contributing documentation to reference the new qemu tox environment name and version.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox-lsr dependency to 3.16.0 and renames qemu/container tox environments from dot-separated ansible-core versions to dash-separated ones to avoid tox 4.49 misinterpreting them as Python versions, including updating the contributor usage example.

File-Level Changes

Change	Details	Files
Rename qemu/container tox environments from dot-separated to dash-separated ansible-core version identifiers and propagate those names into the CI matrix.	In the qemu-kvm integration workflow, change all qemu-ansible-core-X.Y environment names to qemu-ansible-core-X-Y in the scenario matrix. In the qemu-kvm integration workflow, change all container-ansible-core-X.Y environment names to container-ansible-core-X-Y in the scenario matrix, including commented-out entries.	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr used in GitHub Actions workflows from 3.15.0 to 3.16.0 to pick up the fixes for the qemu tox test naming issue.	Update the tox-lsr Git URL reference from tag 3.15.0 to 3.16.0 in the qemu-kvm integration CI workflow. Update the tox-lsr Git URL reference from tag 3.15.0 to 3.16.0 in the ansible-lint workflow. Update the tox-lsr Git URL reference from tag 3.15.0 to 3.16.0 in the ansible-managed-var-comment workflow. Update the tox-lsr Git URL reference from tag 3.15.0 to 3.16.0 in the ansible-test workflow.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Align contributor documentation with the new tox environment naming convention and example qemu environment.	Update the example tox command in contributing.md to use qemu-ansible-core-2-20 instead of qemu-ansible-core-2.14, reflecting the dash-separated environment naming and a newer ansible-core version.	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In contributing.md the example now references qemu-ansible-core-2-20, but the CI matrix only defines up to qemu-ansible-core-2-19 (and 2-16/17/18), so consider updating the example to use one of the actually defined environments to avoid confusion.
• Since you renamed the tox environments from major.minor to major-minor in the workflows, it may be worth grepping the repo for any remaining qemu-ansible-core-2.* / container-ansible-core-2.* references using dots to ensure there are no stale env names in scripts or local run instructions.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `contributing.md` the example now references `qemu-ansible-core-2-20`, but the CI matrix only defines up to `qemu-ansible-core-2-19` (and `2-16/17/18`), so consider updating the example to use one of the actually defined environments to avoid confusion.
- Since you renamed the tox environments from `major.minor` to `major-minor` in the workflows, it may be worth grepping the repo for any remaining `qemu-ansible-core-2.*` / `container-ansible-core-2.*` references using dots to ensure there are no stale env names in scripts or local run instructions.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}