ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update qemu and container tox environment names and CI configuration to be compatible with the latest tox-lsr release.

CI:

• Rename qemu and container ansible-core tox environments in GitHub Actions to use hyphenated major-minor versions instead of dotted versions.
• Bump tox-lsr used in all GitHub Actions workflows from 3.15.0 to 3.16.0.

Documentation:

• Adjust contributing guide qemu tox invocation example to use the new hyphenated qemu-ansible-core environment name.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox-lsr dependency and renames qemu/container tox environments from dotted ansible-core versions to dash-separated variants to avoid tox 4.49 misinterpreting them as Python version specifiers, plus aligns contributor docs with the new env names.

Flow diagram for using new qemu-ansible-core-2-20 tox environment

flowchart LR
  dev[Contributor at CLI] --> cmd[tox -e qemu-ansible-core-2-20 -- --image-name centos-9 tests/tests_default.yml]
  cmd --> tox[tox]
  tox --> env_select[Select env qemu-ansible-core-2-20]
  env_select --> qemu_run[Run QEMU-based ansible-core-2_20 tests]
  qemu_run --> report[Report test results]

Loading

File-Level Changes

Change	Details	Files
Align qemu and container CI workflow matrix env names with new dash-separated tox environment naming to avoid tox 4.49 Python version parsing issues.	Rename qemu tox env names from qemu-ansible-core-X.Y to qemu-ansible-core-X-Y in the qemu-kvm integration workflow matrix. Rename container tox env names from container-ansible-core-X.Y to container-ansible-core-X-Y in the same matrix, including commented entries. Ensure all env references within the matrix remain consistent across related images (centos, fedora, leap, bootc variants).	.github/workflows/qemu-kvm-integration-tests.yml
Upgrade tox-lsr version used across CI workflows to 3.16.0 to pick up fixes, including for qemu tox testing.	Bump tox-lsr git reference from 3.15.0 to 3.16.0 in ansible-lint workflow. Bump tox-lsr git reference from 3.15.0 to 3.16.0 in ansible-managed-var-comment workflow. Bump tox-lsr git reference from 3.15.0 to 3.16.0 in ansible-test workflow. Bump tox-lsr git reference from 3.15.0 to 3.16.0 in python-unit-test workflow installation step, alongside tox and virtualenv.	.github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Update contributor documentation to reference the new dash-separated qemu tox environment name and a current ansible-core version example.	Change the example qemu tox invocation from qemu-ansible-core-2.14 to qemu-ansible-core-2-20 in contributing guide. Keep the sample image name and test playbook unchanged to preserve context for local qemu testing.	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The contributing.md example was updated to use qemu-ansible-core-2-20, but there is no corresponding qemu-ansible-core-2-20 environment in the CI matrix in this repo; consider aligning the example with an actually defined tox env (or adding that env in tox.ini) to avoid confusion for contributors.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The contributing.md example was updated to use `qemu-ansible-core-2-20`, but there is no corresponding `qemu-ansible-core-2-20` environment in the CI matrix in this repo; consider aligning the example with an actually defined tox env (or adding that env in tox.ini) to avoid confusion for contributors.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}