ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#299
Merged
ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#299
Conversation
…s them [citest_skip] tox-lsr 3.17.1 has a fix for the broken container tests There was one shell function for both setting up the callback plugins and the connection plugin. When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not set, so all subsequent tests failed. The connection plugin must be present and the env. var. must be set in order to run any container tests. The code was fixed to ensure that there is always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS is always set and contains this path. Also, setting up the callback plugins and the connection plugin is already idempotent, so no reason to skip them. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates CI workflows to use tox-lsr 3.17.1 (which fixes broken container tests) and stops toggling SKIP_CALLBACK_PLUGINS so that connection plugins are always configured correctly during container test runs. Sequence diagram for container tests with fixed connection plugin setupsequenceDiagram
participant Runner as GitHub_Actions_Runner
participant Workflow as CI_Workflow
participant Tox as tox_lsr_3_17_1
participant Ansible as Ansible_Test_Harness
participant ConnSetup as Connection_Plugin_Setup
Runner->>Workflow: Trigger_container_test_job
Workflow->>Workflow: Install_tox_lsr_3_17_1
Workflow->>Tox: Run_tox_environment_for_container_tests
Tox->>ConnSetup: Ensure_connection_plugin_installed
ConnSetup-->>Tox: Connection_plugin_path
Tox->>ConnSetup: Ensure_callback_plugins_installed
ConnSetup->>Workflow: Export_ANSIBLE_CONNECTION_PLUGINS
Note over ConnSetup,Workflow: ANSIBLE_CONNECTION_PLUGINS is always set with connection plugin path
Workflow->>Ansible: Invoke_ansible_container_tests
Ansible->>Ansible: Load_connection_plugin_from_ANSIBLE_CONNECTION_PLUGINS
Ansible-->>Runner: Report_test_results
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox-lsr 3.17.1 has a fix for the broken container tests
There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.
Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to use tox-lsr 3.17.1 and adjust container test execution flags to ensure connection plugins are always configured.
Bug Fixes:
CI: