ci: fix yum repos to use devel site instead of old site name [citest_skip]#301
Merged
ci: fix yum repos to use devel site instead of old site name [citest_skip]#301
Conversation
…skip] Some of the older Testing Farm machines refer to the old site name in the yum repos. Ensure that they use the correct site name. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Testing Farm CI yum repository configurations to use the current devel site name instead of the deprecated site name in the parallel playbook plan. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- If the new yum repo hostnames are hard-coded in the plan, consider centralizing them in a single variable or macro so future domain changes can be applied in one place instead of touching multiple plans.
- Ensure the logic that switches to the new site name is scoped only to the affected Testing Farm environments so that systems already using the correct configuration are not inadvertently altered.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If the new yum repo hostnames are hard-coded in the plan, consider centralizing them in a single variable or macro so future domain changes can be applied in one place instead of touching multiple plans.
- Ensure the logic that switches to the new site name is scoped only to the affected Testing Farm environments so that systems already using the correct configuration are not inadvertently altered.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the older Testing Farm machines refer to the old site name in the yum repos.
Ensure that they use the correct site name.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
CI: