Skip to content

Solution #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hamdi-Hassan wants to merge 4 commits into
base: solution
Choose a base branch
from
Open

Solution #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7a615e
Update nonproduction.yaml
Hamdi-Hassan Feb 4, 2023
69b4253
Update nonproduction.yaml
Hamdi-Hassan Feb 4, 2023
bfab8bc
Update production.yaml
Hamdi-Hassan Feb 4, 2023
f6c5dd5
Update production.yaml
Hamdi-Hassan Feb 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/nonproduction.yaml → .github/workflows/nonproduction.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ name: Deploy feature branches to nonproduction
on:
push:
branches:
- feature*
- solution*

jobs:
build:
runs-on: ubuntu-latest
env:
BUCKET_NAME: <Nonproduction bucket name here>
BUCKET_NAME: test-bckt-gha
steps:
- name: Checkout code
uses: actions/checkout@v2
Expand All @@ -18,7 +18,7 @@ jobs:
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: us-east-1
aws-region: ${{ secrets.AWS_REGION }}
- name: Use Node.js
uses: actions/setup-node@v2
with:
Expand All @@ -30,4 +30,4 @@ jobs:
- name: Deploy bundle to bucket
run: |
echo 'copying files to s3 bucket'
aws s3 cp public s3://${{ env.BUCKET_NAME }}/ --recursive --acl public-read
aws s3 cp public s3://${{ env.BUCKET_NAME }}/ --recursive --acl public-read
8 changes: 4 additions & 4 deletions .github/workflows/production.yaml → .github/workflows/production.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ name: Deploy to production
on:
push:
branches:
- main
- solution*


jobs:
build:
runs-on: ubuntu-latest
env:
BUCKET_NAME: <Production bucket name here>
BUCKET_NAME: prod-bckt-gha
steps:
- name: Checkout code
uses: actions/checkout@v2
Expand All @@ -19,7 +19,7 @@ jobs:
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: us-east-1
aws-region: ${{ secrets.AWS_REGION }}
- name: Use Node.js
uses: actions/setup-node@v2
with:
Expand All @@ -31,4 +31,4 @@ jobs:
- name: Deploy bundle to bucket
run: |
echo 'copying files to s3 bucket'
aws s3 cp public s3://${{ env.BUCKET_NAME }}/ --recursive --acl public-read
aws s3 cp public s3://${{ env.BUCKET_NAME }}/ --recursive --acl public-read