Skip to content

fix(core): make the % works correctly#29

Closed
iovxw wants to merge 1 commit intolinuxdeepin:masterfrom
iovxw:fix-percent
Closed

fix(core): make the % works correctly#29
iovxw wants to merge 1 commit intolinuxdeepin:masterfrom
iovxw:fix-percent

Conversation

@iovxw
Copy link
Copy Markdown

@iovxw iovxw commented Sep 30, 2019

Just like KCalc and GNOME Calculator.

Closes #12

@iovxw
fix(core): make the % works correctly
e330333 
Just like KCalc and GNOME Calculator.

Closes linuxdeepin#12
@iovxw
Copy link
Copy Markdown
Author

iovxw commented Sep 30, 2019

5000 - 30% 等价于 5000 - (5000 * 0.3)

仅限于 + -，和其他主流计算器行为保持一致

BTW: 由于使用的是 SpeedCrunch 开启了 ALLOW_IMPLICIT_MULT， 所以 100%100 是合法的

@BLumia
Copy link
Copy Markdown
Member

BLumia commented Oct 1, 2019

cc @hualet

@z966768
Copy link
Copy Markdown
Member

z966768 commented Jul 9, 2020

2个问题：1.我们当前版本只支持标准模式，标准模式的处理由于之前的需求，直接出结果，逻辑一般的计算器不同，例如5000-30%，直接会显示为5000-0.3，不会合起来计算为5000-(5000×0.3)。如果要修改，可能得提新的需求。2.这一笔代码合入后，计算5000-（30%）的值与5000-30%的值相同，和一些计算器有出入，需要考虑，故当前版本不予合入

@hundundadi
Copy link
Copy Markdown

hundundadi commented Oct 31, 2023

After our internal analysis, this modification will cause the existing calculation logic of the calculator to change and does not conform to the calculation logic, so this PR cannot be incorporated.

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Oct 11, 2024

TAG Bot

New tag: 6.0.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #110

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Oct 14, 2024

TAG Bot

New tag: 6.0.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #114

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Oct 16, 2024

TAG Bot

New tag: 6.5.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #115

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Nov 30, 2024

TAG Bot

New tag: 6.5.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #117

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Dec 2, 2024

TAG Bot

New tag: 6.5.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #118

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Dec 14, 2024

TAG Bot

New tag: 6.5.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #120

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Dec 20, 2024

TAG Bot

New tag: 6.5.4
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #129

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jan 20, 2025

TAG Bot

New tag: 6.5.5
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #133

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jan 23, 2025

TAG Bot

New tag: 6.5.6
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #134

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Feb 18, 2025

TAG Bot

New tag: 6.5.7
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #135

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Feb 27, 2025

TAG Bot

New tag: 6.5.8
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #136

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Mar 7, 2025

TAG Bot

New tag: 6.5.9
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #138

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Apr 2, 2025

TAG Bot

New tag: 6.5.10
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #141

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Apr 17, 2025

TAG Bot

New tag: 6.5.11
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #144

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented May 14, 2025

TAG Bot

New tag: 6.5.12
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #145

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 18, 2025

TAG Bot

New tag: 6.5.13
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #150

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 18, 2025

TAG Bot

New tag: 6.5.14
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #151

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 18, 2025

TAG Bot

New tag: 6.5.15
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #152

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 23, 2025

TAG Bot

New tag: 6.5.16
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #154

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jul 1, 2025

TAG Bot

New tag: 6.5.17
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #155

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jul 2, 2025

TAG Bot

New tag: 6.5.18
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #156

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jul 3, 2025

TAG Bot

New tag: 6.5.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #157

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jul 10, 2025

TAG Bot

New tag: 6.5.20
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #160

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jul 31, 2025

TAG Bot

New tag: 6.5.21
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #164

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Aug 1, 2025

TAG Bot

New tag: 6.5.22
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #165

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Aug 7, 2025

TAG Bot

New tag: 6.5.23
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #166

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Aug 13, 2025

TAG Bot

New tag: 6.5.24
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #168

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Aug 27, 2025

TAG Bot

New tag: 6.5.25
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #169

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Sep 17, 2025

TAG Bot

New tag: 6.5.26
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #171

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Oct 16, 2025

TAG Bot

New tag: 6.5.27
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #174

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Nov 21, 2025

TAG Bot

New tag: 6.5.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #183

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Nov 27, 2025

TAG Bot

New tag: 6.5.30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #185

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Dec 11, 2025

TAG Bot

New tag: 6.5.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #188

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jan 28, 2026

TAG Bot

New tag: 6.5.32
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #192

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jan 29, 2026

TAG Bot

New tag: 6.5.33
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #194

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Mar 5, 2026

TAG Bot

New tag: 6.5.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #196

@wyu71
Copy link
Copy Markdown
Contributor

wyu71 commented Mar 16, 2026 •
edited
Loading

@iovxw After our internal analysis, this change would break the existing calculator logic, so we can't merge it as is. Closing for now, but we're happy to revisit this if a specific need comes up.

@wyu71 wyu71 closed this Mar 16, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 16, 2026

CLA Assistant Lite bot:

如果你是以企业贡献者的身份进行提交，请联系我们签署企业贡献者许可协议
If you submit as corporate contributor, please contact us to sign our Corporate Contributor License Agreement

感谢您的提交，我们非常感谢。 像许多开源项目一样，在接受您的贡献之前，我们要求您签署我们的个人贡献者许可协议。 您只需发布与以下格式相同的评论即可签署个人贡献者许可协议。
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Individual Contributor License Agreement before we can accept your contribution. You can sign the Individual Contributor License Agreement by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA.

You can retrigger this bot by commenting recheck in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to use % in it?

5 participants

@iovxw @BLumia @z966768 @hundundadi @wyu71