Skip to content

chore: Update version to 6.0.57#606

Merged
lzwind merged 1 commit intolinuxdeepin:masterfrom
dengzhongyuan365-dev:master
Feb 5, 2026
Merged

chore: Update version to 6.0.57#606
lzwind merged 1 commit intolinuxdeepin:masterfrom
dengzhongyuan365-dev:master

Conversation

@dengzhongyuan365-dev
Copy link
Contributor

@dengzhongyuan365-dev dengzhongyuan365-dev commented Feb 5, 2026

  • update version to 6.0.57

log: update version to 6.0.57

Summary by Sourcery

Chores:

  • Update Debian changelog to reflect version 6.0.57 release.

- update version to 6.0.57

log: update version to 6.0.57
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the Debian package version metadata to 6.0.57 in the changelog to prepare a new release.

File-Level Changes

Change Details Files
Update Debian package version to 6.0.57 in the changelog for a new release.
  • Incremented the recorded package version to 6.0.57 in the latest changelog entry.
  • Adjusted the changelog text to reflect the new version number for this release.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

TAG Bot

TAG: 6.0.57
EXISTED: no
DISTRIBUTION: unstable

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

这段代码是 debian/changelog 文件的变更记录,主要记录了软件包 deepin-devicemanager 从 6.0.56 版本升级到 6.0.57 版本时的变更内容。

从语法和格式上看,这段 diff 符合 Debian changelog 的标准格式,没有明显的语法错误。

以下是从代码逻辑代码质量代码性能代码安全四个维度对变更内容的详细审查意见:

1. 代码逻辑与功能

  • fix: Improve command execution using QProcess:
    • 意见:使用 QProcess 执行外部命令通常比直接调用 system()popen() 更安全且更易于控制。建议确保在调用 QProcess::start()QProcess::execute() 时,正确处理了异步执行的信号槽(如 finished),并且对标准输出和标准错误进行了分离读取,以防止缓冲区阻塞。
  • fix: Fix Qt5 build failed issuebuild(cmake): refactor Qt version compatibility:
    • 意见:这表明项目正在维护跨 Qt 版本的兼容性。逻辑上需要确保 CMakeLists.txt 中正确使用了 find_package(Qt5 ...)find_package(Qt6 ...) 的逻辑分支,且没有引入新的编译警告。
  • fix(bluetooth): remove hci version attribute setting:
    • 意见:移除属性设置通常意味着之前的设置导致了问题(如权限不足或设备不支持)。逻辑上需确认移除后不会导致蓝牙功能的其他缺失,或者该属性确实是不必要的。
  • fix: from dmidecode get cpu num error:
    • 意见:修复获取 CPU 数量的错误。逻辑上需要确认是对 dmidecode 的输出解析逻辑进行了修正,还是改用了更可靠的系统调用(如读取 /proc/cpuinfo)。前者依赖外部命令稳定性,后者更稳健。
  • fix: disable bluetooth failed:
    • 意见:修复了无法禁用蓝牙的问题。这通常涉及权限或 DBus 调用逻辑。

2. 代码质量

  • 提交信息规范:使用了 Conventional Commits 规范(如 fix:, build(cmake):),这非常有助于自动化工具生成日志和版本号,值得肯定。
  • Changelog 格式:格式符合 Debian 标准,但在描述具体修复时,如果能简要说明修复的 Bug ID 或具体的错误现象(例如 "fix: disable bluetooth failed due to permission denied"),将更有利于后续维护和回溯。

3. 代码性能

  • QProcess 的使用:虽然 QProcess 提供了异步机制,但如果在代码中错误地使用了 waitForFinished(),会导致主线程阻塞,影响 UI 响应速度(考虑到这是 deepin-devicemanager,大概率是 GUI 应用)。建议:确保耗时较长的命令(如 dmidecode)使用异步方式执行,或者放在独立线程中运行。
  • dmidecode 调用dmidecode 需要root权限读取硬件信息,且执行速度较慢。建议:评估是否可以通过读取 /sys/class/dmi/id/ 下的文件来替代部分 dmidecode 的功能,这样可以显著提升性能并降低对 root 权限的依赖。

4. 代码安全

  • 命令注入风险:在 Improve command execution using QProcess 中,如果命令的参数部分包含了用户输入或不可信数据,必须使用 QProcess 的参数列表形式(start(program, arguments)),而严禁将整个命令拼接成一个字符串执行,以防止命令注入漏洞。
  • 权限控制:涉及蓝牙禁用和 dmidecode 的调用通常需要提升权限。建议:确保使用了 Polkit 等机制进行权限管理,而不是让整个程序以 root 权限运行,以减小安全攻击面。

总结与建议

这段变更记录主要涉及构建系统修复和硬件信息获取/蓝牙控制的逻辑修正。整体上是积极的维护工作。

改进建议:

  1. 异步处理:检查 QProcess 相关代码,确保没有阻塞 UI 主线程。
  2. 减少依赖:尽可能用读取 /sys 文件系统替代 dmidecode 调用以提升性能和安全性。
  3. 参数化调用:确保 QProcess 调用时严格使用参数列表模式,避免命令注入风险。
  4. 日志细化:Changelog 中可以适当增加 Bug ID 或更具体的错误描述,方便追踪。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit 22045ff into linuxdeepin:master Feb 5, 2026
17 of 19 checks passed
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Feb 5, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.0.57
  • Tag SHA: 082341a7f5899aa9f75f9038d73176029436ace8
  • Commit SHA: 790575670370acdc408e8cd43adf1c9ef0ebaad8
  • Tag Message:
    Release deepin-devicemanager 6.0.57
    
    
  • Tagger:
    • Name: dengzhongyuan365-dev
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants