Fix: Remove useless code. by GongHeng2017 · Pull Request #619 · linuxdeepin/deepin-devicemanager

GongHeng2017 · 2026-03-17T03:07:57Z

-- Remove useless code.

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-352671.html

Summary by Sourcery

Enhancements:

Clean up CommonTools by deleting the unused getGpuInfoCommandFromDConfig API and its declaration.

sourcery-ai · 2026-03-17T03:08:21Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes an unused helper method for retrieving a GPU info command from DConfig, simplifying the CommonTools interface to only expose the GPU info pre-generation API that is actually used.

Class diagram for CommonTools before removal of getGpuInfoCommandFromDConfig

classDiagram
    class CommonTools {
        +static QString getBackupPath()
        +static void parseEDID(const QStringList allEDIDS, const QString input, bool isHW)
        +static QString getGpuInfoCommandFromDConfig()
        +static QString preGenerateGpuInfo()
    }

Updated class diagram for CommonTools after removal of getGpuInfoCommandFromDConfig

classDiagram
    class CommonTools {
        +static QString getBackupPath()
        +static void parseEDID(const QStringList allEDIDS, const QString input, bool isHW)
        +static QString preGenerateGpuInfo()
    }

File-Level Changes

Change	Details	Files
Remove unused GPU info command lookup helper and its declaration from CommonTools.	Delete the static CommonTools::getGpuInfoCommandFromDConfig implementation that created a DConfig instance and read the CommandToGetGPUInfo key. Remove the corresponding static method declaration from the CommonTools class interface, leaving preGenerateGpuInfo as the primary GPU-related helper.	`deepin-devicemanager/src/Tool/commontools.cpp` `deepin-devicemanager/src/Tool/commontools.h`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

github-actions · 2026-03-17T03:09:20Z

Note

[静态代码检查]

敏感词检查失败, 检测到1个文件存在敏感词

详情

{
    "deepin-devicemanager/src/Tool/commontools.cpp": [
        {
            "line": "        return \"https://driver.uniontech.com/api/v1/drive/search\";",
            "line_number": 177,
            "rule": "S35",
            "reason": "Url link | 162cef9d4a"
        },
        {
            "line": "        return \"https://driver.uniontech.com/api/v1/drive/search\";",
            "line_number": 182,
            "rule": "S35",
            "reason": "Url link | 162cef9d4a"
        },
        {
            "line": "        return \"https://drive-pre.uniontech.com/api/v1/drive/search\";",
            "line_number": 185,
            "rule": "S35",
            "reason": "Url link | 0e010283c1"
        }
    ]
}

lzwind

改下年份

-- Remove useless code. Log: fix issue Bug: https://pms.uniontech.com/bug-view-352671.html

deepin-ci-robot · 2026-03-17T03:17:12Z

deepin pr auto review

这段代码diff主要涉及两个文件的修改：

commontools.cpp：删除了 getGpuInfoCommandFromDConfig() 函数的实现，并更新了版权年份。
commontools.h：删除了 getGpuInfoCommandFromDConfig() 函数的声明。

下面是对这些修改的详细审查意见：

1. 版权信息更新

-// SPDX-FileCopyrightText: 2022 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2022 - 2026 UnionTech Software Technology Co., Ltd.

审查意见：

✅ 合理：更新版权年份是常规维护操作，表示代码将持续维护到2026年。
⚠️ 建议：如果这是自动生成的代码，可以考虑使用动态年份（如2022 - [CurrentYear]），避免每年手动更新。

2. 删除 `getGpuInfoCommandFromDConfig()` 函数

-QString CommonTools::getGpuInfoCommandFromDConfig()
-{
-    QString cmd;
-    DConfig *dconfig = DConfig::create("org.deepin.devicemanager","org.deepin.devicemanager");
-    if (dconfig && dconfig->isValid() && dconfig->keyList().contains("CommandToGetGPUInfo"))
-        cmd = dconfig->value("CommandToGetGPUInfo").toString();
-    return cmd;
-}

审查意见：

✅ 合理：如果该函数不再被使用，删除它是正确的做法，避免死代码。
⚠️ 潜在问题：删除该函数前，需要确认：
1. 该函数是否在其他地方被调用？（建议全局搜索）
2. 是否有替代方案来获取GPU信息命令？
3. 如果该功能被移除，是否会影响GPU信息的获取逻辑？

3. 代码质量与性能分析

原函数存在以下问题：

内存泄漏风险：
- DConfig::create() 返回的指针未被释放，可能导致内存泄漏。
- 建议使用智能指针（如QScopedPointer）或手动delete。
重复创建DConfig对象：
- 如果该函数被频繁调用，每次都会创建新的DConfig对象，影响性能。
- 建议将DConfig对象缓存为静态成员或单例。
字符串比较效率：
- dconfig->keyList().contains("CommandToGetGPUInfo") 会遍历整个键列表，效率较低。
- 建议直接调用dconfig->value("CommandToGetGPUInfo")，并检查返回值是否有效。

4. 改进建议（如果需要保留类似功能）

如果未来需要类似功能，建议重构为：

QString CommonTools::getGpuInfoCommandFromDConfig()
{
    static DConfig *dconfig = DConfig::create("org.deepin.devicemanager", "org.deepin.devicemanager");
    static bool initialized = false;
    
    if (!initialized && dconfig && dconfig->isValid()) {
        initialized = true;
    }
    
    if (initialized) {
        return dconfig->value("CommandToGetGPUInfo").toString();
    }
    return QString();
}

改进点：

使用静态变量避免重复创建DConfig对象。
简化键检查逻辑，直接读取值。
避免内存泄漏（静态变量在程序结束时自动释放）。

5. 安全性审查

命令注入风险：
- 如果CommandToGetGPUInfo的值来自用户输入或配置文件，直接执行可能导致命令注入。
- 建议对返回的命令进行白名单验证或转义。
配置文件安全性：
- 确保DConfig的配置文件权限正确，避免被恶意修改。

总结

删除操作合理：如果该函数确实不再被使用，删除是正确的。
潜在风险：需确认GPU信息获取逻辑是否受影响。
未来改进：如需类似功能，建议重构以提高性能和安全性。

如果需要进一步分析或补充代码，请提供更多上下文（如preGenerateGpuInfo()的实现）。

github-actions · 2026-03-17T03:17:38Z

Note

[静态代码检查]

敏感词检查失败, 检测到1个文件存在敏感词

详情

{
    "deepin-devicemanager/src/Tool/commontools.cpp": [
        {
            "line": "        return \"https://driver.uniontech.com/api/v1/drive/search\";",
            "line_number": 177,
            "rule": "S35",
            "reason": "Url link | 162cef9d4a"
        },
        {
            "line": "        return \"https://driver.uniontech.com/api/v1/drive/search\";",
            "line_number": 182,
            "rule": "S35",
            "reason": "Url link | 162cef9d4a"
        },
        {
            "line": "        return \"https://drive-pre.uniontech.com/api/v1/drive/search\";",
            "line_number": 185,
            "rule": "S35",
            "reason": "Url link | 0e010283c1"
        }
    ]
}

deepin-ci-robot · 2026-03-17T03:23:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, lzwind

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

GongHeng2017 · 2026-03-17T03:26:51Z

/forcemerge

deepin-bot · 2026-03-17T03:27:09Z

This pr force merged! (status: unstable)

sourcery-ai Bot reviewed Mar 17, 2026

View reviewed changes

lzwind approved these changes Mar 17, 2026

View reviewed changes

lzwind requested changes Mar 17, 2026

View reviewed changes

Fix: Remove useless code.

f3ed0e6

-- Remove useless code. Log: fix issue Bug: https://pms.uniontech.com/bug-view-352671.html

GongHeng2017 force-pushed the 202603171103-master-fix branch from 6115ac8 to f3ed0e6 Compare March 17, 2026 03:16

lzwind approved these changes Mar 17, 2026

View reviewed changes

deepin-bot Bot merged commit 8509a18 into linuxdeepin:master Mar 17, 2026
21 of 22 checks passed

Conversation

GongHeng2017 commented Mar 17, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Mar 17, 2026

Reviewer's Guide

Class diagram for CommonTools before removal of getGpuInfoCommandFromDConfig

Updated class diagram for CommonTools after removal of getGpuInfoCommandFromDConfig

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 17, 2026

Uh oh!

lzwind left a comment

Choose a reason for hiding this comment

Uh oh!

deepin-ci-robot commented Mar 17, 2026

deepin pr auto review

1. 版权信息更新

2. 删除 getGpuInfoCommandFromDConfig() 函数

3. 代码质量与性能分析

4. 改进建议（如果需要保留类似功能）

5. 安全性审查

总结

Uh oh!

github-actions Bot commented Mar 17, 2026

Uh oh!

deepin-ci-robot commented Mar 17, 2026

Uh oh!

GongHeng2017 commented Mar 17, 2026

Uh oh!

deepin-bot Bot commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GongHeng2017 commented Mar 17, 2026 •

edited by sourcery-ai Bot

Loading

2. 删除 `getGpuInfoCommandFromDConfig()` 函数