-
Notifications
You must be signed in to change notification settings - Fork 34
feat: hide specific version of UFS #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
only shows USF and hide the versions. Log: as above. Task: https://pms.uniontech.com/task-view-382543.html
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSimplify UFS interface labeling by collapsing version-specific checks into a single generic UFS label. Class diagram for updated DeviceStorage::getDiskInfoInterface() logicclassDiagram
class DeviceStorage {
+void getDiskInfoInterface(devicePath: QString, interface: QString)
}
class Utils {
+QString readContent(path: QString)
}
DeviceStorage --> Utils: uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review这段代码审查如下:
改进建议:
if (spec_version.contains("300")) {
interface = "UFS 3.0";
} else if (spec_version.contains("310")) {
interface = "UFS 3.1";
} else if (spec_version.contains("400")) {
interface = "UFS 4.0";
}
// 统一返回UFS接口类型,不区分具体版本
if (spec_version.contains("300") || spec_version.contains("310") || spec_version.contains("400")) {
interface = "UFS";
}
QMap<QString, QString> ufsVersionMap = {
{"300", "UFS 3.0"},
{"310", "UFS 3.1"},
{"400", "UFS 4.0"}
};
for (auto it = ufsVersionMap.constBegin(); it != ufsVersionMap.constEnd(); ++it) {
if (spec_version.contains(it.key())) {
interface = it.value();
break;
}
}这样的改进既保持了代码的清晰性,又便于后续添加新的UFS版本,同时提高了代码的可维护性。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: itsXuSt, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
only shows USF and hide the versions.
Log: as above.
Task: https://pms.uniontech.com/task-view-382543.html
Summary by Sourcery
Enhancements: