Skip to content

feat(footer): add Documentation and Contact support links#175

Open
nunoeufrasio wants to merge 2 commits into
mainfrom
feat/footer-links
Open

feat(footer): add Documentation and Contact support links#175
nunoeufrasio wants to merge 2 commits into
mainfrom
feat/footer-links

Conversation

@nunoeufrasio

Copy link
Copy Markdown
Contributor

What

Adds two links to the footer Platform section, and a Documentation entry to the navbar More menu:

How

  • Footer "Contact support" mirrors the For Companies CTA: useIntercom() is resolved in footer.vue's setup() with a local openIntercom() handler. The menu config stays declarative via a new intercom: true link variant.
  • Navbar children gain an optional external flag so the Documentation link renders with target="_blank" + rel="noopener noreferrer" (desktop nav and mobile menu).
  • Left-aligned the footer action buttons (text-left) so they line up with the anchor links — also fixes pre-existing drift on "Start a Fundraise".

Related

Checklist

  • Type-check + lint clean
  • No new files (license headers N/A)
  • Verified in browser: links render, new-tab works, click fires Intercom show
  • Diff under 1000 lines (~32 lines)

Note: clicking "Contact support" fires window.Intercom('show') correctly, but the messenger only renders on allowlisted Intercom domains — not visible on localhost (same as #174).

🤖 Generated with Claude Code

Add two links to the footer Platform section:
- Documentation: opens docs.linuxfoundation.org/lfx/crowdfunding in a new tab
- Contact support: opens the Intercom messenger via useIntercom().show(),
  mirroring the For Companies Contact our team button

Also add Documentation to the navbar More menu (below About) with
external new-tab handling, and left-align footer action buttons.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Nuno Eufrasio <nmeufrasio@gmail.com>
Copilot AI review requested due to automatic review settings June 16, 2026 18:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the frontend navigation to add a Documentation link (opening the Linux Foundation docs in a new tab) and a Contact support footer entry that opens Intercom, aligning footer behavior with the existing Intercom CTA introduced in #174.

Changes:

  • Added a Documentation entry to the header “More” menu with an external flag to render target="_blank" + rel="noopener noreferrer".
  • Added Documentation and Contact support entries to the footer “Platform” section, with Contact support opening Intercom via useIntercom().show().
  • Extended footer link typing to support a declarative intercom: true link variant.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/app/types/footer.types.ts Extends footer menu link union type to support an intercom: true variant.
frontend/app/config/menu/header.ts Adds “Documentation” child item and introduces optional external flag on header children.
frontend/app/config/menu/footer.ts Adds “Documentation” (external) and “Contact support” (Intercom) entries to footer Platform links.
frontend/app/components/shared/layout/footer.vue Renders Intercom footer link as a button and wires it to useIntercom().show(); aligns button text styling.
frontend/app/components/shared/layout/components/mobile-menu.vue Applies target/rel for external “More” children links in the mobile menu.
frontend/app/components/shared/layout/components/desktop-nav.vue Applies target/rel for external “More” children links in the desktop dropdown.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lewisojile
lewisojile previously approved these changes Jun 16, 2026

@lewisojile lewisojile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread frontend/app/config/menu/footer.ts Outdated
Comment thread frontend/app/config/menu/header.ts Outdated
Address review comments from @mlehotskylf:

- config/menu/footer.ts: point Documentation to the in-app /docs route
  instead of the deprecated docs.linuxfoundation.org CF docs
- config/menu/header.ts: point More-menu Documentation to /docs and drop
  the now-unused external flag
- layout/components/desktop-nav.vue, mobile-menu.vue: revert external
  new-tab handling (no longer needed for an in-app link)

The in-app docs system is introduced in #166 (AppRoute.Docs = '/docs').

Resolves 2 review threads.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Nuno Eufrasio <nmeufrasio@gmail.com>
@nunoeufrasio

Copy link
Copy Markdown
Contributor Author

Review Feedback Addressed

Commit: e8f89d4

Changes Made

  • config/menu/footer.ts: Documentation link now points to the in-app /docs route instead of the deprecated docs.linuxfoundation.org CF docs (per @mlehotskylf)
  • config/menu/header.ts: More-menu Documentation entry now points to /docs; dropped the now-unused external flag (per @mlehotskylf)
  • layout/components/desktop-nav.vue, mobile-menu.vue: reverted the external new-tab handling — no longer needed for an in-app link

Both Documentation links are now internal links to the in-app docs system introduced in #166. "Contact support" (Intercom) is unchanged.

Threads Resolved

2 of 2 unresolved threads addressed in this iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants