Skip to content

temperature@india - Updating the Thermometer Desklet#1765

Open
OnlineLearningTutorials wants to merge 3 commits intolinuxmint:masterfrom
OnlineLearningTutorials:master
Open

temperature@india - Updating the Thermometer Desklet#1765
OnlineLearningTutorials wants to merge 3 commits intolinuxmint:masterfrom
OnlineLearningTutorials:master

Conversation

@OnlineLearningTutorials
Copy link
Copy Markdown
Contributor

screenshot

Thermometer Desklet is updated to make it work properly. However the configure window is not opening, and it is difficult to debug why configure window not opened, working on Cinnamon 6.4.13 version. So I am not sure whether all option are working properly.

@github-actions
Copy link
Copy Markdown

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.


Found 2 potential issue(s):

⚠️ hardcoded_data_dir

temperature@india/files/temperature@india/desklet.js:32

let desklet_path = GLib.get_home_dir() + "/.local/share/cinnamon/desklets/" + UUID;

Avoid hardcoding .local/share in paths. Use GLib.get_user_data_dir() instead,
which respects the XDG_DATA_HOME environment variable.

⚠️ lang_bind

temperature@india/files/temperature@india/desklet.js:77

this.timeoutId = Mainloop.timeout_add_seconds(this.update_interval || 2, Lang.bind(this, this.updateTemperature));

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.


Automated pattern check.

@claudiux
Copy link
Copy Markdown
Member

claudiux commented Mar 20, 2026

@OnlineLearningTutorials

However the configure window is not opening, and it is difficult to debug why configure window not opened,

Use a settings-schema.json file, as is common for many other desklets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants