Skip to content

adventCandles@KopfdesDaemons: Version 2.0.0#1815

Merged
rcalixte merged 13 commits intolinuxmint:masterfrom
KopfdesDaemons:adventCandles
Apr 11, 2026
Merged

adventCandles@KopfdesDaemons: Version 2.0.0#1815
rcalixte merged 13 commits intolinuxmint:masterfrom
KopfdesDaemons:adventCandles

Conversation

@KopfdesDaemons
Copy link
Copy Markdown
Contributor

  • New Features
    • Custom candle colors (Feature request from @DGedye on the Cinnamon website)
    • Color presets (traditional or red)
    • Setting for number of lit candles (1-4 or automatic)
    • Setting to enable/disable animation
  • Refactoring
    • Improved performance by image caching
    • Improved animation and candle update loop logic
    • Made getAdventCandlesNumber() more readable
    • Removed hard-coded local folder path
    • Removed settings.getValue() (use binding)
    • Moved prevent-decorations to metadata.json
    • Removed imports.lang
    • Changed desklet entry point to on_desklet_added_to_desktop()
    • Kebab case for setting names
    • Cleaned up settings in on_desklet_removed() function
  • Fixes
    • fixed broken desklet scale setting on image without a lit candle
screenshot

@github-actions
Copy link
Copy Markdown

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.


Found 1 potential issue(s):

⚠️ sync_file_load_contents

adventCandles@KopfdesDaemons/files/adventCandles@KopfdesDaemons/desklet.js:267

const [success, contents] = file.load_contents(null);

Synchronous load_contents() blocks the main loop.
Use load_contents_async() instead.


Automated pattern check.

@rcalixte rcalixte merged commit b6e5af2 into linuxmint:master Apr 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants