Sniff remote files mimetype#3802
Open
leigh123linux wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses #2319 by adding a remote-file MIME sniffing fallback so that files reported as application/octet-stream over SFTP/SSH are re-evaluated from their contents (so ASCII/text files can open in a text editor instead of being treated as binary/archives).
Changes:
- Introduces an async read-and-sniff path for remote (non-native) files that initially resolve to
application/octet-stream. - Adds a per-file guard flag (
mime_type_sniffed) to avoid repeated sniffing / prevent later overwrites back to octet-stream. - Resets the sniff guard when clearing file info.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| libnemo-private/nemo-file.c | Adds async remote MIME sniffing and integrates it into update_info_internal() when MIME resolves to octet-stream. |
| libnemo-private/nemo-file-private.h | Adds a new mime_type_sniffed bitfield to track sniffing state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2314
to
+2319
| g_input_stream_close_async (G_INPUT_STREAM (source), G_PRIORITY_LOW, NULL, NULL, NULL); | ||
| mime_sniff_data_free (data); | ||
| } | ||
|
|
||
| static void | ||
| mime_sniff_open_cb (GObject *source, GAsyncResult *res, gpointer user_data) |
Comment on lines
+2820
to
+2833
| if (!file->details->mime_type_sniffed && | ||
| g_strcmp0 (file->details->mime_type, "application/octet-stream") == 0) { | ||
| GFile *location = nemo_file_get_location (file); | ||
|
|
||
| file->details->mime_type_sniffed = TRUE; | ||
|
|
||
| if (location != NULL) { | ||
| if (!g_file_is_native (location) && | ||
| size > 0 && size <= NEMO_MIME_SNIFF_MAX_SIZE) { | ||
| nemo_file_sniff_remote_mime_type_async (file, location); | ||
| } | ||
| g_object_unref (location); | ||
| } | ||
| } |
Comment on lines
85
to
+88
| GRefString *mime_type; | ||
|
|
||
|
|
||
| eel_boolean_bit mime_type_sniffed : 1; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue by adding a remote-file MIME sniffing fallback so that files reported as application/octet-stream over SFTP/SSH/FTP are re-evaluated from their contents (so ASCII/text files can open in a text editor instead of being treated as binary/archives).
Changes:
Introduces an async read-and-sniff path for remote (non-native) files that initially resolve to application/octet-stream.
Adds a per-file guard flag (mime_type_sniffed) to avoid repeated sniffing / prevent later overwrites back to octet-stream.
Resets the sniff guard when clearing file info.
Fixes. #2319