Add test suite, ESLint, CI/CD and optimize code#1
Merged
Conversation
- Add 69 unit tests using Node.js built-in test runner covering lib/utils.js, lib/cache.js, lib/api.js, and background/background.js - Add ESLint with flat config for code quality enforcement - Add GitHub Actions CI workflow (lint + test on Node 20/22, XPI packaging) - Optimize popup.js: replace while-loop DOM clearing with replaceChildren(), extract repeated domain resolution into resolveDomain(), extract split/trim/filter patterns into splitLines() and splitCommas() - Optimize cache: add updateCachedAlias() and removeCachedAlias() for granular cache updates instead of full invalidation on update/delete - Remove unused invalidatePrefix() from cache.js https://claude.ai/code/session_014gvV77pkPUkuUy7rh9URFr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/utils.js, lib/cache.js, lib/api.js, and background/background.js
extract repeated domain resolution into resolveDomain(), extract
split/trim/filter patterns into splitLines() and splitCommas()
granular cache updates instead of full invalidation on update/delete